[PATCH 0/4] Storage volume (crash) fixes

Peter Krempa posted 4 patches 3 years, 2 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1614259540.git.pkrempa@redhat.com
src/conf/storage_conf.c                       | 59 +++++++++++--------
src/storage/storage_util.c                    |  5 +-
.../storagevolxml2xmlout/vol-file-backing.xml |  2 -
tests/storagevolxml2xmlout/vol-file-iso.xml   |  2 -
.../storagevolxml2xmlout/vol-file-naming.xml  |  2 -
tests/storagevolxml2xmlout/vol-file.xml       |  2 -
.../vol-gluster-dir-neg-uid.xml               |  2 -
.../storagevolxml2xmlout/vol-gluster-dir.xml  |  2 -
.../vol-logical-backing.xml                   |  2 -
tests/storagevolxml2xmlout/vol-logical.xml    |  2 -
.../storagevolxml2xmlout/vol-luks-cipher.xml  |  2 -
tests/storagevolxml2xmlout/vol-luks.xml       |  2 -
tests/storagevolxml2xmlout/vol-partition.xml  |  2 -
.../vol-qcow2-0.10-lazy.xml                   |  2 -
tests/storagevolxml2xmlout/vol-qcow2-1.1.xml  |  2 -
.../vol-qcow2-encryption.xml                  |  2 -
tests/storagevolxml2xmlout/vol-qcow2-lazy.xml |  2 -
tests/storagevolxml2xmlout/vol-qcow2-luks.xml |  2 -
.../vol-qcow2-nobacking.xml                   |  2 -
.../vol-qcow2-nocapacity.xml                  |  2 -
tests/storagevolxml2xmlout/vol-qcow2.xml      |  2 -
tests/storagevolxml2xmlout/vol-sheepdog.xml   |  2 -
22 files changed, 35 insertions(+), 69 deletions(-)
[PATCH 0/4] Storage volume (crash) fixes
Posted by Peter Krempa 3 years, 2 months ago
Patch 1/4 should go into this release, the rest can wait.

Peter Krempa (4):
  storageBackendProbeTarget: Check return value of
    virStorageSourceNewFromBacking
  storageBackendProbeTarget: Don't fail if backing store can't be parsed
  virStorageVolDefFormat: Extract formatting of source extents
  virStorageVolDefFormat: Don't format empty <source>

 src/conf/storage_conf.c                       | 59 +++++++++++--------
 src/storage/storage_util.c                    |  5 +-
 .../storagevolxml2xmlout/vol-file-backing.xml |  2 -
 tests/storagevolxml2xmlout/vol-file-iso.xml   |  2 -
 .../storagevolxml2xmlout/vol-file-naming.xml  |  2 -
 tests/storagevolxml2xmlout/vol-file.xml       |  2 -
 .../vol-gluster-dir-neg-uid.xml               |  2 -
 .../storagevolxml2xmlout/vol-gluster-dir.xml  |  2 -
 .../vol-logical-backing.xml                   |  2 -
 tests/storagevolxml2xmlout/vol-logical.xml    |  2 -
 .../storagevolxml2xmlout/vol-luks-cipher.xml  |  2 -
 tests/storagevolxml2xmlout/vol-luks.xml       |  2 -
 tests/storagevolxml2xmlout/vol-partition.xml  |  2 -
 .../vol-qcow2-0.10-lazy.xml                   |  2 -
 tests/storagevolxml2xmlout/vol-qcow2-1.1.xml  |  2 -
 .../vol-qcow2-encryption.xml                  |  2 -
 tests/storagevolxml2xmlout/vol-qcow2-lazy.xml |  2 -
 tests/storagevolxml2xmlout/vol-qcow2-luks.xml |  2 -
 .../vol-qcow2-nobacking.xml                   |  2 -
 .../vol-qcow2-nocapacity.xml                  |  2 -
 tests/storagevolxml2xmlout/vol-qcow2.xml      |  2 -
 tests/storagevolxml2xmlout/vol-sheepdog.xml   |  2 -
 22 files changed, 35 insertions(+), 69 deletions(-)

-- 
2.29.2

Re: [PATCH 0/4] Storage volume (crash) fixes
Posted by Michal Privoznik 3 years, 1 month ago
On 2/25/21 2:26 PM, Peter Krempa wrote:
> Patch 1/4 should go into this release, the rest can wait.
> 
> Peter Krempa (4):
>    storageBackendProbeTarget: Check return value of
>      virStorageSourceNewFromBacking
>    storageBackendProbeTarget: Don't fail if backing store can't be parsed
>    virStorageVolDefFormat: Extract formatting of source extents
>    virStorageVolDefFormat: Don't format empty <source>
> 
>   src/conf/storage_conf.c                       | 59 +++++++++++--------
>   src/storage/storage_util.c                    |  5 +-
>   .../storagevolxml2xmlout/vol-file-backing.xml |  2 -
>   tests/storagevolxml2xmlout/vol-file-iso.xml   |  2 -
>   .../storagevolxml2xmlout/vol-file-naming.xml  |  2 -
>   tests/storagevolxml2xmlout/vol-file.xml       |  2 -
>   .../vol-gluster-dir-neg-uid.xml               |  2 -
>   .../storagevolxml2xmlout/vol-gluster-dir.xml  |  2 -
>   .../vol-logical-backing.xml                   |  2 -
>   tests/storagevolxml2xmlout/vol-logical.xml    |  2 -
>   .../storagevolxml2xmlout/vol-luks-cipher.xml  |  2 -
>   tests/storagevolxml2xmlout/vol-luks.xml       |  2 -
>   tests/storagevolxml2xmlout/vol-partition.xml  |  2 -
>   .../vol-qcow2-0.10-lazy.xml                   |  2 -
>   tests/storagevolxml2xmlout/vol-qcow2-1.1.xml  |  2 -
>   .../vol-qcow2-encryption.xml                  |  2 -
>   tests/storagevolxml2xmlout/vol-qcow2-lazy.xml |  2 -
>   tests/storagevolxml2xmlout/vol-qcow2-luks.xml |  2 -
>   .../vol-qcow2-nobacking.xml                   |  2 -
>   .../vol-qcow2-nocapacity.xml                  |  2 -
>   tests/storagevolxml2xmlout/vol-qcow2.xml      |  2 -
>   tests/storagevolxml2xmlout/vol-sheepdog.xml   |  2 -
>   22 files changed, 35 insertions(+), 69 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal