[v2] Use g_autoptr and g_autofree

[PATCH v2 0/3] Use g_autoptr and g_autofree

Kristina Hanicova posted 3 patches 3 years, 1 month ago

Diff against v1
Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1614253690.git.khanicov@redhat.com

src/conf/domain_conf.c        |  3 +-
src/conf/networkcommon_conf.c | 90 +++++++++++++++--------------------
src/lxc/lxc_native.c          | 10 ++--
src/vz/vz_sdk.c               |  3 +-
4 files changed, 44 insertions(+), 62 deletions(-)

Expand all Fold all

[PATCH v2 0/3] Use g_autoptr and g_autofree

Posted by Kristina Hanicova 3 years, 1 month ago

This is v2 from
https://listman.redhat.com/archives/libvir-list/2021-February/msg01129.html

I changed variable names in patch 1/3 as suggested by Laine. Patches 2/3
and 3/3 have already been reviewed-by and I am sending them for
completeness.

This uses g_autofree (if possible) in file networkcommon_conf and
g_autoptr instead of virNetDevIPRouteFree where possible.


Kristina Hanicova (3):
  networkcommon_conf: Use g_autofree where possible
  Use g_autoptr instead of virNetDevIPRouteFree if possible
  Remove redundant variables/labels

 src/conf/domain_conf.c        |  3 +-
 src/conf/networkcommon_conf.c | 90 +++++++++++++++--------------------
 src/lxc/lxc_native.c          | 10 ++--
 src/vz/vz_sdk.c               |  3 +-
 4 files changed, 44 insertions(+), 62 deletions(-)

-- 
2.29.2

Re: [PATCH v2 0/3] Use g_autoptr and g_autofree

Posted by Laine Stump 3 years, 1 month ago

On 2/25/21 6:51 AM, Kristina Hanicova wrote:
> This is v2 from
> https://listman.redhat.com/archives/libvir-list/2021-February/msg01129.html
> 
> I changed variable names in patch 1/3 as suggested by Laine. Patches 2/3
> and 3/3 have already been reviewed-by and I am sending them for
> completeness.
> 
> This uses g_autofree (if possible) in file networkcommon_conf and
> g_autoptr instead of virNetDevIPRouteFree where possible.
> 
> 
> Kristina Hanicova (3):
>    networkcommon_conf: Use g_autofree where possible
>    Use g_autoptr instead of virNetDevIPRouteFree if possible
>    Remove redundant variables/labels
> 
>   src/conf/domain_conf.c        |  3 +-
>   src/conf/networkcommon_conf.c | 90 +++++++++++++++--------------------
>   src/lxc/lxc_native.c          | 10 ++--
>   src/vz/vz_sdk.c               |  3 +-
>   4 files changed, 44 insertions(+), 62 deletions(-)
> 

Reviewed-by: Laine Stump <laine@redhat.com>
(for all 3) and pushed.