[PATCH 0/6] util: alloc: Remove VIR_ALLOC_VAR

Peter Krempa posted 6 patches 3 years, 2 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1612358891.git.pkrempa@redhat.com
src/conf/nwfilter_params.c        |  6 ++--
src/conf/nwfilter_params.h        |  2 +-
src/libvirt_private.syms          |  1 -
src/locking/lock_driver_sanlock.c | 50 +++++++++++--------------------
src/util/viralloc.c               | 33 --------------------
src/util/viralloc.h               | 35 ----------------------
src/util/virnetdev.c              |  5 ++--
7 files changed, 24 insertions(+), 108 deletions(-)
[PATCH 0/6] util: alloc: Remove VIR_ALLOC_VAR
Posted by Peter Krempa 3 years, 2 months ago
One user was reimplemented using a more common approach, two users use a
constant size so were reimplemented using g_malloc + sizeof.

Peter Krempa (6):
  virNWFilterVarCombIter: Allocate 'iter' member separately
  virLockManagerSanlockAddLease: Refactor cleanup
  virLockManagerSanlockAddDisk: Refactor cleanup
  locking: sanlock: Avoid use of VIR_ALLOC_VAR for 'struct
    sanlk_resource'
  virNetDevGetEthtoolGFeatures: Avoid use of VIR_ALLOC_VAR
  viralloc: Remove VIR_ALLOC_VAR

 src/conf/nwfilter_params.c        |  6 ++--
 src/conf/nwfilter_params.h        |  2 +-
 src/libvirt_private.syms          |  1 -
 src/locking/lock_driver_sanlock.c | 50 +++++++++++--------------------
 src/util/viralloc.c               | 33 --------------------
 src/util/viralloc.h               | 35 ----------------------
 src/util/virnetdev.c              |  5 ++--
 7 files changed, 24 insertions(+), 108 deletions(-)

-- 
2.29.2

Re: [PATCH 0/6] util: alloc: Remove VIR_ALLOC_VAR
Posted by Daniel P. Berrangé 3 years, 2 months ago
On Wed, Feb 03, 2021 at 02:34:20PM +0100, Peter Krempa wrote:
> One user was reimplemented using a more common approach, two users use a
> constant size so were reimplemented using g_malloc + sizeof.
> 
> Peter Krempa (6):
>   virNWFilterVarCombIter: Allocate 'iter' member separately
>   virLockManagerSanlockAddLease: Refactor cleanup
>   virLockManagerSanlockAddDisk: Refactor cleanup
>   locking: sanlock: Avoid use of VIR_ALLOC_VAR for 'struct
>     sanlk_resource'
>   virNetDevGetEthtoolGFeatures: Avoid use of VIR_ALLOC_VAR
>   viralloc: Remove VIR_ALLOC_VAR

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|