Fix a slightly rework auto completion

[PATCH 0/9] Fix a slightly rework auto completion

Michal Privoznik posted 9 patches 3 years, 2 months ago

Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1611667532.git.mprivozn@redhat.com

tools/bash-completion/vsh |   2 +-
tools/virsh.c             |   4 +-
tools/virt-admin.c        |   4 +-
tools/vsh.c               | 125 ++++++++++++++++++++++++--------------
tools/vsh.h               |   5 +-
5 files changed, 88 insertions(+), 52 deletions(-)

Expand all Fold all

[PATCH 0/9] Fix a slightly rework auto completion

Posted by Michal Privoznik 3 years, 2 months ago

These fixes were inspired by:

https://gitlab.com/libvirt/libvirt/-/issues/116

Michal Prívozník (9):
  vshCommandStringGetArg: Drop @sz
  vsh: Don't break word on backslash
  vshReadlineParse: Bring some variables into !state block
  vshReadlineParse: Use g_auto*()
  vshReadlineParse: Rename @buf to @line
  vshReadlineParse: Escape list of candidates earlier
  vsh: Rework how option to complete is found
  vsh: Allow double quotes imbalance for auto completion in
    vshCommandStringGetArg()
  tools: Set IFS for bash completion script

 tools/bash-completion/vsh |   2 +-
 tools/virsh.c             |   4 +-
 tools/virt-admin.c        |   4 +-
 tools/vsh.c               | 125 ++++++++++++++++++++++++--------------
 tools/vsh.h               |   5 +-
 5 files changed, 88 insertions(+), 52 deletions(-)

-- 
2.26.2

Re: [PATCH 0/9] Fix a slightly rework auto completion

Posted by Ján Tomko 3 years, 2 months ago

On a Tuesday in 2021, Michal Privoznik wrote:
>These fixes were inspired by:
>
>https://gitlab.com/libvirt/libvirt/-/issues/116
>
>Michal Prívozník (9):
>  vshCommandStringGetArg: Drop @sz
>  vsh: Don't break word on backslash
>  vshReadlineParse: Bring some variables into !state block
>  vshReadlineParse: Use g_auto*()
>  vshReadlineParse: Rename @buf to @line
>  vshReadlineParse: Escape list of candidates earlier
>  vsh: Rework how option to complete is found
>  vsh: Allow double quotes imbalance for auto completion in
>    vshCommandStringGetArg()
>  tools: Set IFS for bash completion script
>
> tools/bash-completion/vsh |   2 +-
> tools/virsh.c             |   4 +-
> tools/virt-admin.c        |   4 +-
> tools/vsh.c               | 125 ++++++++++++++++++++++++--------------
> tools/vsh.h               |   5 +-
> 5 files changed, 88 insertions(+), 52 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano