[PATCH 00/12] virStorageSource cleanups part 1

Peter Krempa posted 12 patches 3 years, 3 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1611590679.git.pkrempa@redhat.com
po/POTFILES.in                                |    1 +
src/libvirt_private.syms                      |    5 +-
src/qemu/qemu_block.c                         |    6 +-
src/qemu/qemu_driver.c                        |   19 +-
src/qemu/qemu_snapshot.c                      |   13 +-
src/security/virt-aa-helper.c                 |    4 +-
src/storage_file/meson.build                  |    1 +
src/storage_file/storage_source.c             | 1681 +++--------------
src/storage_file/storage_source.h             |    6 +-
.../storage_source_backingstore.c             | 1240 ++++++++++++
.../storage_source_backingstore.h             |   40 +
src/util/virstoragefile.c                     |   66 -
src/util/virstoragefile.h                     |    8 -
tests/virstoragetest.c                        |   66 +-
14 files changed, 1582 insertions(+), 1574 deletions(-)
create mode 100644 src/storage_file/storage_source_backingstore.c
create mode 100644 src/storage_file/storage_source_backingstore.h
[PATCH 00/12] virStorageSource cleanups part 1
Posted by Peter Krempa 3 years, 3 months ago
Peter Krempa (12):
  virStorageSourceGetBackingStoreStr: Move the function earlier
  virStorageSourceGetBackingStoreStr: Return relative paths only
  util: virstoragefile: Move virStorageIs[File|Relative] to
    storage_source
  storage_source: Move backing store parsers into new file
  virStorageSourceGetMetadata: Refactor cleanup
  virt-aa-helper: Use proper check for empty disk in 'get_files'
  virt-aa-helper: Don't probe image metadata for terminated chains
  virStorageSourceChainLookup: Don't break error message strings
  test: storage: Remove double testing in testStorageLookup
  virStorageSourceChainLookup: Handle names like 'vda[4]' internally
  tests: storage: Replace index testing in testStorageLookup
  util: Remove unused 'virStorageFileParseChainIndex'

 po/POTFILES.in                                |    1 +
 src/libvirt_private.syms                      |    5 +-
 src/qemu/qemu_block.c                         |    6 +-
 src/qemu/qemu_driver.c                        |   19 +-
 src/qemu/qemu_snapshot.c                      |   13 +-
 src/security/virt-aa-helper.c                 |    4 +-
 src/storage_file/meson.build                  |    1 +
 src/storage_file/storage_source.c             | 1681 +++--------------
 src/storage_file/storage_source.h             |    6 +-
 .../storage_source_backingstore.c             | 1240 ++++++++++++
 .../storage_source_backingstore.h             |   40 +
 src/util/virstoragefile.c                     |   66 -
 src/util/virstoragefile.h                     |    8 -
 tests/virstoragetest.c                        |   66 +-
 14 files changed, 1582 insertions(+), 1574 deletions(-)
 create mode 100644 src/storage_file/storage_source_backingstore.c
 create mode 100644 src/storage_file/storage_source_backingstore.h

-- 
2.29.2

Re: [PATCH 00/12] virStorageSource cleanups part 1
Posted by Pavel Hrdina 3 years, 3 months ago
On Mon, Jan 25, 2021 at 05:05:12PM +0100, Peter Krempa wrote:
> Peter Krempa (12):
>   virStorageSourceGetBackingStoreStr: Move the function earlier
>   virStorageSourceGetBackingStoreStr: Return relative paths only
>   util: virstoragefile: Move virStorageIs[File|Relative] to
>     storage_source
>   storage_source: Move backing store parsers into new file
>   virStorageSourceGetMetadata: Refactor cleanup
>   virt-aa-helper: Use proper check for empty disk in 'get_files'
>   virt-aa-helper: Don't probe image metadata for terminated chains
>   virStorageSourceChainLookup: Don't break error message strings
>   test: storage: Remove double testing in testStorageLookup
>   virStorageSourceChainLookup: Handle names like 'vda[4]' internally
>   tests: storage: Replace index testing in testStorageLookup
>   util: Remove unused 'virStorageFileParseChainIndex'
> 
>  po/POTFILES.in                                |    1 +
>  src/libvirt_private.syms                      |    5 +-
>  src/qemu/qemu_block.c                         |    6 +-
>  src/qemu/qemu_driver.c                        |   19 +-
>  src/qemu/qemu_snapshot.c                      |   13 +-
>  src/security/virt-aa-helper.c                 |    4 +-
>  src/storage_file/meson.build                  |    1 +
>  src/storage_file/storage_source.c             | 1681 +++--------------
>  src/storage_file/storage_source.h             |    6 +-
>  .../storage_source_backingstore.c             | 1240 ++++++++++++
>  .../storage_source_backingstore.h             |   40 +
>  src/util/virstoragefile.c                     |   66 -
>  src/util/virstoragefile.h                     |    8 -
>  tests/virstoragetest.c                        |   66 +-
>  14 files changed, 1582 insertions(+), 1574 deletions(-)
>  create mode 100644 src/storage_file/storage_source_backingstore.c
>  create mode 100644 src/storage_file/storage_source_backingstore.h

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>