[libvirt PATCH v3 0/3] Propose a simple mechanism on how to disable pipeline jobs

Erik Skultety posted 3 patches 3 years, 10 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1610637247.git.eskultet@redhat.com
.gitlab-ci.yml | 164 ++++++++++++++++++++++++++-----------------------
1 file changed, 86 insertions(+), 78 deletions(-)
[libvirt PATCH v3 0/3] Propose a simple mechanism on how to disable pipeline jobs
Posted by Erik Skultety 3 years, 10 months ago
>From time to time it happens that some of the distros for which we run our
pipelines break (or the images we pull break). Because we don't have dedicated
maintainers for the jobs/runners, we can only employ the best effort approach
wrt to making the pipeline green again when we're positive the problem doesn't
lie in libvirt.
For jobs that are broken for quite some time we should opt to disable them
unconditionally unless a volunteer dedicates the time to either fix it or the
matter gets fixed on its own in time (e.g. updated container images).

v1: https://www.redhat.com/archives/libvir-list/2021-January/msg00573.html
v2: https://www.redhat.com/archives/libvir-list/2021-January/msg00672.html

Since v2:
    - renamed all the template jobs according to the review comments
    - added 'rules' for container jobs as well
    - fixed the env variable naming inconsistency that somehow made it to the
      v1 patches

Erik Skultety (3):
  gitlab-ci.yml: Replace template anchors with extends
  gitlab-ci.yml: Convert only/except to the rules syntax
  gitlab-ci.yml: Add an explicit env variable to mark a job as broken

 .gitlab-ci.yml | 164 ++++++++++++++++++++++++++-----------------------
 1 file changed, 86 insertions(+), 78 deletions(-)

-- 
2.29.2


Re: [libvirt PATCH v3 0/3] Propose a simple mechanism on how to disable pipeline jobs
Posted by Andrea Bolognani 3 years, 10 months ago
On Thu, 2021-01-14 at 16:15 +0100, Erik Skultety wrote:
> > From time to time it happens that some of the distros for which we run our
> pipelines break (or the images we pull break). Because we don't have dedicated
> maintainers for the jobs/runners, we can only employ the best effort approach
> wrt to making the pipeline green again when we're positive the problem doesn't
> lie in libvirt.
> For jobs that are broken for quite some time we should opt to disable them
> unconditionally unless a volunteer dedicates the time to either fix it or the
> matter gets fixed on its own in time (e.g. updated container images).
> 
> v1: https://www.redhat.com/archives/libvir-list/2021-January/msg00573.html
> v2: https://www.redhat.com/archives/libvir-list/2021-January/msg00672.html
> 
> Since v2:
>     - renamed all the template jobs according to the review comments
>     - added 'rules' for container jobs as well
>     - fixed the env variable naming inconsistency that somehow made it to the
>       v1 patches
> 
> Erik Skultety (3):
>   gitlab-ci.yml: Replace template anchors with extends
>   gitlab-ci.yml: Convert only/except to the rules syntax
>   gitlab-ci.yml: Add an explicit env variable to mark a job as broken
> 
>  .gitlab-ci.yml | 164 ++++++++++++++++++++++++++-----------------------
>  1 file changed, 86 insertions(+), 78 deletions(-)

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization