[PATCH 0/7] secret: Relax usage 'name' regex

Peter Krempa posted 7 patches 2 weeks, 5 days ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1609952208.git.pkrempa@redhat.com
docs/schemas/basictypes.rng                   | 13 ++++++++
docs/schemas/domaincommon.rng                 | 33 +++++--------------
docs/schemas/secret.rng                       |  8 ++---
docs/schemas/storagecommon.rng                |  8 -----
docs/schemas/storagepool.rng                  |  4 +--
src/conf/secret_conf.c                        | 20 ++++-------
src/util/virsecret.c                          |  3 +-
.../disk-network-source-auth.args             |  8 ++++-
...isk-network-source-auth.x86_64-2.12.0.args |  9 +++++
...isk-network-source-auth.x86_64-latest.args | 29 +++++++++++-----
.../disk-network-source-auth.xml              | 12 +++++++
tests/qemuxml2argvtest.c                      |  3 +-
.../disk-network-source-auth.xml              | 13 ++++++++
tests/secretxml2xmlin/usage-ceph-space.xml    |  7 ++++
tests/secretxml2xmltest.c                     |  1 +
15 files changed, 107 insertions(+), 64 deletions(-)
create mode 100644 tests/secretxml2xmlin/usage-ceph-space.xml

[PATCH 0/7] secret: Relax usage 'name' regex

Posted by Peter Krempa 2 weeks, 5 days ago
Patches 1-6 are mostly cleanups noticed while looking at the schema.

See patch 7/7 for explanation.

Peter Krempa (7):
  virSecretDefParseUsage: Use g_autofree for type_str
  secretXMLParseNode: Clean up freeing of memory
  virSecretLookupParseSecret: Use g_steal_pointer
  schema: domaincommon: Remove pointless 'choice' from
    'inituser'/'initgroup'
  schema: Remove workaround for bug in libxml2 2.7.6
  schema: Add define for object names
  schema: secret: Relax requirements for usage name

 docs/schemas/basictypes.rng                   | 13 ++++++++
 docs/schemas/domaincommon.rng                 | 33 +++++--------------
 docs/schemas/secret.rng                       |  8 ++---
 docs/schemas/storagecommon.rng                |  8 -----
 docs/schemas/storagepool.rng                  |  4 +--
 src/conf/secret_conf.c                        | 20 ++++-------
 src/util/virsecret.c                          |  3 +-
 .../disk-network-source-auth.args             |  8 ++++-
 ...isk-network-source-auth.x86_64-2.12.0.args |  9 +++++
 ...isk-network-source-auth.x86_64-latest.args | 29 +++++++++++-----
 .../disk-network-source-auth.xml              | 12 +++++++
 tests/qemuxml2argvtest.c                      |  3 +-
 .../disk-network-source-auth.xml              | 13 ++++++++
 tests/secretxml2xmlin/usage-ceph-space.xml    |  7 ++++
 tests/secretxml2xmltest.c                     |  1 +
 15 files changed, 107 insertions(+), 64 deletions(-)
 create mode 100644 tests/secretxml2xmlin/usage-ceph-space.xml

-- 
2.29.2

Re: [PATCH 0/7] secret: Relax usage 'name' regex

Posted by Ján Tomko 2 weeks, 5 days ago
On a Wednesday in 2021, Peter Krempa wrote:
>Patches 1-6 are mostly cleanups noticed while looking at the schema.
>
>See patch 7/7 for explanation.
>
>Peter Krempa (7):
>  virSecretDefParseUsage: Use g_autofree for type_str
>  secretXMLParseNode: Clean up freeing of memory
>  virSecretLookupParseSecret: Use g_steal_pointer
>  schema: domaincommon: Remove pointless 'choice' from
>    'inituser'/'initgroup'
>  schema: Remove workaround for bug in libxml2 2.7.6
>  schema: Add define for object names
>  schema: secret: Relax requirements for usage name
>
> docs/schemas/basictypes.rng                   | 13 ++++++++
> docs/schemas/domaincommon.rng                 | 33 +++++--------------
> docs/schemas/secret.rng                       |  8 ++---
> docs/schemas/storagecommon.rng                |  8 -----
> docs/schemas/storagepool.rng                  |  4 +--
> src/conf/secret_conf.c                        | 20 ++++-------
> src/util/virsecret.c                          |  3 +-
> .../disk-network-source-auth.args             |  8 ++++-
> ...isk-network-source-auth.x86_64-2.12.0.args |  9 +++++
> ...isk-network-source-auth.x86_64-latest.args | 29 +++++++++++-----
> .../disk-network-source-auth.xml              | 12 +++++++
> tests/qemuxml2argvtest.c                      |  3 +-
> .../disk-network-source-auth.xml              | 13 ++++++++
> tests/secretxml2xmlin/usage-ceph-space.xml    |  7 ++++
> tests/secretxml2xmltest.c                     |  1 +
> 15 files changed, 107 insertions(+), 64 deletions(-)
> create mode 100644 tests/secretxml2xmlin/usage-ceph-space.xml
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano