On 1/6/21 3:03 PM, Peter Krempa wrote:
> This is a resend of the patches from:
>
> https://www.redhat.com/archives/libvir-list/2020-November/msg01625.html
>
> which can be justified without the rest of the series. This series
> cleans up some monitor code and few related bits to testing.
>
> The reset of the series will be posted once there's progress on the
> qapification of object-add in qemu.
>
> Peter Krempa (12):
> qemuMonitorJSONSetMigrationParams: Take double pointer for @params
> qemuMonitorSetMigrationCapabilities: Take double pointer for @caps
> qemuMonitorJSONSetMigrationCapabilities: Refactor cleanup
> testQemuMonitorJSONqemuMonitorJSONGetMigrationCapabilities: refactor
> cleanup
> qemuMonitorJSONAddObject: Take double pointer for @props
> qemuMonitorJSONMakeCommandInternal: Clear @arguments when stolen
> qemuMonitorAddObject: Fix semantics of @alias
> qemuMonitorAddObject: Refactor cleanup
> util: json: Replace virJSONValueObjectSteal by
> virJSONValueObjectRemoveKey
> tests: qemuxml2argv: Don't check whether -netdev was QAPIfied
> repeatedly
> qemuBuildChrChardevStr: Rename 'flags' to 'cdevflags'
> testCompareXMLToArgvValidateSchema: Populate autoNodeset
>
> src/qemu/qemu_command.c | 10 +++---
> src/qemu/qemu_migration_params.c | 22 ++++--------
> src/qemu/qemu_monitor.c | 45 +++++++++----------------
> src/qemu/qemu_monitor.h | 4 +--
> src/qemu/qemu_monitor_json.c | 57 ++++++++++++--------------------
> src/qemu/qemu_monitor_json.h | 6 ++--
> src/util/virjson.c | 29 +++-------------
> tests/qemumonitorjsontest.c | 26 +++++----------
> tests/qemuxml2argvtest.c | 18 +++++++---
> 9 files changed, 81 insertions(+), 136 deletions(-)
>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Michal