[PATCH 0/3] schemas: Allow <filesystem/> to have interleaved children

Michal Privoznik posted 3 patches 2 weeks, 5 days ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1609934351.git.mprivozn@redhat.com
docs/schemas/domaincommon.rng | 400 +++++++++++++++++-----------------
1 file changed, 202 insertions(+), 198 deletions(-)

[PATCH 0/3] schemas: Allow <filesystem/> to have interleaved children

Posted by Michal Privoznik 2 weeks, 5 days ago
Tested with the following change:

diff --git a/tests/qemuxml2argvdata/vhost-user-fs-fd-memory.xml b/tests/qemuxml2argvdata/vhost-user-fs-fd-memory.xml
index f6bb663e97..875e2316a0 100644
--- a/tests/qemuxml2argvdata/vhost-user-fs-fd-memory.xml
+++ b/tests/qemuxml2argvdata/vhost-user-fs-fd-memory.xml
@@ -27,13 +27,13 @@
     <controller type='usb' index='0' model='none'/>
     <controller type='pci' index='0' model='pci-root'/>
     <filesystem type='mount' accessmode='passthrough'>
-      <driver type='virtiofs' queue='1024'/>
+      <target dir='mount_tag'/>
+      <source dir='/path'/>
       <binary path='/usr/libexec/virtiofsd' xattr='on'>
         <cache mode='always'/>
         <lock posix='off' flock='off'/>
       </binary>
-      <source dir='/path'/>
-      <target dir='mount_tag'/>
+      <driver type='virtiofs' queue='1024'/>
       <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/>
     </filesystem>
     <input type='mouse' bus='ps2'/>


Michal Prívozník (3):
  schemas: Allow fsDriver to be interleaved
  schemas: Allow interleaving of fsBinary children
  schemas: Allow direct children of <filesystem/> to be interleaved

 docs/schemas/domaincommon.rng | 400 +++++++++++++++++-----------------
 1 file changed, 202 insertions(+), 198 deletions(-)

-- 
2.26.2

Re: [PATCH 0/3] schemas: Allow <filesystem/> to have interleaved children

Posted by Ján Tomko 2 weeks, 5 days ago
On a Wednesday in 2021, Michal Privoznik wrote:
>Tested with the following change:
>
>diff --git a/tests/qemuxml2argvdata/vhost-user-fs-fd-memory.xml b/tests/qemuxml2argvdata/vhost-user-fs-fd-memory.xml
>index f6bb663e97..875e2316a0 100644
>--- a/tests/qemuxml2argvdata/vhost-user-fs-fd-memory.xml
>+++ b/tests/qemuxml2argvdata/vhost-user-fs-fd-memory.xml
>@@ -27,13 +27,13 @@
>     <controller type='usb' index='0' model='none'/>
>     <controller type='pci' index='0' model='pci-root'/>
>     <filesystem type='mount' accessmode='passthrough'>
>-      <driver type='virtiofs' queue='1024'/>
>+      <target dir='mount_tag'/>
>+      <source dir='/path'/>
>       <binary path='/usr/libexec/virtiofsd' xattr='on'>
>         <cache mode='always'/>
>         <lock posix='off' flock='off'/>
>       </binary>
>-      <source dir='/path'/>
>-      <target dir='mount_tag'/>
>+      <driver type='virtiofs' queue='1024'/>
>       <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/>
>     </filesystem>
>     <input type='mouse' bus='ps2'/>
>
>
>Michal Prívozník (3):
>  schemas: Allow fsDriver to be interleaved
>  schemas: Allow interleaving of fsBinary children
>  schemas: Allow direct children of <filesystem/> to be interleaved
>
> docs/schemas/domaincommon.rng | 400 +++++++++++++++++-----------------
> 1 file changed, 202 insertions(+), 198 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano