[PATCH 0/7] qemu: Add workaround for apps polling virDomainGetBlockJobInfo with pre-blockdev qemu

Peter Krempa posted 7 patches 3 years, 5 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1607094319.git.pkrempa@redhat.com
src/libvirt-domain.c         | 23 +++++++++++++++------
src/qemu/qemu_driver.c       | 39 +++++++++++++++++++++++-------------
src/qemu/qemu_monitor.c      | 29 ---------------------------
src/qemu/qemu_monitor.h      |  7 ++-----
src/qemu/qemu_monitor_json.c |  8 ++------
src/qemu/qemu_process.c      |  4 ++--
6 files changed, 48 insertions(+), 62 deletions(-)
[PATCH 0/7] qemu: Add workaround for apps polling virDomainGetBlockJobInfo with pre-blockdev qemu
Posted by Peter Krempa 3 years, 5 months ago
This is a workaround for the issue that Nikolay tries to fix in:

https://www.redhat.com/archives/libvir-list/2020-November/msg00669.html

This one is a far more focused hack for apps which don't bother to
update to events for block job completion checking.

Peter Krempa (7):
  virDomainGetBlockJobInfo: Discourage polling for block job completion
    detection
  virDomainGetBlockJobInfo: Reword docs for fallback values
  qemuMonitorBlockJobInfo: Store 'ready' and 'ready_present' separately
  qemuBlockJobInfoTranslate: Use explicit comparison against 0
  qemuDomainGetBlockJobInfo: Use qemuMonitorGetAllBlockJobInfo
  qemu: monitor: Remove unused qemuMonitorGetBlockJobInfo
  qemuDomainGetBlockJobInfo: Work stats for unfinished pre-blockdev
    blockjob

 src/libvirt-domain.c         | 23 +++++++++++++++------
 src/qemu/qemu_driver.c       | 39 +++++++++++++++++++++++-------------
 src/qemu/qemu_monitor.c      | 29 ---------------------------
 src/qemu/qemu_monitor.h      |  7 ++-----
 src/qemu/qemu_monitor_json.c |  8 ++------
 src/qemu/qemu_process.c      |  4 ++--
 6 files changed, 48 insertions(+), 62 deletions(-)

-- 
2.28.0

Re: [PATCH 0/7] qemu: Add workaround for apps polling virDomainGetBlockJobInfo with pre-blockdev qemu
Posted by Michal Privoznik 3 years, 5 months ago
On 12/4/20 4:07 PM, Peter Krempa wrote:
> This is a workaround for the issue that Nikolay tries to fix in:
> 
> https://www.redhat.com/archives/libvir-list/2020-November/msg00669.html
> 
> This one is a far more focused hack for apps which don't bother to
> update to events for block job completion checking.
> 
> Peter Krempa (7):
>    virDomainGetBlockJobInfo: Discourage polling for block job completion
>      detection
>    virDomainGetBlockJobInfo: Reword docs for fallback values
>    qemuMonitorBlockJobInfo: Store 'ready' and 'ready_present' separately
>    qemuBlockJobInfoTranslate: Use explicit comparison against 0
>    qemuDomainGetBlockJobInfo: Use qemuMonitorGetAllBlockJobInfo
>    qemu: monitor: Remove unused qemuMonitorGetBlockJobInfo
>    qemuDomainGetBlockJobInfo: Work stats for unfinished pre-blockdev
>      blockjob
> 
>   src/libvirt-domain.c         | 23 +++++++++++++++------
>   src/qemu/qemu_driver.c       | 39 +++++++++++++++++++++++-------------
>   src/qemu/qemu_monitor.c      | 29 ---------------------------
>   src/qemu/qemu_monitor.h      |  7 ++-----
>   src/qemu/qemu_monitor_json.c |  8 ++------
>   src/qemu/qemu_process.c      |  4 ++--
>   6 files changed, 48 insertions(+), 62 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal

Re: [PATCH 0/7] qemu: Add workaround for apps polling virDomainGetBlockJobInfo with pre-blockdev qemu
Posted by Peter Krempa 3 years, 4 months ago
On Fri, Dec 04, 2020 at 18:26:46 +0100, Michal Privoznik wrote:
> On 12/4/20 4:07 PM, Peter Krempa wrote:
> > This is a workaround for the issue that Nikolay tries to fix in:
> > 
> > https://www.redhat.com/archives/libvir-list/2020-November/msg00669.html
> > 
> > This one is a far more focused hack for apps which don't bother to
> > update to events for block job completion checking.
> > 
> > Peter Krempa (7):
> >    virDomainGetBlockJobInfo: Discourage polling for block job completion
> >      detection
> >    virDomainGetBlockJobInfo: Reword docs for fallback values
> >    qemuMonitorBlockJobInfo: Store 'ready' and 'ready_present' separately
> >    qemuBlockJobInfoTranslate: Use explicit comparison against 0
> >    qemuDomainGetBlockJobInfo: Use qemuMonitorGetAllBlockJobInfo
> >    qemu: monitor: Remove unused qemuMonitorGetBlockJobInfo
> >    qemuDomainGetBlockJobInfo: Work stats for unfinished pre-blockdev
> >      blockjob
> > 
> >   src/libvirt-domain.c         | 23 +++++++++++++++------
> >   src/qemu/qemu_driver.c       | 39 +++++++++++++++++++++++-------------
> >   src/qemu/qemu_monitor.c      | 29 ---------------------------
> >   src/qemu/qemu_monitor.h      |  7 ++-----
> >   src/qemu/qemu_monitor_json.c |  8 ++------
> >   src/qemu/qemu_process.c      |  4 ++--
> >   6 files changed, 48 insertions(+), 62 deletions(-)
> > 
> 
> Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

You've accidentally pushed this series :) ... and didn't apply your R-bs
:D