[PATCH 00/11] virDomainCheckpointAlignDisks: Clean up similarly to virDomainSnapshotAlignDisks

Peter Krempa posted 11 patches 3 years, 5 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1606911231.git.pkrempa@redhat.com
src/conf/checkpoint_conf.c | 123 ++++++++++++++++---------------------
src/conf/checkpoint_conf.h |   1 -
src/conf/domain_conf.c     |   6 +-
src/conf/snapshot_conf.c   |   7 +--
4 files changed, 61 insertions(+), 76 deletions(-)
[PATCH 00/11] virDomainCheckpointAlignDisks: Clean up similarly to virDomainSnapshotAlignDisks
Posted by Peter Krempa 3 years, 5 months ago
I've refactored virDomainSnapshotAlignDisks and
virDomainCheckpointAlignDisks was heavily inspired by it. Clean it up
too.

Peter Krempa (11):
  virDomainCheckpointAlignDisks: Refactor cleanup
  virDomainCheckpointAlignDisks: Unbreak error message
  virDomainCheckpointAlignDisks: Use 'domdef' for domain definition
  virDomainCheckpointAlignDisks: rename 'def' to 'chkdef'
  virDomainCheckpointAlignDisks: Use 'chkdisk' instead of 'disk'
  virDomainCheckpointAlignDisks: Extract domain disk def pointer to
    'domdisk'
  virDomainCheckpointAlignDisks: refactor extension to all disks
  virDomainCheckpointDiskDef: Remove unused 'idx' field
  virDomainDiskByName: Remove ternary operator
  virDomainCheckpointAlignDisks: Use virDomainDiskByName
  virDomainSnapshotAlignDisks: Use virDomainDiskByName

 src/conf/checkpoint_conf.c | 123 ++++++++++++++++---------------------
 src/conf/checkpoint_conf.h |   1 -
 src/conf/domain_conf.c     |   6 +-
 src/conf/snapshot_conf.c   |   7 +--
 4 files changed, 61 insertions(+), 76 deletions(-)

-- 
2.28.0

Re: [PATCH 00/11] virDomainCheckpointAlignDisks: Clean up similarly to virDomainSnapshotAlignDisks
Posted by Ján Tomko 3 years, 5 months ago
On a Wednesday in 2020, Peter Krempa wrote:
>I've refactored virDomainSnapshotAlignDisks and
>virDomainCheckpointAlignDisks was heavily inspired by it. Clean it up
>too.
>
>Peter Krempa (11):
>  virDomainCheckpointAlignDisks: Refactor cleanup
>  virDomainCheckpointAlignDisks: Unbreak error message
>  virDomainCheckpointAlignDisks: Use 'domdef' for domain definition
>  virDomainCheckpointAlignDisks: rename 'def' to 'chkdef'
>  virDomainCheckpointAlignDisks: Use 'chkdisk' instead of 'disk'
>  virDomainCheckpointAlignDisks: Extract domain disk def pointer to
>    'domdisk'
>  virDomainCheckpointAlignDisks: refactor extension to all disks
>  virDomainCheckpointDiskDef: Remove unused 'idx' field
>  virDomainDiskByName: Remove ternary operator
>  virDomainCheckpointAlignDisks: Use virDomainDiskByName
>  virDomainSnapshotAlignDisks: Use virDomainDiskByName
>
> src/conf/checkpoint_conf.c | 123 ++++++++++++++++---------------------
> src/conf/checkpoint_conf.h |   1 -
> src/conf/domain_conf.c     |   6 +-
> src/conf/snapshot_conf.c   |   7 +--
> 4 files changed, 61 insertions(+), 76 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano