[PATCH 0/4] libvirt_recover_xattrs: Improve usability for libvirt development

Peter Krempa posted 4 patches 3 years, 5 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1606905624.git.pkrempa@redhat.com
tools/libvirt_recover_xattrs.sh | 64 ++++++++++++++++++++++-----------
1 file changed, 43 insertions(+), 21 deletions(-)
[PATCH 0/4] libvirt_recover_xattrs: Improve usability for libvirt development
Posted by Peter Krempa 3 years, 5 months ago
I run into scenarios where I forget to destroy a VM which has a new WIP
qemu capability. Starting a libvirtd which doesn't support it yet makes
the libvirt vanish, thus after manually killing it libvirtd doesn't
clear the xattrs, making it impossible to start the VM.

libvirt_recover_xattrs fixes this, but is unusable unless you want to
turn off all VMs.

Peter Krempa (4):
  libvirt_recover_xattrs: Avoid backticks for subshell
  libvirt_recover_xattrs: Use only the correct xattr prefix
  libvirt_recover_xattrs: Add unsafe operation mode
  libvirt_recover_xattrs: Allow fixing multiple PATHs

 tools/libvirt_recover_xattrs.sh | 64 ++++++++++++++++++++++-----------
 1 file changed, 43 insertions(+), 21 deletions(-)

-- 
2.28.0

Re: [PATCH 0/4] libvirt_recover_xattrs: Improve usability for libvirt development
Posted by Michal Privoznik 3 years, 5 months ago
On 12/2/20 11:43 AM, Peter Krempa wrote:
> I run into scenarios where I forget to destroy a VM which has a new WIP
> qemu capability. Starting a libvirtd which doesn't support it yet makes
> the libvirt vanish, thus after manually killing it libvirtd doesn't
> clear the xattrs, making it impossible to start the VM.
> 
> libvirt_recover_xattrs fixes this, but is unusable unless you want to
> turn off all VMs.
> 
> Peter Krempa (4):
>    libvirt_recover_xattrs: Avoid backticks for subshell
>    libvirt_recover_xattrs: Use only the correct xattr prefix
>    libvirt_recover_xattrs: Add unsafe operation mode
>    libvirt_recover_xattrs: Allow fixing multiple PATHs
> 
>   tools/libvirt_recover_xattrs.sh | 64 ++++++++++++++++++++++-----------
>   1 file changed, 43 insertions(+), 21 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal