[PATCH 0/2] Replace VIR_AUTOSTRINGLIST with GStrv

Michal Privoznik posted 2 patches 3 years, 4 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1606840945.git.mprivozn@redhat.com
src/conf/cpu_conf.c                    |  2 +-
src/conf/domain_conf.c                 |  2 +-
src/cpu/cpu_arm.c                      |  2 +-
src/libvirt_private.syms               |  1 -
src/libxl/xen_common.c                 | 10 +++----
src/libxl/xen_xl.c                     |  2 +-
src/lxc/lxc_process.c                  |  2 +-
src/qemu/qemu_capabilities.c           |  6 ++---
src/qemu/qemu_cgroup.c                 |  2 +-
src/qemu/qemu_conf.c                   | 10 +++----
src/qemu/qemu_firmware.c               |  4 +--
src/qemu/qemu_monitor_json.c           |  4 +--
src/qemu/qemu_namespace.c              | 28 ++++++++++----------
src/qemu/qemu_process.c                |  4 +--
src/qemu/qemu_qapi.c                   |  2 +-
src/qemu/qemu_vhost_user.c             |  2 +-
src/rpc/virnetsocket.c                 |  4 +--
src/storage/storage_backend_sheepdog.c |  4 +--
src/storage/storage_backend_zfs.c      | 12 ++++-----
src/util/vircgroup.c                   |  2 +-
src/util/vircommand.c                  |  2 +-
src/util/virdevmapper.c                |  6 ++---
src/util/virfile.c                     |  2 +-
src/util/virfirewall.c                 |  2 +-
src/util/virhook.c                     |  2 +-
src/util/virjson.c                     |  2 +-
src/util/virprocess.c                  |  2 +-
src/util/virstoragefile.c              | 10 +++----
src/util/virstring.c                   | 10 -------
src/util/virstring.h                   |  9 -------
src/util/virsystemd.c                  |  2 +-
src/vmx/vmx.c                          |  2 +-
tests/qemufirmwaretest.c               |  2 +-
tests/qemusecuritytest.c               |  2 +-
tests/qemuvhostusertest.c              |  2 +-
tests/qemuxml2argvtest.c               |  4 +--
tests/virfirewalltest.c                |  2 +-
tools/virsh-completer-domain.c         | 36 +++++++++++++-------------
tools/virsh-completer-host.c           |  6 ++---
tools/virsh-completer-interface.c      |  2 +-
tools/virsh-completer-network.c        |  8 +++---
tools/virsh-completer-nodedev.c        |  6 ++---
tools/virsh-completer-nwfilter.c       |  4 +--
tools/virsh-completer-pool.c           |  6 ++---
tools/virsh-completer-secret.c         |  4 +--
tools/virsh-completer-snapshot.c       |  2 +-
tools/virsh-completer-volume.c         |  2 +-
tools/virsh-completer.c                |  4 +--
tools/virsh-domain.c                   |  4 +--
49 files changed, 116 insertions(+), 136 deletions(-)
[PATCH 0/2] Replace VIR_AUTOSTRINGLIST with GStrv
Posted by Michal Privoznik 3 years, 4 months ago
It was only recently that I learned about g_auto(GStrv).
It's just like our VIR_AUTOSTRINGLIST.

Michal Prívozník (2):
  lib: Replace VIR_AUTOSTRINGLIST with GStrv
  virstring: Drop VIR_AUTOSTRINGLIST

 src/conf/cpu_conf.c                    |  2 +-
 src/conf/domain_conf.c                 |  2 +-
 src/cpu/cpu_arm.c                      |  2 +-
 src/libvirt_private.syms               |  1 -
 src/libxl/xen_common.c                 | 10 +++----
 src/libxl/xen_xl.c                     |  2 +-
 src/lxc/lxc_process.c                  |  2 +-
 src/qemu/qemu_capabilities.c           |  6 ++---
 src/qemu/qemu_cgroup.c                 |  2 +-
 src/qemu/qemu_conf.c                   | 10 +++----
 src/qemu/qemu_firmware.c               |  4 +--
 src/qemu/qemu_monitor_json.c           |  4 +--
 src/qemu/qemu_namespace.c              | 28 ++++++++++----------
 src/qemu/qemu_process.c                |  4 +--
 src/qemu/qemu_qapi.c                   |  2 +-
 src/qemu/qemu_vhost_user.c             |  2 +-
 src/rpc/virnetsocket.c                 |  4 +--
 src/storage/storage_backend_sheepdog.c |  4 +--
 src/storage/storage_backend_zfs.c      | 12 ++++-----
 src/util/vircgroup.c                   |  2 +-
 src/util/vircommand.c                  |  2 +-
 src/util/virdevmapper.c                |  6 ++---
 src/util/virfile.c                     |  2 +-
 src/util/virfirewall.c                 |  2 +-
 src/util/virhook.c                     |  2 +-
 src/util/virjson.c                     |  2 +-
 src/util/virprocess.c                  |  2 +-
 src/util/virstoragefile.c              | 10 +++----
 src/util/virstring.c                   | 10 -------
 src/util/virstring.h                   |  9 -------
 src/util/virsystemd.c                  |  2 +-
 src/vmx/vmx.c                          |  2 +-
 tests/qemufirmwaretest.c               |  2 +-
 tests/qemusecuritytest.c               |  2 +-
 tests/qemuvhostusertest.c              |  2 +-
 tests/qemuxml2argvtest.c               |  4 +--
 tests/virfirewalltest.c                |  2 +-
 tools/virsh-completer-domain.c         | 36 +++++++++++++-------------
 tools/virsh-completer-host.c           |  6 ++---
 tools/virsh-completer-interface.c      |  2 +-
 tools/virsh-completer-network.c        |  8 +++---
 tools/virsh-completer-nodedev.c        |  6 ++---
 tools/virsh-completer-nwfilter.c       |  4 +--
 tools/virsh-completer-pool.c           |  6 ++---
 tools/virsh-completer-secret.c         |  4 +--
 tools/virsh-completer-snapshot.c       |  2 +-
 tools/virsh-completer-volume.c         |  2 +-
 tools/virsh-completer.c                |  4 +--
 tools/virsh-domain.c                   |  4 +--
 49 files changed, 116 insertions(+), 136 deletions(-)

-- 
2.26.2

Re: [PATCH 0/2] Replace VIR_AUTOSTRINGLIST with GStrv
Posted by Ján Tomko 3 years, 4 months ago
On a Tuesday in 2020, Michal Privoznik wrote:
>It was only recently that I learned about g_auto(GStrv).
>It's just like our VIR_AUTOSTRINGLIST.
>
>Michal Prívozník (2):
>  lib: Replace VIR_AUTOSTRINGLIST with GStrv
>  virstring: Drop VIR_AUTOSTRINGLIST
>
> src/conf/cpu_conf.c                    |  2 +-
> src/conf/domain_conf.c                 |  2 +-

[...]

> tools/virsh-completer-snapshot.c       |  2 +-
> tools/virsh-completer-volume.c         |  2 +-
> tools/virsh-completer.c                |  4 +--
> tools/virsh-domain.c                   |  4 +--
> 49 files changed, 116 insertions(+), 136 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano