qemu: Remove caching in handler for query-command-line-options

[PATCH 0/3] qemu: Remove caching in handler for query-command-line-options

Peter Krempa posted 3 patches 3 years, 5 months ago

Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1606757081.git.pkrempa@redhat.com

src/qemu/qemu_capabilities.c |  34 +++++----
src/qemu/qemu_monitor.c      |  34 +--------
src/qemu/qemu_monitor.h      |   9 +--
src/qemu/qemu_monitor_json.c | 138 +++++++++--------------------------
src/qemu/qemu_monitor_json.h |   6 +-
tests/qemumonitorjsontest.c  | 117 -----------------------------
6 files changed, 58 insertions(+), 280 deletions(-)

Expand all Fold all

[PATCH 0/3] qemu: Remove caching in handler for query-command-line-options

Posted by Peter Krempa 3 years, 5 months ago

Shuffle around where we extract the data, so that we don't have to call
the monitor multiple times which necessitates caching.

Peter Krempa (3):
  qemu: monitor: Implement new handlers for 'query-command-line-options'
  virQEMUCapsProbeQMPCommandLine: Rewrite using
    qemuMonitorGetCommandLineOptions
  qemuMonitorGetCommandLineOptionParameters: remove the unused function
    and helpers

 src/qemu/qemu_capabilities.c |  34 +++++----
 src/qemu/qemu_monitor.c      |  34 +--------
 src/qemu/qemu_monitor.h      |   9 +--
 src/qemu/qemu_monitor_json.c | 138 +++++++++--------------------------
 src/qemu/qemu_monitor_json.h |   6 +-
 tests/qemumonitorjsontest.c  | 117 -----------------------------
 6 files changed, 58 insertions(+), 280 deletions(-)

-- 
2.28.0

Re: [PATCH 0/3] qemu: Remove caching in handler for query-command-line-options

Posted by Michal Privoznik 3 years, 5 months ago

On 11/30/20 6:25 PM, Peter Krempa wrote:
> Shuffle around where we extract the data, so that we don't have to call
> the monitor multiple times which necessitates caching.
> 
> Peter Krempa (3):
>    qemu: monitor: Implement new handlers for 'query-command-line-options'
>    virQEMUCapsProbeQMPCommandLine: Rewrite using
>      qemuMonitorGetCommandLineOptions
>    qemuMonitorGetCommandLineOptionParameters: remove the unused function
>      and helpers
> 
>   src/qemu/qemu_capabilities.c |  34 +++++----
>   src/qemu/qemu_monitor.c      |  34 +--------
>   src/qemu/qemu_monitor.h      |   9 +--
>   src/qemu/qemu_monitor_json.c | 138 +++++++++--------------------------
>   src/qemu/qemu_monitor_json.h |   6 +-
>   tests/qemumonitorjsontest.c  | 117 -----------------------------
>   6 files changed, 58 insertions(+), 280 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal