fix various issues

[libvirt PATCH 10/11] vbox_common: unlock vbox_driver_lock before return

Posted by Pavel Hrdina 5 years, 2 months ago

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
---
 src/vbox/vbox_common.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c
index 26168c3c5b..fc897735b0 100644
--- a/src/vbox/vbox_common.c
+++ b/src/vbox/vbox_common.c
@@ -245,6 +245,9 @@ vboxGetDriverConnection(void)
         if (!vbox_driver) {
             virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                            _("Failed to create vbox driver object."));
+
+            virMutexUnlock(&vbox_driver_lock);
+
             return NULL;
         }
     }
-- 
2.26.2

Re: [libvirt PATCH 10/11] vbox_common: unlock vbox_driver_lock before return

Posted by Peter Krempa 5 years, 2 months ago

On Mon, Nov 16, 2020 at 16:38:57 +0100, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
> ---
>  src/vbox/vbox_common.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c
> index 26168c3c5b..fc897735b0 100644
> --- a/src/vbox/vbox_common.c
> +++ b/src/vbox/vbox_common.c
> @@ -245,6 +245,9 @@ vboxGetDriverConnection(void)
>          if (!vbox_driver) {
>              virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
>                             _("Failed to create vbox driver object."));
> +
> +            virMutexUnlock(&vbox_driver_lock);
> +

Mention the function name somewshere.

Reviewed-by: Peter Krempa <pkrempa@redhat.com>