[PATCH 0/4] Couple of qemusecuritytest and security_util improvements

Michal Privoznik posted 4 patches 3 years, 5 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1604409134.git.mprivozn@redhat.com
src/libvirt_private.syms                      |   4 +
src/qemu/qemu_conf.c                          |   7 +-
src/security/security_util.c                  |  26 ++-
src/security/security_util.h                  |   3 +
tests/qemusecuritydata/virtual_domain_context |   2 +
tests/qemusecuritydata/virtual_image_context  |   2 +
tests/qemusecuritymock.c                      | 195 +++++++++++++++++-
tests/qemusecuritytest.c                      |  57 ++++-
8 files changed, 282 insertions(+), 14 deletions(-)
create mode 100644 tests/qemusecuritydata/virtual_domain_context
create mode 100644 tests/qemusecuritydata/virtual_image_context
[PATCH 0/4] Couple of qemusecuritytest and security_util improvements
Posted by Michal Privoznik 3 years, 5 months ago
These were sparked by a discussion on the list where the test is failing
on macOS.

Michal Prívozník (4):
  security_util: Don't error on macOS when getting/setting/moving XATTRs
  qemusecuritytest: Test SELinux too
  qemusecuritytest: Skip on non supported platforms
  qemu_conf: Don't even attempt to enable rememberOwner if unsupported

 src/libvirt_private.syms                      |   4 +
 src/qemu/qemu_conf.c                          |   7 +-
 src/security/security_util.c                  |  26 ++-
 src/security/security_util.h                  |   3 +
 tests/qemusecuritydata/virtual_domain_context |   2 +
 tests/qemusecuritydata/virtual_image_context  |   2 +
 tests/qemusecuritymock.c                      | 195 +++++++++++++++++-
 tests/qemusecuritytest.c                      |  57 ++++-
 8 files changed, 282 insertions(+), 14 deletions(-)
 create mode 100644 tests/qemusecuritydata/virtual_domain_context
 create mode 100644 tests/qemusecuritydata/virtual_image_context

-- 
2.26.2

Re: [PATCH 0/4] Couple of qemusecuritytest and security_util improvements
Posted by Roman Bolshakov 3 years, 5 months ago
On Tue, Nov 03, 2020 at 02:13:25PM +0100, Michal Privoznik wrote:
> These were sparked by a discussion on the list where the test is failing
> on macOS.
> 

Hi Michal,

Thanks for helping with the issue. I have applied the series and
qemusecuritytest doesn't fail anymore. So, for the series:

Tested-By: Roman Bolshakov <r.bolshakov@yadro.com>

Regards,
Roman

Re: [PATCH 0/4] Couple of qemusecuritytest and security_util improvements
Posted by Andrea Bolognani 3 years, 5 months ago
On Tue, 2020-11-03 at 14:13 +0100, Michal Privoznik wrote:
> These were sparked by a discussion on the list where the test is failing
> on macOS.
> 
> Michal Prívozník (4):
>   security_util: Don't error on macOS when getting/setting/moving XATTRs
>   qemusecuritytest: Test SELinux too
>   qemusecuritytest: Skip on non supported platforms
>   qemu_conf: Don't even attempt to enable rememberOwner if unsupported

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization