[libvirt PATCH 00/25] cgroup related fixes and cleanup

Pavel Hrdina posted 25 patches 3 years, 5 months ago
Test syntax-check failed
Failed in applying to current master (apply log)
src/qemu/qemu_cgroup.c      |   5 +-
src/qemu/qemu_dbus.c        |   9 +-
src/qemu/qemu_dbus.h        |   3 +-
src/qemu/qemu_extdevice.c   |   2 +-
src/qemu/qemu_slirp.c       |   4 -
src/util/vircgroup.c        | 337 ++++++++++++++++++++++--------------
src/util/vircgroupbackend.h |   5 +
src/util/vircgrouppriv.h    |   7 +-
src/util/vircgroupv1.c      |  57 +++---
src/util/vircgroupv2.c      |  61 ++++---
tests/vircgrouptest.c       |  33 ++--
11 files changed, 309 insertions(+), 214 deletions(-)
[libvirt PATCH 00/25] cgroup related fixes and cleanup
Posted by Pavel Hrdina 3 years, 5 months ago
Pavel Hrdina (25):
  qemu_cgroup: remove unused @empty variable
  qemu: remove dead code that setup cgroups for helper processes
  qemu_dbus: use emulator cgroup for dbus-daemon
  vircgroupv2: properly detect empty tasks
  vircgroupv2: properly detect placement of running VM
  vircgroupv2: detect controllers enabled in parent cgroup
  vircgroup: remove useless cgroup->path variable
  vircgroup: introduce virCgroupSetBackends helper
  vircgroup: introduce virCgroupCopyMounts helper
  vircgroup: introduce virCgroupCopyPlacement helper
  vircgroup: introduce virCgroupValidatePlacement helper
  vircgroup: introduce virCgroupDetectControllers helper
  vircgroup: extract virCgroupNewDetect from virCgroupNew
  vircgroup: introduce virCgroupNewParent
  vircgroup: drop @parent from virCgroupNew
  vircgroup: virCgroupNew is now always called with absolute path
  vircgroup: expand virCgroupDetect into virCgroupNew
  vircgroup: no need to use PID in virCgroupEnableMissingControllers
  vircgroup: drop @pid argument from virCgroupNew
  vircgroup: introduce virCgroupSetPlacement
  vircgroup: drop @create from virCgroupNewDomainPartition
  vircgroup: refactor virCgroupEnableMissingControllers
  vircgroup: move parentPath declaration
  vircgroup: refactor virCgroupNewPartition
  vircgroup: drop condition for absolute path from copyPlacement
    callbacks

 src/qemu/qemu_cgroup.c      |   5 +-
 src/qemu/qemu_dbus.c        |   9 +-
 src/qemu/qemu_dbus.h        |   3 +-
 src/qemu/qemu_extdevice.c   |   2 +-
 src/qemu/qemu_slirp.c       |   4 -
 src/util/vircgroup.c        | 337 ++++++++++++++++++++++--------------
 src/util/vircgroupbackend.h |   5 +
 src/util/vircgrouppriv.h    |   7 +-
 src/util/vircgroupv1.c      |  57 +++---
 src/util/vircgroupv2.c      |  61 ++++---
 tests/vircgrouptest.c       |  33 ++--
 11 files changed, 309 insertions(+), 214 deletions(-)

-- 
2.26.2

Re: [libvirt PATCH 00/25] cgroup related fixes and cleanup
Posted by Michal Privoznik 3 years, 5 months ago
On 11/3/20 1:41 PM, Pavel Hrdina wrote:
> Pavel Hrdina (25):
>    qemu_cgroup: remove unused @empty variable
>    qemu: remove dead code that setup cgroups for helper processes
>    qemu_dbus: use emulator cgroup for dbus-daemon
>    vircgroupv2: properly detect empty tasks
>    vircgroupv2: properly detect placement of running VM
>    vircgroupv2: detect controllers enabled in parent cgroup
>    vircgroup: remove useless cgroup->path variable
>    vircgroup: introduce virCgroupSetBackends helper
>    vircgroup: introduce virCgroupCopyMounts helper
>    vircgroup: introduce virCgroupCopyPlacement helper
>    vircgroup: introduce virCgroupValidatePlacement helper
>    vircgroup: introduce virCgroupDetectControllers helper
>    vircgroup: extract virCgroupNewDetect from virCgroupNew
>    vircgroup: introduce virCgroupNewParent
>    vircgroup: drop @parent from virCgroupNew
>    vircgroup: virCgroupNew is now always called with absolute path
>    vircgroup: expand virCgroupDetect into virCgroupNew
>    vircgroup: no need to use PID in virCgroupEnableMissingControllers
>    vircgroup: drop @pid argument from virCgroupNew
>    vircgroup: introduce virCgroupSetPlacement
>    vircgroup: drop @create from virCgroupNewDomainPartition
>    vircgroup: refactor virCgroupEnableMissingControllers
>    vircgroup: move parentPath declaration
>    vircgroup: refactor virCgroupNewPartition
>    vircgroup: drop condition for absolute path from copyPlacement
>      callbacks
> 
>   src/qemu/qemu_cgroup.c      |   5 +-
>   src/qemu/qemu_dbus.c        |   9 +-
>   src/qemu/qemu_dbus.h        |   3 +-
>   src/qemu/qemu_extdevice.c   |   2 +-
>   src/qemu/qemu_slirp.c       |   4 -
>   src/util/vircgroup.c        | 337 ++++++++++++++++++++++--------------
>   src/util/vircgroupbackend.h |   5 +
>   src/util/vircgrouppriv.h    |   7 +-
>   src/util/vircgroupv1.c      |  57 +++---
>   src/util/vircgroupv2.c      |  61 ++++---
>   tests/vircgrouptest.c       |  33 ++--
>   11 files changed, 309 insertions(+), 214 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal

Re: [libvirt PATCH 00/25] cgroup related fixes and cleanup
Posted by Neal Gompa 3 years, 5 months ago
On Tue, Nov 3, 2020 at 7:42 AM Pavel Hrdina <phrdina@redhat.com> wrote:
>
> Pavel Hrdina (25):
>   qemu_cgroup: remove unused @empty variable
>   qemu: remove dead code that setup cgroups for helper processes
>   qemu_dbus: use emulator cgroup for dbus-daemon
>   vircgroupv2: properly detect empty tasks
>   vircgroupv2: properly detect placement of running VM
>   vircgroupv2: detect controllers enabled in parent cgroup
>   vircgroup: remove useless cgroup->path variable
>   vircgroup: introduce virCgroupSetBackends helper
>   vircgroup: introduce virCgroupCopyMounts helper
>   vircgroup: introduce virCgroupCopyPlacement helper
>   vircgroup: introduce virCgroupValidatePlacement helper
>   vircgroup: introduce virCgroupDetectControllers helper
>   vircgroup: extract virCgroupNewDetect from virCgroupNew
>   vircgroup: introduce virCgroupNewParent
>   vircgroup: drop @parent from virCgroupNew
>   vircgroup: virCgroupNew is now always called with absolute path
>   vircgroup: expand virCgroupDetect into virCgroupNew
>   vircgroup: no need to use PID in virCgroupEnableMissingControllers
>   vircgroup: drop @pid argument from virCgroupNew
>   vircgroup: introduce virCgroupSetPlacement
>   vircgroup: drop @create from virCgroupNewDomainPartition
>   vircgroup: refactor virCgroupEnableMissingControllers
>   vircgroup: move parentPath declaration
>   vircgroup: refactor virCgroupNewPartition
>   vircgroup: drop condition for absolute path from copyPlacement
>     callbacks
>
>  src/qemu/qemu_cgroup.c      |   5 +-
>  src/qemu/qemu_dbus.c        |   9 +-
>  src/qemu/qemu_dbus.h        |   3 +-
>  src/qemu/qemu_extdevice.c   |   2 +-
>  src/qemu/qemu_slirp.c       |   4 -
>  src/util/vircgroup.c        | 337 ++++++++++++++++++++++--------------
>  src/util/vircgroupbackend.h |   5 +
>  src/util/vircgrouppriv.h    |   7 +-
>  src/util/vircgroupv1.c      |  57 +++---
>  src/util/vircgroupv2.c      |  61 ++++---
>  tests/vircgrouptest.c       |  33 ++--
>  11 files changed, 309 insertions(+), 214 deletions(-)
>
> --
> 2.26.2
>

Series LGTM.

Reviewed-by: Neal Gompa <ngompa13@gmail.com>


-- 
真実はいつも一つ!/ Always, there's only one truth!