[PATCH 3/3] qemu: capabilities: Re-enable detection of QEMU_CAPS_BLOCK_EXPORT_ADD

Peter Krempa posted 3 patches 5 years, 3 months ago
[PATCH 3/3] qemu: capabilities: Re-enable detection of QEMU_CAPS_BLOCK_EXPORT_ADD
Posted by Peter Krempa 5 years, 3 months ago
Now that qemu stabilized it's interface and we've switched to the new
design we can re-enable use of 'block-export-add'

This reverts commit TBD!!
---
 src/qemu/qemu_capabilities.c                     | 1 +
 tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml | 1 +
 2 files changed, 2 insertions(+)

diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 78be372a0c..a67fb785b5 100644
--- a/src/qemu/qemu_capabilities.c
+++ b/src/qemu/qemu_capabilities.c
@@ -1172,6 +1172,7 @@ struct virQEMUCapsStringFlags virQEMUCapsCommands[] = {
     { "block-dirty-bitmap-merge", QEMU_CAPS_BITMAP_MERGE },
     { "query-cpu-model-baseline", QEMU_CAPS_QUERY_CPU_MODEL_BASELINE },
     { "query-cpu-model-comparison", QEMU_CAPS_QUERY_CPU_MODEL_COMPARISON },
+    { "block-export-add", QEMU_CAPS_BLOCK_EXPORT_ADD },
 };

 struct virQEMUCapsStringFlags virQEMUCapsMigration[] = {
diff --git a/tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml
index 27d5d27175..d7eae9d535 100644
--- a/tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml
+++ b/tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml
@@ -246,6 +246,7 @@
   <flag name='blockdev-hostdev-scsi'/>
   <flag name='usb-host.hostdevice'/>
   <flag name='virtio-balloon.free-page-reporting'/>
+  <flag name='block-export-add'/>
   <flag name='netdev.vhost-vdpa'/>
   <version>5001050</version>
   <kvmVersion>0</kvmVersion>
-- 
2.26.2

Re: [PATCH 3/3] qemu: capabilities: Re-enable detection of QEMU_CAPS_BLOCK_EXPORT_ADD
Posted by Eric Blake 5 years, 3 months ago
On 10/26/20 8:19 AM, Peter Krempa wrote:
> Now that qemu stabilized it's interface and we've switched to the new
> design we can re-enable use of 'block-export-add'
> 
> This reverts commit TBD!!

Cute - but it works!  Obviously, as with 2/3, you'll add S-o-b when the
commit message is fixed.  Code-wise:

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org