virt-aa-helper: allow hard links for mounts

[PATCH 0/1] virt-aa-helper: allow hard links for mounts

Christian Schoenebeck posted 1 patch 3 years, 6 months ago

Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1603379410.git.qemu_oss@crudebyte.com

src/security/virt-aa-helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH 0/1] virt-aa-helper: allow hard links for mounts

Posted by Christian Schoenebeck 3 years, 6 months ago

I'm suggesting to add the AppArmor permission "l" on libvirt export pathes
to allow guests creating hard links, which is currently a problem for 9pfs
mounts.

Since the suggested patch would affect virtiofs as well, I would ask David
and Stefan for feedback. If necessary I would change the patch to exclude
virtiofs from this change.

Christian Schoenebeck (1):
  virt-aa-helper: allow hard links for mounts

 src/security/virt-aa-helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.20.1

Re: [PATCH 0/1] virt-aa-helper: allow hard links for mounts

Posted by Stefan Hajnoczi 3 years, 5 months ago

On Thu, Oct 22, 2020 at 05:10:10PM +0200, Christian Schoenebeck wrote:
> I'm suggesting to add the AppArmor permission "l" on libvirt export pathes
> to allow guests creating hard links, which is currently a problem for 9pfs
> mounts.
> 
> Since the suggested patch would affect virtiofs as well, I would ask David
> and Stefan for feedback. If necessary I would change the patch to exclude
> virtiofs from this change.

virtiofsd supports the link(2) operation and enabling it seems
reasonable to me. It is enabled in non-AppArmor configuration.

Stefan