[v1] Various cleanups

[libvirt PATCH 01/14] tools: virshCheckpointListCollect: remove unused names

Posted by Ján Tomko 5 years, 4 months ago

Introduced by:
commit 689beaa47c51fb49fafa992dd468116b8f6b0782
and unused since.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 tools/virsh-checkpoint.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/tools/virsh-checkpoint.c b/tools/virsh-checkpoint.c
index 33e70515ad..f3c4fe90ba 100644
--- a/tools/virsh-checkpoint.c
+++ b/tools/virsh-checkpoint.c
@@ -581,7 +581,6 @@ virshCheckpointListCollect(vshControl *ctl,
                            bool tree)
 {
     size_t i;
-    char **names = NULL;
     int count = -1;
     virDomainCheckpointPtr *chks;
     virshCheckpointListPtr checkpointlist = vshMalloc(ctl,
@@ -628,10 +627,6 @@ virshCheckpointListCollect(vshControl *ctl,
 
  cleanup:
     virshCheckpointListFree(checkpointlist);
-    if (names && count > 0)
-        for (i = 0; i < count; i++)
-            VIR_FREE(names[i]);
-    VIR_FREE(names);
     return ret;
 }
 
-- 
2.26.2

Re: [libvirt PATCH 01/14] tools: virshCheckpointListCollect: remove unused names

Posted by Martin Kletzander 5 years, 4 months ago

On Wed, Sep 23, 2020 at 08:14:50PM +0200, Ján Tomko wrote:
>Introduced by:
>commit 689beaa47c51fb49fafa992dd468116b8f6b0782
>and unused since.
>
>Signed-off-by: Ján Tomko <jtomko@redhat.com>
>---
> tools/virsh-checkpoint.c | 5 -----
> 1 file changed, 5 deletions(-)
>

Reviewed-by: Martin Kletzander <mkletzan@redhat.com>