[v1] Various cleanups

[libvirt PATCH 06/14] virsh: virshStreamSourceSkip: remove unused 'off'

Posted by Ján Tomko 5 years, 4 months ago

Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 tools/virsh-util.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tools/virsh-util.c b/tools/virsh-util.c
index b8b0f98066..af7ed55348 100644
--- a/tools/virsh-util.c
+++ b/tools/virsh-util.c
@@ -173,9 +173,8 @@ virshStreamSourceSkip(virStreamPtr st G_GNUC_UNUSED,
 {
     virshStreamCallbackDataPtr cbData = opaque;
     int fd = cbData->fd;
-    off_t cur;
 
-    if ((cur = lseek(fd, offset, SEEK_CUR)) == (off_t) -1)
+    if (lseek(fd, offset, SEEK_CUR) == (off_t) -1)
         return -1;
 
     return 0;
-- 
2.26.2

Re: [libvirt PATCH 06/14] virsh: virshStreamSourceSkip: remove unused 'off'

Posted by Martin Kletzander 5 years, 4 months ago

On Wed, Sep 23, 2020 at 08:14:55PM +0200, Ján Tomko wrote:
>Signed-off-by: Ján Tomko <jtomko@redhat.com>
>---
> tools/virsh-util.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>

Reviewed-by: Martin Kletzander <mkletzan@redhat.com>

>diff --git a/tools/virsh-util.c b/tools/virsh-util.c
>index b8b0f98066..af7ed55348 100644
>--- a/tools/virsh-util.c
>+++ b/tools/virsh-util.c
>@@ -173,9 +173,8 @@ virshStreamSourceSkip(virStreamPtr st G_GNUC_UNUSED,
> {
>     virshStreamCallbackDataPtr cbData = opaque;
>     int fd = cbData->fd;
>-    off_t cur;
>
>-    if ((cur = lseek(fd, offset, SEEK_CUR)) == (off_t) -1)
>+    if (lseek(fd, offset, SEEK_CUR) == (off_t) -1)
>         return -1;
>
>     return 0;
>-- 
>2.26.2
>