[PATCH 00/13] virStorageSourceNew failure handling and virDomainSnapshotAlignDisks refactors

Peter Krempa posted 13 patches 4 years, 2 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1600867955.git.pkrempa@redhat.com
src/conf/backup_conf.c                |   7 +-
src/conf/domain_conf.c                |  21 ++--
src/conf/snapshot_conf.c              | 160 +++++++++++---------------
src/conf/snapshot_conf.h              |   1 -
src/conf/storage_conf.c               |   8 +-
src/qemu/qemu_domain.c                |  21 ++--
src/qemu/qemu_driver.c                |  18 ++-
src/qemu/qemu_migration.c             |   7 +-
src/qemu/qemu_snapshot.c              |   7 +-
src/storage/storage_backend_gluster.c |   5 +-
src/storage/storage_backend_logical.c |   4 +-
src/storage/storage_util.c            |  10 +-
src/util/virstoragefile.c             |  32 ++----
tests/qemublocktest.c                 |  16 +--
tests/virstoragetest.c                |   5 +-
15 files changed, 121 insertions(+), 201 deletions(-)
[PATCH 00/13] virStorageSourceNew failure handling and virDomainSnapshotAlignDisks refactors
Posted by Peter Krempa 4 years, 2 months ago
A set of patches that prevent failures from virStorageSourceNew and
refactor virDomainSnapshotAlignDisks for better readability.

Peter Krempa (13):
  virStorageSourceNew: Abort on failure
  virStorageVolDefParseXML: Use g_steal_pointer
  qemuDomainBlockRebase: Replace ternary operator with if/else
  qemuSnapshotCreateInactiveExternal: Don't access 'idx' of snapshot
  virDomainSnapshotAlignDisks: Refactor cleanup
  virDomainSnapshotAlignDisks: Rename 'def' -> 'snapdef'
  virDomainSnapshotAlignDisks: Rename 'disk' -> 'snapdisk'
  virDomainSnapshotAlignDisks: Add 'domdef' local variable
  virDomainSnapshotAlignDisks: Extract domain disk definition to a local
    variable
  virDomainSnapshotAlignDisks: remove unnecessary 'tmp' variable
  virDomainSnapshotAlignDisks: clarify handing of snapshot location
  virDomainSnapshotAlignDisks: refactor extension to all disks
  virDomainSnapshotDiskDef: Remove 'idx' field

 src/conf/backup_conf.c                |   7 +-
 src/conf/domain_conf.c                |  21 ++--
 src/conf/snapshot_conf.c              | 160 +++++++++++---------------
 src/conf/snapshot_conf.h              |   1 -
 src/conf/storage_conf.c               |   8 +-
 src/qemu/qemu_domain.c                |  21 ++--
 src/qemu/qemu_driver.c                |  18 ++-
 src/qemu/qemu_migration.c             |   7 +-
 src/qemu/qemu_snapshot.c              |   7 +-
 src/storage/storage_backend_gluster.c |   5 +-
 src/storage/storage_backend_logical.c |   4 +-
 src/storage/storage_util.c            |  10 +-
 src/util/virstoragefile.c             |  32 ++----
 tests/qemublocktest.c                 |  16 +--
 tests/virstoragetest.c                |   5 +-
 15 files changed, 121 insertions(+), 201 deletions(-)

-- 
2.26.2