[libvirt PATCH 00/14] rewrite DBus to use GLib instead of libdbus

Pavel Hrdina posted 14 patches 3 years, 7 months ago
Test syntax-check failed
Failed in applying to current master (apply log)
libvirt.spec.in                      |    3 -
meson.build                          |   42 +-
meson_options.txt                    |    2 -
po/POTFILES.in                       |    3 +-
src/libvirt_private.syms             |   31 +-
src/libvirt_probes.d                 |    6 -
src/lxc/lxc_controller.c             |    6 +-
src/lxc/meson.build                  |    1 -
src/meson.build                      |    1 -
src/network/bridge_driver.c          |   81 +-
src/network/meson.build              |    2 -
src/node_device/meson.build          |    5 -
src/node_device/node_device_driver.c |   10 +-
src/node_device/node_device_driver.h |    5 -
src/node_device/node_device_hal.c    |  843 ------------
src/node_device/node_device_hal.h    |   22 -
src/nwfilter/meson.build             |    1 -
src/nwfilter/nwfilter_driver.c       |  127 +-
src/remote/remote_daemon.c           |   73 +-
src/remote/remote_daemon_dispatch.c  |    1 -
src/rpc/meson.build                  |    1 -
src/rpc/virnetdaemon.c               |  115 +-
src/util/meson.build                 |    3 +-
src/util/virdbus.c                   | 1871 --------------------------
src/util/virdbus.h                   |   76 --
src/util/virdbuspriv.h               |   56 -
src/util/virfirewalld.c              |  197 ++-
src/util/virgdbus.c                  |  425 ++++++
src/util/virgdbus.h                  |   79 ++
src/util/virpolkit.c                 |  115 +-
src/util/virsystemd.c                |  371 ++---
tests/meson.build                    |   29 +-
tests/networkxml2firewalltest.c      |   30 +-
tests/virdbusmock.c                  |   62 -
tests/virdbustest.c                  |  728 ----------
tests/virfirewalltest.c              |  154 +--
tests/virgdbusmock.c                 |   85 ++
tests/virmock.h                      |   10 +-
tests/virpolkittest.c                |  112 +-
tests/virsystemdtest.c               |  173 +--
40 files changed, 1330 insertions(+), 4627 deletions(-)
delete mode 100644 src/node_device/node_device_hal.c
delete mode 100644 src/node_device/node_device_hal.h
delete mode 100644 src/util/virdbus.c
delete mode 100644 src/util/virdbus.h
delete mode 100644 src/util/virdbuspriv.h
create mode 100644 src/util/virgdbus.c
create mode 100644 src/util/virgdbus.h
delete mode 100644 tests/virdbusmock.c
delete mode 100644 tests/virdbustest.c
create mode 100644 tests/virgdbusmock.c
[libvirt PATCH 00/14] rewrite DBus to use GLib instead of libdbus
Posted by Pavel Hrdina 3 years, 7 months ago
Pavel Hrdina (14):
  remove HAL node device driver
  tests: mock libdbus in networkxml2firewalltest
  util: introduce helpers for GLib DBus implementation
  tests/virmock: extend number of arguments
  tests: introduce virgdbusmock to mock GLib DBus functions
  src/util/virpolkit: convert to use GLib DBus
  src/util/virfirewalld: convert to use GLib DBus
  src/util/virsystemd: convert to use GLib DBus
  src/lxc/lxc_controller: convert to use GLib DBus
  src/network/bridge_driver: convert to use GLib DBus
  src/nwfilter/nwfilter_driver: convert to use GLib DBus
  src/remote/remote_daemon: convert to use GLib DBus
  src/rpc/virnetdaemon: convert to use GLib DBus
  drop libdbus from libvirt

 libvirt.spec.in                      |    3 -
 meson.build                          |   42 +-
 meson_options.txt                    |    2 -
 po/POTFILES.in                       |    3 +-
 src/libvirt_private.syms             |   31 +-
 src/libvirt_probes.d                 |    6 -
 src/lxc/lxc_controller.c             |    6 +-
 src/lxc/meson.build                  |    1 -
 src/meson.build                      |    1 -
 src/network/bridge_driver.c          |   81 +-
 src/network/meson.build              |    2 -
 src/node_device/meson.build          |    5 -
 src/node_device/node_device_driver.c |   10 +-
 src/node_device/node_device_driver.h |    5 -
 src/node_device/node_device_hal.c    |  843 ------------
 src/node_device/node_device_hal.h    |   22 -
 src/nwfilter/meson.build             |    1 -
 src/nwfilter/nwfilter_driver.c       |  127 +-
 src/remote/remote_daemon.c           |   73 +-
 src/remote/remote_daemon_dispatch.c  |    1 -
 src/rpc/meson.build                  |    1 -
 src/rpc/virnetdaemon.c               |  115 +-
 src/util/meson.build                 |    3 +-
 src/util/virdbus.c                   | 1871 --------------------------
 src/util/virdbus.h                   |   76 --
 src/util/virdbuspriv.h               |   56 -
 src/util/virfirewalld.c              |  197 ++-
 src/util/virgdbus.c                  |  425 ++++++
 src/util/virgdbus.h                  |   79 ++
 src/util/virpolkit.c                 |  115 +-
 src/util/virsystemd.c                |  371 ++---
 tests/meson.build                    |   29 +-
 tests/networkxml2firewalltest.c      |   30 +-
 tests/virdbusmock.c                  |   62 -
 tests/virdbustest.c                  |  728 ----------
 tests/virfirewalltest.c              |  154 +--
 tests/virgdbusmock.c                 |   85 ++
 tests/virmock.h                      |   10 +-
 tests/virpolkittest.c                |  112 +-
 tests/virsystemdtest.c               |  173 +--
 40 files changed, 1330 insertions(+), 4627 deletions(-)
 delete mode 100644 src/node_device/node_device_hal.c
 delete mode 100644 src/node_device/node_device_hal.h
 delete mode 100644 src/util/virdbus.c
 delete mode 100644 src/util/virdbus.h
 delete mode 100644 src/util/virdbuspriv.h
 create mode 100644 src/util/virgdbus.c
 create mode 100644 src/util/virgdbus.h
 delete mode 100644 tests/virdbusmock.c
 delete mode 100644 tests/virdbustest.c
 create mode 100644 tests/virgdbusmock.c

-- 
2.26.2

Re: [libvirt PATCH 00/14] rewrite DBus to use GLib instead of libdbus
Posted by Michal Privoznik 3 years, 7 months ago
On 9/17/20 10:29 AM, Pavel Hrdina wrote:
> Pavel Hrdina (14):
>    remove HAL node device driver
>    tests: mock libdbus in networkxml2firewalltest
>    util: introduce helpers for GLib DBus implementation
>    tests/virmock: extend number of arguments
>    tests: introduce virgdbusmock to mock GLib DBus functions
>    src/util/virpolkit: convert to use GLib DBus
>    src/util/virfirewalld: convert to use GLib DBus
>    src/util/virsystemd: convert to use GLib DBus
>    src/lxc/lxc_controller: convert to use GLib DBus
>    src/network/bridge_driver: convert to use GLib DBus
>    src/nwfilter/nwfilter_driver: convert to use GLib DBus
>    src/remote/remote_daemon: convert to use GLib DBus
>    src/rpc/virnetdaemon: convert to use GLib DBus
>    drop libdbus from libvirt
> 
>   libvirt.spec.in                      |    3 -
>   meson.build                          |   42 +-
>   meson_options.txt                    |    2 -
>   po/POTFILES.in                       |    3 +-
>   src/libvirt_private.syms             |   31 +-
>   src/libvirt_probes.d                 |    6 -
>   src/lxc/lxc_controller.c             |    6 +-
>   src/lxc/meson.build                  |    1 -
>   src/meson.build                      |    1 -
>   src/network/bridge_driver.c          |   81 +-
>   src/network/meson.build              |    2 -
>   src/node_device/meson.build          |    5 -
>   src/node_device/node_device_driver.c |   10 +-
>   src/node_device/node_device_driver.h |    5 -
>   src/node_device/node_device_hal.c    |  843 ------------
>   src/node_device/node_device_hal.h    |   22 -
>   src/nwfilter/meson.build             |    1 -
>   src/nwfilter/nwfilter_driver.c       |  127 +-
>   src/remote/remote_daemon.c           |   73 +-
>   src/remote/remote_daemon_dispatch.c  |    1 -
>   src/rpc/meson.build                  |    1 -
>   src/rpc/virnetdaemon.c               |  115 +-
>   src/util/meson.build                 |    3 +-
>   src/util/virdbus.c                   | 1871 --------------------------
>   src/util/virdbus.h                   |   76 --
>   src/util/virdbuspriv.h               |   56 -
>   src/util/virfirewalld.c              |  197 ++-
>   src/util/virgdbus.c                  |  425 ++++++
>   src/util/virgdbus.h                  |   79 ++
>   src/util/virpolkit.c                 |  115 +-
>   src/util/virsystemd.c                |  371 ++---
>   tests/meson.build                    |   29 +-
>   tests/networkxml2firewalltest.c      |   30 +-
>   tests/virdbusmock.c                  |   62 -
>   tests/virdbustest.c                  |  728 ----------
>   tests/virfirewalltest.c              |  154 +--
>   tests/virgdbusmock.c                 |   85 ++
>   tests/virmock.h                      |   10 +-
>   tests/virpolkittest.c                |  112 +-
>   tests/virsystemdtest.c               |  173 +--
>   40 files changed, 1330 insertions(+), 4627 deletions(-)
>   delete mode 100644 src/node_device/node_device_hal.c
>   delete mode 100644 src/node_device/node_device_hal.h
>   delete mode 100644 src/util/virdbus.c
>   delete mode 100644 src/util/virdbus.h
>   delete mode 100644 src/util/virdbuspriv.h
>   create mode 100644 src/util/virgdbus.c
>   create mode 100644 src/util/virgdbus.h
>   delete mode 100644 tests/virdbusmock.c
>   delete mode 100644 tests/virdbustest.c
>   create mode 100644 tests/virgdbusmock.c
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal

Re: [libvirt PATCH 00/14] rewrite DBus to use GLib instead of libdbus
Posted by Neal Gompa 3 years, 7 months ago
On Thu, Sep 17, 2020 at 4:31 AM Pavel Hrdina <phrdina@redhat.com> wrote:
>
> Pavel Hrdina (14):
>   remove HAL node device driver
>   tests: mock libdbus in networkxml2firewalltest
>   util: introduce helpers for GLib DBus implementation
>   tests/virmock: extend number of arguments
>   tests: introduce virgdbusmock to mock GLib DBus functions
>   src/util/virpolkit: convert to use GLib DBus
>   src/util/virfirewalld: convert to use GLib DBus
>   src/util/virsystemd: convert to use GLib DBus
>   src/lxc/lxc_controller: convert to use GLib DBus
>   src/network/bridge_driver: convert to use GLib DBus
>   src/nwfilter/nwfilter_driver: convert to use GLib DBus
>   src/remote/remote_daemon: convert to use GLib DBus
>   src/rpc/virnetdaemon: convert to use GLib DBus
>   drop libdbus from libvirt
>
>  libvirt.spec.in                      |    3 -
>  meson.build                          |   42 +-
>  meson_options.txt                    |    2 -
>  po/POTFILES.in                       |    3 +-
>  src/libvirt_private.syms             |   31 +-
>  src/libvirt_probes.d                 |    6 -
>  src/lxc/lxc_controller.c             |    6 +-
>  src/lxc/meson.build                  |    1 -
>  src/meson.build                      |    1 -
>  src/network/bridge_driver.c          |   81 +-
>  src/network/meson.build              |    2 -
>  src/node_device/meson.build          |    5 -
>  src/node_device/node_device_driver.c |   10 +-
>  src/node_device/node_device_driver.h |    5 -
>  src/node_device/node_device_hal.c    |  843 ------------
>  src/node_device/node_device_hal.h    |   22 -
>  src/nwfilter/meson.build             |    1 -
>  src/nwfilter/nwfilter_driver.c       |  127 +-
>  src/remote/remote_daemon.c           |   73 +-
>  src/remote/remote_daemon_dispatch.c  |    1 -
>  src/rpc/meson.build                  |    1 -
>  src/rpc/virnetdaemon.c               |  115 +-
>  src/util/meson.build                 |    3 +-
>  src/util/virdbus.c                   | 1871 --------------------------
>  src/util/virdbus.h                   |   76 --
>  src/util/virdbuspriv.h               |   56 -
>  src/util/virfirewalld.c              |  197 ++-
>  src/util/virgdbus.c                  |  425 ++++++
>  src/util/virgdbus.h                  |   79 ++
>  src/util/virpolkit.c                 |  115 +-
>  src/util/virsystemd.c                |  371 ++---
>  tests/meson.build                    |   29 +-
>  tests/networkxml2firewalltest.c      |   30 +-
>  tests/virdbusmock.c                  |   62 -
>  tests/virdbustest.c                  |  728 ----------
>  tests/virfirewalltest.c              |  154 +--
>  tests/virgdbusmock.c                 |   85 ++
>  tests/virmock.h                      |   10 +-
>  tests/virpolkittest.c                |  112 +-
>  tests/virsystemdtest.c               |  173 +--
>  40 files changed, 1330 insertions(+), 4627 deletions(-)
>  delete mode 100644 src/node_device/node_device_hal.c
>  delete mode 100644 src/node_device/node_device_hal.h
>  delete mode 100644 src/util/virdbus.c
>  delete mode 100644 src/util/virdbus.h
>  delete mode 100644 src/util/virdbuspriv.h
>  create mode 100644 src/util/virgdbus.c
>  create mode 100644 src/util/virgdbus.h
>  delete mode 100644 tests/virdbusmock.c
>  delete mode 100644 tests/virdbustest.c
>  create mode 100644 tests/virgdbusmock.c
>
> --
> 2.26.2
>

Reviewed-by: Neal Gompa <ngompa13@gmail.com>

-- 
真実はいつも一つ!/ Always, there's only one truth!