[PATCH 2/3] qemu: backup: Remove note that TLS should be implemented

Peter Krempa posted 3 patches 4 years, 2 months ago
[PATCH 2/3] qemu: backup: Remove note that TLS should be implemented
Posted by Peter Krempa 4 years, 2 months ago
Commit 423576679a5 implementing TLS forgot to remove the comment.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/qemu/qemu_backup.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/qemu/qemu_backup.c b/src/qemu/qemu_backup.c
index a402730d38..2f1a612803 100644
--- a/src/qemu/qemu_backup.c
+++ b/src/qemu/qemu_backup.c
@@ -805,7 +805,6 @@ qemuBackupBegin(virDomainObjPtr vm,
     if (qemuDomainObjEnterMonitorAsync(priv->driver, vm, QEMU_ASYNC_JOB_BACKUP) < 0)
         goto endjob;

-    /* TODO: TLS is a must-have for the modern age */
     if (pull) {
         if (tlsSecretProps)
             rc = qemuMonitorAddObject(priv->mon, &tlsSecretProps, &tlsSecretAlias);
-- 
2.26.2

Re: [PATCH 2/3] qemu: backup: Remove note that TLS should be implemented
Posted by Ján Tomko 4 years, 2 months ago
On a Monday in 2020, Peter Krempa wrote:
>Commit 423576679a5 implementing TLS forgot to remove the comment.
>
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> src/qemu/qemu_backup.c | 1 -
> 1 file changed, 1 deletion(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano