[PATCH v2 3/9] virsh: Reuse existing variable when parsing migrate --disks-port

Martin Kletzander posted 9 patches 5 years, 5 months ago
There is a newer version of this series
[PATCH v2 3/9] virsh: Reuse existing variable when parsing migrate --disks-port
Posted by Martin Kletzander 5 years, 5 months ago
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
---
 tools/virsh-domain.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 36581d2c31d2..8a4a0d172dc9 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -10708,7 +10708,6 @@ doMigrate(void *opaque)
     virDomainPtr dom = NULL;
     const char *desturi = NULL;
     const char *opt = NULL;
-    int disksPort = 0;
     unsigned int flags = 0;
     virshCtrlData *data = opaque;
     vshControl *ctl = data->ctl;
@@ -10756,11 +10755,11 @@ doMigrate(void *opaque)
                                 VIR_MIGRATE_PARAM_LISTEN_ADDRESS, opt) < 0)
         goto save_error;
 
-    if (vshCommandOptInt(ctl, cmd, "disks-port", &disksPort) < 0)
+    if (vshCommandOptInt(ctl, cmd, "disks-port", &intOpt) < 0)
         goto out;
-    if (disksPort &&
+    if (intOpt &&
         virTypedParamsAddInt(&params, &nparams, &maxparams,
-                             VIR_MIGRATE_PARAM_DISKS_PORT, disksPort) < 0)
+                             VIR_MIGRATE_PARAM_DISKS_PORT, intOpt) < 0)
         goto save_error;
 
     if (vshCommandOptStringReq(ctl, cmd, "dname", &opt) < 0)
-- 
2.28.0

Re: [PATCH v2 3/9] virsh: Reuse existing variable when parsing migrate --disks-port
Posted by Jiri Denemark 5 years, 5 months ago
On Tue, Sep 01, 2020 at 16:36:54 +0200, Martin Kletzander wrote:
> Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
> ---
>  tools/virsh-domain.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)

Reviewed-by: Jiri Denemark <jdenemar@redhat.com>