[v1] qemu: Allow migration over UNIX sockets

[libvirt PATCH 1/9] qemu: Use g_autofree in qemuMigrationSrcConnect

Posted by Martin Kletzander 5 years, 5 months ago

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
---
 src/qemu/qemu_migration.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index 142faa2cf997..60ddfde65d46 100644
--- a/src/qemu/qemu_migration.c
+++ b/src/qemu/qemu_migration.c
@@ -3369,7 +3369,7 @@ qemuMigrationSrcConnect(virQEMUDriverPtr driver,
 {
     virNetSocketPtr sock;
     const char *host;
-    char *port = NULL;
+    g_autofree char *port = NULL;
     int ret = -1;
 
     host = spec->dest.host.name;
@@ -3400,7 +3400,6 @@ qemuMigrationSrcConnect(virQEMUDriverPtr driver,
     ret = 0;
 
  cleanup:
-    VIR_FREE(port);
     if (ret < 0)
         VIR_FORCE_CLOSE(spec->dest.fd.qemu);
     return ret;
-- 
2.28.0

Re: [libvirt PATCH 1/9] qemu: Use g_autofree in qemuMigrationSrcConnect

Posted by Jiri Denemark 5 years, 5 months ago

On Tue, Aug 25, 2020 at 07:47:07 +0200, Martin Kletzander wrote:
> Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
> ---
>  src/qemu/qemu_migration.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
> index 142faa2cf997..60ddfde65d46 100644
> --- a/src/qemu/qemu_migration.c
> +++ b/src/qemu/qemu_migration.c
> @@ -3369,7 +3369,7 @@ qemuMigrationSrcConnect(virQEMUDriverPtr driver,
>  {
>      virNetSocketPtr sock;
>      const char *host;
> -    char *port = NULL;
> +    g_autofree char *port = NULL;
>      int ret = -1;
>  
>      host = spec->dest.host.name;
> @@ -3400,7 +3400,6 @@ qemuMigrationSrcConnect(virQEMUDriverPtr driver,
>      ret = 0;
>  
>   cleanup:
> -    VIR_FREE(port);
>      if (ret < 0)
>          VIR_FORCE_CLOSE(spec->dest.fd.qemu);
>      return ret;

Reviewed-by: Jiri Denemark <jdenemar@redhat.com>