[libvirt PATCH 0/8] Some cppcheck-inspired fixes

Ján Tomko posted 8 patches 3 years, 8 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1596406221.git.jtomko@redhat.com
src/hypervisor/virhostdev.c  |  2 +-
src/libxl/xen_xl.c           |  2 +-
src/qemu/qemu_hotplug.c      |  3 +--
src/qemu/qemu_process.c      |  6 +++---
src/rpc/virnetsocket.c       |  2 +-
src/util/vircommand.c        |  1 -
src/util/virhostmem.c        |  6 ++++--
src/util/virlease.c          |  2 +-
src/util/virresctrl.h        |  2 +-
src/util/virsocketaddr.h     |  8 ++++----
src/vbox/vbox_common.c       |  2 +-
src/vz/vz_sdk.c              |  8 ++++----
tools/virsh-completer-host.c |  4 ++--
tools/virsh-domain.c         |  7 +++----
tools/virt-admin.c           | 21 +++++++++------------
15 files changed, 36 insertions(+), 40 deletions(-)
[libvirt PATCH 0/8] Some cppcheck-inspired fixes
Posted by Ján Tomko 3 years, 8 months ago
At least I found a memleak.

Ján Tomko (8):
  vz: remove redundant NULL pointer check
  Remove redundant conditions
  util: command: do not return after abort
  util: virhostmem: do not use scanf without field limits
  util: sync variable names between header and C files
  virsh: completer: use signed variable for XPathNodeSet errors
  tools: remove unread variables
  tools: virt-admin: do not leak daemon-log settings

 src/hypervisor/virhostdev.c  |  2 +-
 src/libxl/xen_xl.c           |  2 +-
 src/qemu/qemu_hotplug.c      |  3 +--
 src/qemu/qemu_process.c      |  6 +++---
 src/rpc/virnetsocket.c       |  2 +-
 src/util/vircommand.c        |  1 -
 src/util/virhostmem.c        |  6 ++++--
 src/util/virlease.c          |  2 +-
 src/util/virresctrl.h        |  2 +-
 src/util/virsocketaddr.h     |  8 ++++----
 src/vbox/vbox_common.c       |  2 +-
 src/vz/vz_sdk.c              |  8 ++++----
 tools/virsh-completer-host.c |  4 ++--
 tools/virsh-domain.c         |  7 +++----
 tools/virt-admin.c           | 21 +++++++++------------
 15 files changed, 36 insertions(+), 40 deletions(-)

-- 
2.26.2

Re: [libvirt PATCH 0/8] Some cppcheck-inspired fixes
Posted by Martin Kletzander 3 years, 8 months ago
On Mon, Aug 03, 2020 at 12:11:23AM +0200, Ján Tomko wrote:
>At least I found a memleak.
>
>Ján Tomko (8):
>  vz: remove redundant NULL pointer check
>  Remove redundant conditions
>  util: command: do not return after abort
>  util: virhostmem: do not use scanf without field limits
>  util: sync variable names between header and C files
>  virsh: completer: use signed variable for XPathNodeSet errors
>  tools: remove unread variables
>  tools: virt-admin: do not leak daemon-log settings
>

Reviewed-by: Martin Kletzander <mkletzan@redhat.com>

> src/hypervisor/virhostdev.c  |  2 +-
> src/libxl/xen_xl.c           |  2 +-
> src/qemu/qemu_hotplug.c      |  3 +--
> src/qemu/qemu_process.c      |  6 +++---
> src/rpc/virnetsocket.c       |  2 +-
> src/util/vircommand.c        |  1 -
> src/util/virhostmem.c        |  6 ++++--
> src/util/virlease.c          |  2 +-
> src/util/virresctrl.h        |  2 +-
> src/util/virsocketaddr.h     |  8 ++++----
> src/vbox/vbox_common.c       |  2 +-
> src/vz/vz_sdk.c              |  8 ++++----
> tools/virsh-completer-host.c |  4 ++--
> tools/virsh-domain.c         |  7 +++----
> tools/virt-admin.c           | 21 +++++++++------------
> 15 files changed, 36 insertions(+), 40 deletions(-)
>
>-- 
>2.26.2
>