[libvirt PATCH 0/9] Remove some unused macros

Ján Tomko posted 9 patches 2 weeks ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1595937055.git.jtomko@redhat.com
src/locking/lock_driver_sanlock.c     | 2 --
src/storage/storage_backend_logical.c | 2 --
src/storage/storage_backend_scsi.c    | 1 -
src/test/test_driver.c                | 2 --
src/util/virnetdev.c                  | 1 -
src/util/virnetdevip.c                | 5 -----
src/util/virnetdevvportprofile.c      | 4 ----
tools/virsh-network.c                 | 4 ----
tools/virt-admin.c                    | 3 ---
9 files changed, 24 deletions(-)

[libvirt PATCH 0/9] Remove some unused macros

Posted by Ján Tomko 2 weeks ago
I built with -Wunused-macros again after five years [0]
the good news is we don't really have that many -
most of them are VIR_FROM_THIS or macros we have included
for completeness.

https://gitlab.com/jano.tomko/libvirt/-/pipelines/171383854

[0] a0482396d7e0b164e71b2bdd881d9db5c6521303

Ján Tomko (9):
  locking: sanlock: drop unused LOCKSPACE_SLEEP
  storage: logical: drop unused PV_BLANK_SECTOR_SIZE
  storage: scsi: remove unused LINUX_SYSFS_SCSI_HOST_POSTFIX
  test: remove unused NUM_CELLS
  util: remove unused VIR_MCAST_ADDR_LEN
  virsh: remove unused FILTER macro
  virt-admin: remove unused VIRT_ADMIN_TIME_BUFLEN
  util: vportprofile: remove unused constants
  util: netdevip: remove unused VIR_NETDEV_FAMILY

 src/locking/lock_driver_sanlock.c     | 2 --
 src/storage/storage_backend_logical.c | 2 --
 src/storage/storage_backend_scsi.c    | 1 -
 src/test/test_driver.c                | 2 --
 src/util/virnetdev.c                  | 1 -
 src/util/virnetdevip.c                | 5 -----
 src/util/virnetdevvportprofile.c      | 4 ----
 tools/virsh-network.c                 | 4 ----
 tools/virt-admin.c                    | 3 ---
 9 files changed, 24 deletions(-)

-- 
2.26.2

Re: [libvirt PATCH 0/9] Remove some unused macros

Posted by Jonathon Jongsma 2 weeks ago
Reviewed-by: Jonathon Jongsma <jjongsma@redhat.com>


On Tue, 2020-07-28 at 13:54 +0200, Ján Tomko wrote:
> I built with -Wunused-macros again after five years [0]
> the good news is we don't really have that many -
> most of them are VIR_FROM_THIS or macros we have included
> for completeness.
> 
> https://gitlab.com/jano.tomko/libvirt/-/pipelines/171383854
> 
> [0] a0482396d7e0b164e71b2bdd881d9db5c6521303
> 
> Ján Tomko (9):
>   locking: sanlock: drop unused LOCKSPACE_SLEEP
>   storage: logical: drop unused PV_BLANK_SECTOR_SIZE
>   storage: scsi: remove unused LINUX_SYSFS_SCSI_HOST_POSTFIX
>   test: remove unused NUM_CELLS
>   util: remove unused VIR_MCAST_ADDR_LEN
>   virsh: remove unused FILTER macro
>   virt-admin: remove unused VIRT_ADMIN_TIME_BUFLEN
>   util: vportprofile: remove unused constants
>   util: netdevip: remove unused VIR_NETDEV_FAMILY
> 
>  src/locking/lock_driver_sanlock.c     | 2 --
>  src/storage/storage_backend_logical.c | 2 --
>  src/storage/storage_backend_scsi.c    | 1 -
>  src/test/test_driver.c                | 2 --
>  src/util/virnetdev.c                  | 1 -
>  src/util/virnetdevip.c                | 5 -----
>  src/util/virnetdevvportprofile.c      | 4 ----
>  tools/virsh-network.c                 | 4 ----
>  tools/virt-admin.c                    | 3 ---
>  9 files changed, 24 deletions(-)
>