Building without driver_module is not supported anymore so drop the
option before switching to meson as we will not introduce it there.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
---
 configure.ac              |  1 -
 m4/virt-driver-modules.m4 | 17 +----------------
 2 files changed, 1 insertion(+), 17 deletions(-)

diff --git a/configure.ac b/configure.ac
index 0ab9bf9721d..97dbfe9ec2b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -796,7 +796,6 @@ LIBVIRT_WIN_CHECK_WINDRES
 
 
 dnl Driver-Modules library support
-LIBVIRT_ARG_DRIVER_MODULES
 LIBVIRT_CHECK_DRIVER_MODULES
 
 
diff --git a/m4/virt-driver-modules.m4 b/m4/virt-driver-modules.m4
index 54b75e09739..f7902283884 100644
--- a/m4/virt-driver-modules.m4
+++ b/m4/virt-driver-modules.m4
@@ -17,25 +17,10 @@ dnl License along with this library.  If not, see
 dnl <http://www.gnu.org/licenses/>.
 dnl
 
-AC_DEFUN([LIBVIRT_ARG_DRIVER_MODULES], [
-  LIBVIRT_ARG_WITH([DRIVER_MODULES], [build drivers as loadable modules],
-                   [yes])
-])
-
 AC_DEFUN([LIBVIRT_CHECK_DRIVER_MODULES], [
   AC_REQUIRE([LIBVIRT_CHECK_DLOPEN])
 
-  if test "$with_libvirtd" = "no" ; then
-    with_driver_modules=no
-  else
-    if test "$with_driver_modules" = "no"; then
-      AC_MSG_ERROR([Building without driver modules is not supported anymore])
-    fi
-
-    if test "$with_driver_modules" = "check"; then
-      with_driver_modules=yes
-    fi
-  fi
+  with_driver_modules=$with_libvirtd
 
   DRIVER_MODULES_CFLAGS=
   if test "$with_driver_modules" = "yes"; then
-- 
2.26.2

On a Thursday in 2020, Pavel Hrdina wrote:
>Building without driver_module is not supported anymore so drop the
>option before switching to meson as we will not introduce it there.
>
>Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
>---
> configure.ac              |  1 -
> m4/virt-driver-modules.m4 | 17 +----------------
> 2 files changed, 1 insertion(+), 17 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

This can be merged independently, the option is safely ignored.

Jano

On Thu, Jul 16, 2020 at 02:55:47PM +0200, Ján Tomko wrote:
> On a Thursday in 2020, Pavel Hrdina wrote:
> > Building without driver_module is not supported anymore so drop the
> > option before switching to meson as we will not introduce it there.
> > 
> > Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
> > ---
> > configure.ac              |  1 -
> > m4/virt-driver-modules.m4 | 17 +----------------
> > 2 files changed, 1 insertion(+), 17 deletions(-)
> > 
> 
> Reviewed-by: Ján Tomko <jtomko@redhat.com>
> 
> This can be merged independently, the option is safely ignored.

Thanks, some of the cleanup patches can be pushed separately but they
may break someone scripts so I would like to push them together with
meson where we will definitely break scripts and more.

I know that we have no promise to not break build tools but it's nice
to avoid it if possible.

Pavel

On a Thursday in 2020, Pavel Hrdina wrote:
>On Thu, Jul 16, 2020 at 02:55:47PM +0200, Ján Tomko wrote:
>> On a Thursday in 2020, Pavel Hrdina wrote:
>> > Building without driver_module is not supported anymore so drop the
>> > option before switching to meson as we will not introduce it there.
>> >
>> > Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
>> > ---
>> > configure.ac              |  1 -
>> > m4/virt-driver-modules.m4 | 17 +----------------
>> > 2 files changed, 1 insertion(+), 17 deletions(-)
>> >
>>
>> Reviewed-by: Ján Tomko <jtomko@redhat.com>
>>
>> This can be merged independently, the option is safely ignored.
>
>Thanks, some of the cleanup patches can be pushed separately but they
>may break someone scripts so I would like to push them together with
>meson where we will definitely break scripts and more.
>

This one won't break anything though.

Jano

>I know that we have no promise to not break build tools but it's nice
>to avoid it if possible.
>
>Pavel