Having limit set to 100 is in most cases perfect but sometimes there can
be a larger series that will have more than 100 patches and it will make
the check-dco job fail.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
---
 .gitlab-ci.yml      | 2 +-
 ci/cirrus/build.yml | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 702198ec8e4..c997dc6df25 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -1,5 +1,5 @@
 variables:
-  GIT_DEPTH: 100
+  GIT_DEPTH: 1000
 
 stages:
   - sanity_checks
diff --git a/ci/cirrus/build.yml b/ci/cirrus/build.yml
index 893e13d7241..49e90b6d67b 100644
--- a/ci/cirrus/build.yml
+++ b/ci/cirrus/build.yml
@@ -14,7 +14,7 @@ build_task:
   install_script:
     - @INSTALL_COMMAND@ @PKGS@
   clone_script:
-    - git clone --depth 100 "$CI_REPOSITORY_URL" .
+    - git clone --depth 1000 "$CI_REPOSITORY_URL" .
     - git fetch origin "$CI_COMMIT_REF_NAME"
     - git reset --hard "$CI_COMMIT_SHA"
   build_script:
-- 
2.26.2

On a Thursday in 2020, Pavel Hrdina wrote:
>Having limit set to 100 is in most cases perfect but sometimes there can
>be a larger series that will have more than 100 patches and it will make
>the check-dco job fail.
>
>Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
>---
> .gitlab-ci.yml      | 2 +-
> ci/cirrus/build.yml | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
>index 702198ec8e4..c997dc6df25 100644
>--- a/.gitlab-ci.yml
>+++ b/.gitlab-ci.yml
>@@ -1,5 +1,5 @@
> variables:
>-  GIT_DEPTH: 100
>+  GIT_DEPTH: 1000
>
> stages:
>   - sanity_checks
>diff --git a/ci/cirrus/build.yml b/ci/cirrus/build.yml
>index 893e13d7241..49e90b6d67b 100644
>--- a/ci/cirrus/build.yml
>+++ b/ci/cirrus/build.yml
>@@ -14,7 +14,7 @@ build_task:
>   install_script:
>     - @INSTALL_COMMAND@ @PKGS@
>   clone_script:
>-    - git clone --depth 100 "$CI_REPOSITORY_URL" .
>+    - git clone --depth 1000 "$CI_REPOSITORY_URL" .

Does cirrus run the dco-check too or is this just for consistency?

>     - git fetch origin "$CI_COMMIT_REF_NAME"
>     - git reset --hard "$CI_COMMIT_SHA"
>   build_script:

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano

On Wed, Jul 22, 2020 at 10:21:43 +0200, Ján Tomko wrote:
> On a Thursday in 2020, Pavel Hrdina wrote:
> > Having limit set to 100 is in most cases perfect but sometimes there can
> > be a larger series that will have more than 100 patches and it will make
> > the check-dco job fail.
> > 
> > Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
> > ---
> > .gitlab-ci.yml      | 2 +-
> > ci/cirrus/build.yml | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> > index 702198ec8e4..c997dc6df25 100644
> > --- a/.gitlab-ci.yml
> > +++ b/.gitlab-ci.yml
> > @@ -1,5 +1,5 @@
> > variables:
> > -  GIT_DEPTH: 100
> > +  GIT_DEPTH: 1000
> > 
> > stages:
> >   - sanity_checks
> > diff --git a/ci/cirrus/build.yml b/ci/cirrus/build.yml
> > index 893e13d7241..49e90b6d67b 100644
> > --- a/ci/cirrus/build.yml
> > +++ b/ci/cirrus/build.yml
> > @@ -14,7 +14,7 @@ build_task:
> >   install_script:
> >     - @INSTALL_COMMAND@ @PKGS@
> >   clone_script:
> > -    - git clone --depth 100 "$CI_REPOSITORY_URL" .
> > +    - git clone --depth 1000 "$CI_REPOSITORY_URL" .
> 
> Does cirrus run the dco-check too or is this just for consistency?
> 
> >     - git fetch origin "$CI_COMMIT_REF_NAME"
> >     - git reset --hard "$CI_COMMIT_SHA"
> >   build_script:
> 
> Reviewed-by: Ján Tomko <jtomko@redhat.com>

Do we really want to merge this in the end?

On Wed, Jul 22, 2020 at 10:35:43AM +0200, Peter Krempa wrote:
> On Wed, Jul 22, 2020 at 10:21:43 +0200, Ján Tomko wrote:
> > On a Thursday in 2020, Pavel Hrdina wrote:
> > > Having limit set to 100 is in most cases perfect but sometimes there can
> > > be a larger series that will have more than 100 patches and it will make
> > > the check-dco job fail.
> > > 
> > > Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
> > > ---
> > > .gitlab-ci.yml      | 2 +-
> > > ci/cirrus/build.yml | 2 +-
> > > 2 files changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> > > index 702198ec8e4..c997dc6df25 100644
> > > --- a/.gitlab-ci.yml
> > > +++ b/.gitlab-ci.yml
> > > @@ -1,5 +1,5 @@
> > > variables:
> > > -  GIT_DEPTH: 100
> > > +  GIT_DEPTH: 1000
> > > 
> > > stages:
> > >   - sanity_checks
> > > diff --git a/ci/cirrus/build.yml b/ci/cirrus/build.yml
> > > index 893e13d7241..49e90b6d67b 100644
> > > --- a/ci/cirrus/build.yml
> > > +++ b/ci/cirrus/build.yml
> > > @@ -14,7 +14,7 @@ build_task:
> > >   install_script:
> > >     - @INSTALL_COMMAND@ @PKGS@
> > >   clone_script:
> > > -    - git clone --depth 100 "$CI_REPOSITORY_URL" .
> > > +    - git clone --depth 1000 "$CI_REPOSITORY_URL" .
> > 
> > Does cirrus run the dco-check too or is this just for consistency?
> > 
> > >     - git fetch origin "$CI_COMMIT_REF_NAME"
> > >     - git reset --hard "$CI_COMMIT_SHA"
> > >   build_script:
> > 
> > Reviewed-by: Ján Tomko <jtomko@redhat.com>
> 
> Do we really want to merge this in the end?

We don't have to merge this patch as we don't run it in post-merge
pipeline. However, if we ever move to merge request workflow we I think
we will eventually need to modify the depth size for DCO check.

I'll fix this patch to change the git depth only for DCO check job as
Dan suggested.

Thanks

Pavel

On a Wednesday in 2020, Pavel Hrdina wrote:
>On Wed, Jul 22, 2020 at 10:35:43AM +0200, Peter Krempa wrote:
>> On Wed, Jul 22, 2020 at 10:21:43 +0200, Ján Tomko wrote:
>> > On a Thursday in 2020, Pavel Hrdina wrote:
>> > > Having limit set to 100 is in most cases perfect but sometimes there can
>> > > be a larger series that will have more than 100 patches and it will make
>> > > the check-dco job fail.
>> > >
>> > > Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
>> > > ---
>> > > .gitlab-ci.yml      | 2 +-
>> > > ci/cirrus/build.yml | 2 +-
>> > > 2 files changed, 2 insertions(+), 2 deletions(-)
>> > >
>> > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
>> > > index 702198ec8e4..c997dc6df25 100644
>> > > --- a/.gitlab-ci.yml
>> > > +++ b/.gitlab-ci.yml
>> > > @@ -1,5 +1,5 @@
>> > > variables:
>> > > -  GIT_DEPTH: 100
>> > > +  GIT_DEPTH: 1000
>> > >
>> > > stages:
>> > >   - sanity_checks
>> > > diff --git a/ci/cirrus/build.yml b/ci/cirrus/build.yml
>> > > index 893e13d7241..49e90b6d67b 100644
>> > > --- a/ci/cirrus/build.yml
>> > > +++ b/ci/cirrus/build.yml
>> > > @@ -14,7 +14,7 @@ build_task:
>> > >   install_script:
>> > >     - @INSTALL_COMMAND@ @PKGS@
>> > >   clone_script:
>> > > -    - git clone --depth 100 "$CI_REPOSITORY_URL" .
>> > > +    - git clone --depth 1000 "$CI_REPOSITORY_URL" .
>> >
>> > Does cirrus run the dco-check too or is this just for consistency?
>> >
>> > >     - git fetch origin "$CI_COMMIT_REF_NAME"
>> > >     - git reset --hard "$CI_COMMIT_SHA"
>> > >   build_script:
>> >
>> > Reviewed-by: Ján Tomko <jtomko@redhat.com>
>>
>> Do we really want to merge this in the end?
>
>We don't have to merge this patch as we don't run it in post-merge
>pipeline. However, if we ever move to merge request workflow we I think
>we will eventually need to modify the depth size for DCO check.
>

Given all the downsides of the merge request workflow, I doubt that will
ever happen.

Jano

>I'll fix this patch to change the git depth only for DCO check job as
>Dan suggested.
>
>Thanks
>
>Pavel

On Wed, 2020-07-22 at 10:21 +0200, Ján Tomko wrote:
> > +++ b/ci/cirrus/build.yml
> > @@ -14,7 +14,7 @@ build_task:
> >   install_script:
> >     - @INSTALL_COMMAND@ @PKGS@
> >   clone_script:
> > -    - git clone --depth 100 "$CI_REPOSITORY_URL" .
> > +    - git clone --depth 1000 "$CI_REPOSITORY_URL" .
> 
> Does cirrus run the dco-check too or is this just for consistency?

It does not, so I think we should drop this hunk in order not to
introduce unnecessary delays for Cirrus CI jobs.

-- 
Andrea Bolognani / Red Hat / Virtualization

On Thu, Jul 16, 2020 at 11:53:57AM +0200, Pavel Hrdina wrote:
> Having limit set to 100 is in most cases perfect but sometimes there can
> be a larger series that will have more than 100 patches and it will make
> the check-dco job fail.
> 
> Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
> ---
>  .gitlab-ci.yml      | 2 +-
>  ci/cirrus/build.yml | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 702198ec8e4..c997dc6df25 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -1,5 +1,5 @@
>  variables:
> -  GIT_DEPTH: 100
> +  GIT_DEPTH: 1000

If its only for the DCO job, then just override the GIT_DEPTH
variable only in the DCO job definition, leaving all the
others at 100 for speed.

>  
>  stages:
>    - sanity_checks
> diff --git a/ci/cirrus/build.yml b/ci/cirrus/build.yml
> index 893e13d7241..49e90b6d67b 100644
> --- a/ci/cirrus/build.yml
> +++ b/ci/cirrus/build.yml
> @@ -14,7 +14,7 @@ build_task:
>    install_script:
>      - @INSTALL_COMMAND@ @PKGS@
>    clone_script:
> -    - git clone --depth 100 "$CI_REPOSITORY_URL" .
> +    - git clone --depth 1000 "$CI_REPOSITORY_URL" .

Seems redundant per the subject goal

>      - git fetch origin "$CI_COMMIT_REF_NAME"
>      - git reset --hard "$CI_COMMIT_SHA"
>    build_script:

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|