Fix device names reported by 'write_threshold' event and add support for monitoring 'mirror'

[PATCH 10/10] virDomainSetBlockThreshold: Mention that the event can be registered for <mirror>

Posted by Peter Krempa 5 years, 6 months ago

The infrastructure supports setting the threshold also for the <mirror>.
Mention it in the docs.

https://bugzilla.redhat.com/show_bug.cgi?id=1807741

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/libvirt-domain.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
index 6c5ff5b0db..a4e73d5480 100644
--- a/src/libvirt-domain.c
+++ b/src/libvirt-domain.c
@@ -12381,6 +12381,9 @@ int virDomainGetGuestInfo(virDomainPtr domain,
  * live VM XML for 'backingStore' or 'source' elements of a disk. If index is
  * given the threshold is set for the corresponding image.
  *
+ * Note that the threshold event can be registered also for destinations of a
+ * 'virDomainBlockCopy' destination by using the 'index' of the 'mirror' source.
+ *
  * Hypervisors report the last written sector of an image in the bulk stats API
  * (virConnectGetAllDomainStats/virDomainListGetStats) as
  * "block.<num>.allocation" in the VIR_DOMAIN_STATS_BLOCK group. The current
-- 
2.26.2

Re: [PATCH 10/10] virDomainSetBlockThreshold: Mention that the event can be registered for <mirror>

Posted by Eric Blake 5 years, 6 months ago

On 7/15/20 8:10 AM, Peter Krempa wrote:
> The infrastructure supports setting the threshold also for the <mirror>.
> Mention it in the docs.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1807741
> 
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> ---
>   src/libvirt-domain.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
> index 6c5ff5b0db..a4e73d5480 100644
> --- a/src/libvirt-domain.c
> +++ b/src/libvirt-domain.c
> @@ -12381,6 +12381,9 @@ int virDomainGetGuestInfo(virDomainPtr domain,
>    * live VM XML for 'backingStore' or 'source' elements of a disk. If index is
>    * given the threshold is set for the corresponding image.
>    *
> + * Note that the threshold event can be registered also for destinations of a
> + * 'virDomainBlockCopy' destination by using the 'index' of the 'mirror' source.
> + *
>    * Hypervisors report the last written sector of an image in the bulk stats API

Reviewed-by: Eric Blake <eblake@redhat.com>

>    * (virConnectGetAllDomainStats/virDomainListGetStats) as
>    * "block.<num>.allocation" in the VIR_DOMAIN_STATS_BLOCK group. The current
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org