[PATCH 02/10] qemuDomainDiskBackingStoreGetName: Remove unused argument

Peter Krempa posted 10 patches 5 years, 6 months ago
[PATCH 02/10] qemuDomainDiskBackingStoreGetName: Remove unused argument
Posted by Peter Krempa 5 years, 6 months ago
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/qemu/qemu_domain.c  | 1 -
 src/qemu/qemu_domain.h  | 1 -
 src/qemu/qemu_process.c | 2 +-
 3 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 4a2daffc0a..3d136a6b8a 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -11515,7 +11515,6 @@ qemuDomainDiskLookupByNodename(virDomainDefPtr def,
  */
 char *
 qemuDomainDiskBackingStoreGetName(virDomainDiskDefPtr disk,
-                                  virStorageSourcePtr src G_GNUC_UNUSED,
                                   unsigned int idx)
 {
     char *ret = NULL;
diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h
index e524fd0002..6944b37ff7 100644
--- a/src/qemu/qemu_domain.h
+++ b/src/qemu/qemu_domain.h
@@ -963,7 +963,6 @@ virDomainDiskDefPtr qemuDomainDiskLookupByNodename(virDomainDefPtr def,
                                                    unsigned int *idx);

 char *qemuDomainDiskBackingStoreGetName(virDomainDiskDefPtr disk,
-                                        virStorageSourcePtr src,
                                         unsigned int idx);

 virStorageSourcePtr qemuDomainGetStorageSourceByDevstr(const char *devstr,
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 70fc24b993..2ee778c606 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -1514,7 +1514,7 @@ qemuProcessHandleBlockThreshold(qemuMonitorPtr mon G_GNUC_UNUSED,
         if (virStorageSourceIsLocalStorage(src))
             path = src->path;

-        if ((dev = qemuDomainDiskBackingStoreGetName(disk, src, idx)))
+        if ((dev = qemuDomainDiskBackingStoreGetName(disk, idx)))
             event = virDomainEventBlockThresholdNewFromObj(vm, dev, path,
                                                            threshold, excess);
     }
-- 
2.26.2

Re: [PATCH 02/10] qemuDomainDiskBackingStoreGetName: Remove unused argument
Posted by Eric Blake 5 years, 6 months ago
On 7/15/20 8:10 AM, Peter Krempa wrote:
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> ---
>   src/qemu/qemu_domain.c  | 1 -
>   src/qemu/qemu_domain.h  | 1 -
>   src/qemu/qemu_process.c | 2 +-
>   3 files changed, 1 insertion(+), 3 deletions(-)
> 
Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org