[v2] Use the default capabilities cache lookup rather than an arch based lookup

[libvirt PATCH v2 0/2] Use the default capabilities cache lookup rather than an arch based lookup

Erik Skultety posted 2 patches 3 years, 9 months ago

Diff against v1
Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1594198169.git.eskultet@redhat.com

src/qemu/qemu_capabilities.c | 63 ------------------------------------
src/qemu/qemu_capabilities.h |  2 --
src/qemu/qemu_driver.c       |  6 ++--
3 files changed, 4 insertions(+), 67 deletions(-)

Expand all Fold all

[libvirt PATCH v2 0/2] Use the default capabilities cache lookup rather than an arch based lookup

Posted by Erik Skultety 3 years, 9 months ago

https://bugzilla.redhat.com/show_bug.cgi?id=1852311

Since v1:
- dropped virQEMUCapsCacheLookupByArch since after patch 1 there was no further
  usage
- dropped virQEMUCapsCompareArch since virQEMUCapsCacheLookupByArch was the only
  caller

pipeline: https://gitlab.com/eskultety/libvirt/-/pipelines/164239584

Erik Skultety (2):
  qemu: Use virQEMUCapsCacheLookupDefault instead of lookup by arch
  qemu: capabilities: Drop the virQEMUCapsCacheLookupByArch function

 src/qemu/qemu_capabilities.c | 63 ------------------------------------
 src/qemu/qemu_capabilities.h |  2 --
 src/qemu/qemu_driver.c       |  6 ++--
 3 files changed, 4 insertions(+), 67 deletions(-)

-- 
2.26.2

Re: [libvirt PATCH v2 0/2] Use the default capabilities cache lookup rather than an arch based lookup

Posted by Daniel P. Berrangé 3 years, 9 months ago

On Wed, Jul 08, 2020 at 10:49:29AM +0200, Erik Skultety wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1852311
> 
> Since v1:
> - dropped virQEMUCapsCacheLookupByArch since after patch 1 there was no further
>   usage
> - dropped virQEMUCapsCompareArch since virQEMUCapsCacheLookupByArch was the only
>   caller
> 
> pipeline: https://gitlab.com/eskultety/libvirt/-/pipelines/164239584
> 
> Erik Skultety (2):
>   qemu: Use virQEMUCapsCacheLookupDefault instead of lookup by arch
>   qemu: capabilities: Drop the virQEMUCapsCacheLookupByArch function
> 
>  src/qemu/qemu_capabilities.c | 63 ------------------------------------
>  src/qemu/qemu_capabilities.h |  2 --
>  src/qemu/qemu_driver.c       |  6 ++--
>  3 files changed, 4 insertions(+), 67 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|