[PATCH 0/7] qemu: Stop chowning domain restore file

Michal Privoznik posted 7 patches 3 years, 9 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1593620041.git.mprivozn@redhat.com
src/libvirt_private.syms         |  2 ++
src/qemu/qemu_driver.c           |  2 --
src/qemu/qemu_process.c          | 12 +++++++
src/qemu/qemu_security.c         | 17 +++-------
src/qemu/qemu_security.h         | 13 ++++++--
src/security/security_apparmor.c |  8 ++---
src/security/security_dac.c      |  2 +-
src/security/security_driver.h   | 11 ++++++-
src/security/security_manager.c  | 38 ++++++++++++++++++++--
src/security/security_manager.h  |  8 ++++-
src/security/security_nop.c      |  2 +-
src/security/security_selinux.c  | 37 ++++++++++++++++++++-
src/security/security_stack.c    | 55 ++++++++++++++++++++++++++++++--
13 files changed, 177 insertions(+), 30 deletions(-)
[PATCH 0/7] qemu: Stop chowning domain restore file
Posted by Michal Privoznik 3 years, 9 months ago
See 4/7 for detailed explanation.

Michal Prívozník (7):
  security: Reintroduce virSecurityManager{Set,Restore}SavedStateLabel
  qemu_security: Implement
    virSecurityManager{Set,Restore}SavedStateLabel
  security_selinux: Implement
    virSecurityManager{Set,Restore}SavedStateLabel
  qemu: Use qemuSecuritySetSavedStateLabel() to label restore path
  Revert "qemuSecurityDomainRestorePathLabel: Introduce @ignoreNS
    argument"
  secdrivers: Rename @stdin_path argument of
    virSecurityDomainSetAllLabel()
  qemu_security: Complete renaming of virSecurityManagerSetAllLabel()
    argument

 src/libvirt_private.syms         |  2 ++
 src/qemu/qemu_driver.c           |  2 --
 src/qemu/qemu_process.c          | 12 +++++++
 src/qemu/qemu_security.c         | 17 +++-------
 src/qemu/qemu_security.h         | 13 ++++++--
 src/security/security_apparmor.c |  8 ++---
 src/security/security_dac.c      |  2 +-
 src/security/security_driver.h   | 11 ++++++-
 src/security/security_manager.c  | 38 ++++++++++++++++++++--
 src/security/security_manager.h  |  8 ++++-
 src/security/security_nop.c      |  2 +-
 src/security/security_selinux.c  | 37 ++++++++++++++++++++-
 src/security/security_stack.c    | 55 ++++++++++++++++++++++++++++++--
 13 files changed, 177 insertions(+), 30 deletions(-)

-- 
2.26.2

Re: [PATCH 0/7] qemu: Stop chowning domain restore file
Posted by Erik Skultety 3 years, 9 months ago
On Wed, Jul 01, 2020 at 06:15:00PM +0200, Michal Privoznik wrote:
> See 4/7 for detailed explanation.
>
> Michal Prívozník (7):
>   security: Reintroduce virSecurityManager{Set,Restore}SavedStateLabel
>   qemu_security: Implement
>     virSecurityManager{Set,Restore}SavedStateLabel
>   security_selinux: Implement
>     virSecurityManager{Set,Restore}SavedStateLabel
>   qemu: Use qemuSecuritySetSavedStateLabel() to label restore path
>   Revert "qemuSecurityDomainRestorePathLabel: Introduce @ignoreNS
>     argument"
>   secdrivers: Rename @stdin_path argument of
>     virSecurityDomainSetAllLabel()
>   qemu_security: Complete renaming of virSecurityManagerSetAllLabel()
>     argument

I gave it a try, compared it to both 6.5.0 and to the much older 4.6.0 as per
the bugzilla in 4/7 and it worked.

Reviewed-by: Erik Skultety <eskultet@redhat.com>