[PATCH 00/12] qemuxml2*test: Improve testing of SCSI hostdevs

Peter Krempa posted 12 patches 2 weeks ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1592840388.git.pkrempa@redhat.com
...sk-hostdev-scsi-virtio-iscsi-auth-AES.args | 49 ------------
...isk-hostdev-scsi-virtio-iscsi-auth-AES.xml | 43 -----------
.../hostdev-scsi-lsi-iscsi-auth.args          | 37 ----------
.../hostdev-scsi-lsi-iscsi-auth.xml           | 48 ------------
.../hostdev-scsi-lsi-iscsi.args               | 37 ----------
.../hostdev-scsi-lsi-iscsi.xml                | 42 -----------
tests/qemuxml2argvdata/hostdev-scsi-lsi.args  | 33 ---------
.../hostdev-scsi-lsi.x86_64-2.8.0.args        | 51 +++++++++++++
.../hostdev-scsi-lsi.x86_64-4.1.0.args        | 64 ++++++++++++++++
.../hostdev-scsi-lsi.x86_64-latest.args       | 68 +++++++++++++++++
tests/qemuxml2argvdata/hostdev-scsi-lsi.xml   | 38 ++++++++++
.../hostdev-scsi-readonly.args                | 34 ---------
.../hostdev-scsi-readonly.xml                 | 38 ----------
.../hostdev-scsi-virtio-iscsi-auth.xml        | 48 ------------
.../hostdev-scsi-virtio-iscsi.args            | 39 ----------
.../hostdev-scsi-virtio-iscsi.xml             | 42 -----------
.../hostdev-scsi-virtio-scsi.args             | 34 ---------
...ostdev-scsi-virtio-scsi.x86_64-2.8.0.args} | 40 +++++++---
...hostdev-scsi-virtio-scsi.x86_64-4.1.0.args | 70 ++++++++++++++++++
...ostdev-scsi-virtio-scsi.x86_64-latest.args | 74 +++++++++++++++++++
.../hostdev-scsi-virtio-scsi.xml              | 38 ++++++++++
tests/qemuxml2argvtest.c                      | 36 ++-------
.../hostdev-scsi-lsi-iscsi-auth.xml           | 57 --------------
.../hostdev-scsi-lsi-iscsi.xml                | 51 -------------
tests/qemuxml2xmloutdata/hostdev-scsi-lsi.xml | 38 ++++++++++
.../hostdev-scsi-readonly.xml                 | 47 ------------
.../hostdev-scsi-virtio-iscsi-auth.xml        | 57 --------------
.../hostdev-scsi-virtio-iscsi.xml             | 51 -------------
.../hostdev-scsi-virtio-scsi.xml              | 38 ++++++++++
tests/qemuxml2xmltest.c                       | 16 ----
30 files changed, 515 insertions(+), 843 deletions(-)
delete mode 100644 tests/qemuxml2argvdata/disk-hostdev-scsi-virtio-iscsi-auth-AES.args
delete mode 100644 tests/qemuxml2argvdata/disk-hostdev-scsi-virtio-iscsi-auth-AES.xml
delete mode 100644 tests/qemuxml2argvdata/hostdev-scsi-lsi-iscsi-auth.args
delete mode 100644 tests/qemuxml2argvdata/hostdev-scsi-lsi-iscsi-auth.xml
delete mode 100644 tests/qemuxml2argvdata/hostdev-scsi-lsi-iscsi.args
delete mode 100644 tests/qemuxml2argvdata/hostdev-scsi-lsi-iscsi.xml
delete mode 100644 tests/qemuxml2argvdata/hostdev-scsi-lsi.args
create mode 100644 tests/qemuxml2argvdata/hostdev-scsi-lsi.x86_64-2.8.0.args
create mode 100644 tests/qemuxml2argvdata/hostdev-scsi-lsi.x86_64-4.1.0.args
create mode 100644 tests/qemuxml2argvdata/hostdev-scsi-lsi.x86_64-latest.args
delete mode 100644 tests/qemuxml2argvdata/hostdev-scsi-readonly.args
delete mode 100644 tests/qemuxml2argvdata/hostdev-scsi-readonly.xml
delete mode 100644 tests/qemuxml2argvdata/hostdev-scsi-virtio-iscsi-auth.xml
delete mode 100644 tests/qemuxml2argvdata/hostdev-scsi-virtio-iscsi.args
delete mode 100644 tests/qemuxml2argvdata/hostdev-scsi-virtio-iscsi.xml
delete mode 100644 tests/qemuxml2argvdata/hostdev-scsi-virtio-scsi.args
rename tests/qemuxml2argvdata/{hostdev-scsi-virtio-iscsi-auth.args => hostdev-scsi-virtio-scsi.x86_64-2.8.0.args} (52%)
create mode 100644 tests/qemuxml2argvdata/hostdev-scsi-virtio-scsi.x86_64-4.1.0.args
create mode 100644 tests/qemuxml2argvdata/hostdev-scsi-virtio-scsi.x86_64-latest.args
delete mode 100644 tests/qemuxml2xmloutdata/hostdev-scsi-lsi-iscsi-auth.xml
delete mode 100644 tests/qemuxml2xmloutdata/hostdev-scsi-lsi-iscsi.xml
delete mode 100644 tests/qemuxml2xmloutdata/hostdev-scsi-readonly.xml
delete mode 100644 tests/qemuxml2xmloutdata/hostdev-scsi-virtio-iscsi-auth.xml
delete mode 100644 tests/qemuxml2xmloutdata/hostdev-scsi-virtio-iscsi.xml

[PATCH 00/12] qemuxml2*test: Improve testing of SCSI hostdevs

Posted by Peter Krempa 2 weeks ago
Switch to qemu caps based testing to validate pre and post blockdev
configs.

This is split out from my unfinished series for switching hostdevs to
blockdev.


Peter Krempa (12):
  qemuxml2argvtest: hostdev-scsi-lsi: Modernize to qemu-4.1
  qemuxml2argvtest: hostdev-scsi-lsi: Add qemu-2.8 variant
  qemuxml2argvtest: hostdev-scsi-lsi: Add "latest" caps version
  qemuxml2argvtest: hostdev-scsi-lsi: Add test of readonly variant
  qemuxml2argvtest: hostdev-scsi-lsi: Integrate 'hostdev-scsi-lsi-iscsi'
    case
  qemuxml2argvtest: hostdev-scsi-lsi: Integrate
    'hostdev-scsi-lsi-iscsi-auth' case
  qemuxml2argvtest: hostdev-scsi-virtio-scsi: Modernize to qemu-4.1
  qemuxml2argvtest: hostdev-scsi-virtio-scsi: Add "latest" caps version
  qemuxml2argvtest: hostdev-scsi-virtio-scsi: Add qemu-2.8 variant
  qemuxml2argvtest: hostdev-scsi-virtio-scsi: Integrate
    'hostdev-scsi-readonly'
  qemuxml2argvtest: hostdev-scsi-virtio-scsi: Integrate
    'hostdev-scsi-virtio-iscsi' case
  qemuxml2argvtest: hostdev-scsi-virtio-scsi: Integrate iSCSI
    authentication cases

 ...sk-hostdev-scsi-virtio-iscsi-auth-AES.args | 49 ------------
 ...isk-hostdev-scsi-virtio-iscsi-auth-AES.xml | 43 -----------
 .../hostdev-scsi-lsi-iscsi-auth.args          | 37 ----------
 .../hostdev-scsi-lsi-iscsi-auth.xml           | 48 ------------
 .../hostdev-scsi-lsi-iscsi.args               | 37 ----------
 .../hostdev-scsi-lsi-iscsi.xml                | 42 -----------
 tests/qemuxml2argvdata/hostdev-scsi-lsi.args  | 33 ---------
 .../hostdev-scsi-lsi.x86_64-2.8.0.args        | 51 +++++++++++++
 .../hostdev-scsi-lsi.x86_64-4.1.0.args        | 64 ++++++++++++++++
 .../hostdev-scsi-lsi.x86_64-latest.args       | 68 +++++++++++++++++
 tests/qemuxml2argvdata/hostdev-scsi-lsi.xml   | 38 ++++++++++
 .../hostdev-scsi-readonly.args                | 34 ---------
 .../hostdev-scsi-readonly.xml                 | 38 ----------
 .../hostdev-scsi-virtio-iscsi-auth.xml        | 48 ------------
 .../hostdev-scsi-virtio-iscsi.args            | 39 ----------
 .../hostdev-scsi-virtio-iscsi.xml             | 42 -----------
 .../hostdev-scsi-virtio-scsi.args             | 34 ---------
 ...ostdev-scsi-virtio-scsi.x86_64-2.8.0.args} | 40 +++++++---
 ...hostdev-scsi-virtio-scsi.x86_64-4.1.0.args | 70 ++++++++++++++++++
 ...ostdev-scsi-virtio-scsi.x86_64-latest.args | 74 +++++++++++++++++++
 .../hostdev-scsi-virtio-scsi.xml              | 38 ++++++++++
 tests/qemuxml2argvtest.c                      | 36 ++-------
 .../hostdev-scsi-lsi-iscsi-auth.xml           | 57 --------------
 .../hostdev-scsi-lsi-iscsi.xml                | 51 -------------
 tests/qemuxml2xmloutdata/hostdev-scsi-lsi.xml | 38 ++++++++++
 .../hostdev-scsi-readonly.xml                 | 47 ------------
 .../hostdev-scsi-virtio-iscsi-auth.xml        | 57 --------------
 .../hostdev-scsi-virtio-iscsi.xml             | 51 -------------
 .../hostdev-scsi-virtio-scsi.xml              | 38 ++++++++++
 tests/qemuxml2xmltest.c                       | 16 ----
 30 files changed, 515 insertions(+), 843 deletions(-)
 delete mode 100644 tests/qemuxml2argvdata/disk-hostdev-scsi-virtio-iscsi-auth-AES.args
 delete mode 100644 tests/qemuxml2argvdata/disk-hostdev-scsi-virtio-iscsi-auth-AES.xml
 delete mode 100644 tests/qemuxml2argvdata/hostdev-scsi-lsi-iscsi-auth.args
 delete mode 100644 tests/qemuxml2argvdata/hostdev-scsi-lsi-iscsi-auth.xml
 delete mode 100644 tests/qemuxml2argvdata/hostdev-scsi-lsi-iscsi.args
 delete mode 100644 tests/qemuxml2argvdata/hostdev-scsi-lsi-iscsi.xml
 delete mode 100644 tests/qemuxml2argvdata/hostdev-scsi-lsi.args
 create mode 100644 tests/qemuxml2argvdata/hostdev-scsi-lsi.x86_64-2.8.0.args
 create mode 100644 tests/qemuxml2argvdata/hostdev-scsi-lsi.x86_64-4.1.0.args
 create mode 100644 tests/qemuxml2argvdata/hostdev-scsi-lsi.x86_64-latest.args
 delete mode 100644 tests/qemuxml2argvdata/hostdev-scsi-readonly.args
 delete mode 100644 tests/qemuxml2argvdata/hostdev-scsi-readonly.xml
 delete mode 100644 tests/qemuxml2argvdata/hostdev-scsi-virtio-iscsi-auth.xml
 delete mode 100644 tests/qemuxml2argvdata/hostdev-scsi-virtio-iscsi.args
 delete mode 100644 tests/qemuxml2argvdata/hostdev-scsi-virtio-iscsi.xml
 delete mode 100644 tests/qemuxml2argvdata/hostdev-scsi-virtio-scsi.args
 rename tests/qemuxml2argvdata/{hostdev-scsi-virtio-iscsi-auth.args => hostdev-scsi-virtio-scsi.x86_64-2.8.0.args} (52%)
 create mode 100644 tests/qemuxml2argvdata/hostdev-scsi-virtio-scsi.x86_64-4.1.0.args
 create mode 100644 tests/qemuxml2argvdata/hostdev-scsi-virtio-scsi.x86_64-latest.args
 delete mode 100644 tests/qemuxml2xmloutdata/hostdev-scsi-lsi-iscsi-auth.xml
 delete mode 100644 tests/qemuxml2xmloutdata/hostdev-scsi-lsi-iscsi.xml
 delete mode 100644 tests/qemuxml2xmloutdata/hostdev-scsi-readonly.xml
 delete mode 100644 tests/qemuxml2xmloutdata/hostdev-scsi-virtio-iscsi-auth.xml
 delete mode 100644 tests/qemuxml2xmloutdata/hostdev-scsi-virtio-iscsi.xml

-- 
2.26.2

Re: [PATCH 00/12] qemuxml2*test: Improve testing of SCSI hostdevs

Posted by Michal Privoznik 2 weeks ago
On 6/22/20 5:42 PM, Peter Krempa wrote:
> Switch to qemu caps based testing to validate pre and post blockdev
> configs.
> 
> This is split out from my unfinished series for switching hostdevs to
> blockdev.
> 
> 
> Peter Krempa (12):
>    qemuxml2argvtest: hostdev-scsi-lsi: Modernize to qemu-4.1
>    qemuxml2argvtest: hostdev-scsi-lsi: Add qemu-2.8 variant
>    qemuxml2argvtest: hostdev-scsi-lsi: Add "latest" caps version
>    qemuxml2argvtest: hostdev-scsi-lsi: Add test of readonly variant
>    qemuxml2argvtest: hostdev-scsi-lsi: Integrate 'hostdev-scsi-lsi-iscsi'
>      case
>    qemuxml2argvtest: hostdev-scsi-lsi: Integrate
>      'hostdev-scsi-lsi-iscsi-auth' case
>    qemuxml2argvtest: hostdev-scsi-virtio-scsi: Modernize to qemu-4.1
>    qemuxml2argvtest: hostdev-scsi-virtio-scsi: Add "latest" caps version
>    qemuxml2argvtest: hostdev-scsi-virtio-scsi: Add qemu-2.8 variant
>    qemuxml2argvtest: hostdev-scsi-virtio-scsi: Integrate
>      'hostdev-scsi-readonly'
>    qemuxml2argvtest: hostdev-scsi-virtio-scsi: Integrate
>      'hostdev-scsi-virtio-iscsi' case
>    qemuxml2argvtest: hostdev-scsi-virtio-scsi: Integrate iSCSI
>      authentication cases
> 
>   ...sk-hostdev-scsi-virtio-iscsi-auth-AES.args | 49 ------------
>   ...isk-hostdev-scsi-virtio-iscsi-auth-AES.xml | 43 -----------
>   .../hostdev-scsi-lsi-iscsi-auth.args          | 37 ----------
>   .../hostdev-scsi-lsi-iscsi-auth.xml           | 48 ------------
>   .../hostdev-scsi-lsi-iscsi.args               | 37 ----------
>   .../hostdev-scsi-lsi-iscsi.xml                | 42 -----------
>   tests/qemuxml2argvdata/hostdev-scsi-lsi.args  | 33 ---------
>   .../hostdev-scsi-lsi.x86_64-2.8.0.args        | 51 +++++++++++++
>   .../hostdev-scsi-lsi.x86_64-4.1.0.args        | 64 ++++++++++++++++
>   .../hostdev-scsi-lsi.x86_64-latest.args       | 68 +++++++++++++++++
>   tests/qemuxml2argvdata/hostdev-scsi-lsi.xml   | 38 ++++++++++
>   .../hostdev-scsi-readonly.args                | 34 ---------
>   .../hostdev-scsi-readonly.xml                 | 38 ----------
>   .../hostdev-scsi-virtio-iscsi-auth.xml        | 48 ------------
>   .../hostdev-scsi-virtio-iscsi.args            | 39 ----------
>   .../hostdev-scsi-virtio-iscsi.xml             | 42 -----------
>   .../hostdev-scsi-virtio-scsi.args             | 34 ---------
>   ...ostdev-scsi-virtio-scsi.x86_64-2.8.0.args} | 40 +++++++---
>   ...hostdev-scsi-virtio-scsi.x86_64-4.1.0.args | 70 ++++++++++++++++++
>   ...ostdev-scsi-virtio-scsi.x86_64-latest.args | 74 +++++++++++++++++++
>   .../hostdev-scsi-virtio-scsi.xml              | 38 ++++++++++
>   tests/qemuxml2argvtest.c                      | 36 ++-------
>   .../hostdev-scsi-lsi-iscsi-auth.xml           | 57 --------------
>   .../hostdev-scsi-lsi-iscsi.xml                | 51 -------------
>   tests/qemuxml2xmloutdata/hostdev-scsi-lsi.xml | 38 ++++++++++
>   .../hostdev-scsi-readonly.xml                 | 47 ------------
>   .../hostdev-scsi-virtio-iscsi-auth.xml        | 57 --------------
>   .../hostdev-scsi-virtio-iscsi.xml             | 51 -------------
>   .../hostdev-scsi-virtio-scsi.xml              | 38 ++++++++++
>   tests/qemuxml2xmltest.c                       | 16 ----
>   30 files changed, 515 insertions(+), 843 deletions(-)
>   delete mode 100644 tests/qemuxml2argvdata/disk-hostdev-scsi-virtio-iscsi-auth-AES.args
>   delete mode 100644 tests/qemuxml2argvdata/disk-hostdev-scsi-virtio-iscsi-auth-AES.xml
>   delete mode 100644 tests/qemuxml2argvdata/hostdev-scsi-lsi-iscsi-auth.args
>   delete mode 100644 tests/qemuxml2argvdata/hostdev-scsi-lsi-iscsi-auth.xml
>   delete mode 100644 tests/qemuxml2argvdata/hostdev-scsi-lsi-iscsi.args
>   delete mode 100644 tests/qemuxml2argvdata/hostdev-scsi-lsi-iscsi.xml
>   delete mode 100644 tests/qemuxml2argvdata/hostdev-scsi-lsi.args
>   create mode 100644 tests/qemuxml2argvdata/hostdev-scsi-lsi.x86_64-2.8.0.args
>   create mode 100644 tests/qemuxml2argvdata/hostdev-scsi-lsi.x86_64-4.1.0.args
>   create mode 100644 tests/qemuxml2argvdata/hostdev-scsi-lsi.x86_64-latest.args
>   delete mode 100644 tests/qemuxml2argvdata/hostdev-scsi-readonly.args
>   delete mode 100644 tests/qemuxml2argvdata/hostdev-scsi-readonly.xml
>   delete mode 100644 tests/qemuxml2argvdata/hostdev-scsi-virtio-iscsi-auth.xml
>   delete mode 100644 tests/qemuxml2argvdata/hostdev-scsi-virtio-iscsi.args
>   delete mode 100644 tests/qemuxml2argvdata/hostdev-scsi-virtio-iscsi.xml
>   delete mode 100644 tests/qemuxml2argvdata/hostdev-scsi-virtio-scsi.args
>   rename tests/qemuxml2argvdata/{hostdev-scsi-virtio-iscsi-auth.args => hostdev-scsi-virtio-scsi.x86_64-2.8.0.args} (52%)
>   create mode 100644 tests/qemuxml2argvdata/hostdev-scsi-virtio-scsi.x86_64-4.1.0.args
>   create mode 100644 tests/qemuxml2argvdata/hostdev-scsi-virtio-scsi.x86_64-latest.args
>   delete mode 100644 tests/qemuxml2xmloutdata/hostdev-scsi-lsi-iscsi-auth.xml
>   delete mode 100644 tests/qemuxml2xmloutdata/hostdev-scsi-lsi-iscsi.xml
>   delete mode 100644 tests/qemuxml2xmloutdata/hostdev-scsi-readonly.xml
>   delete mode 100644 tests/qemuxml2xmloutdata/hostdev-scsi-virtio-iscsi-auth.xml
>   delete mode 100644 tests/qemuxml2xmloutdata/hostdev-scsi-virtio-iscsi.xml
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal