[PATCH 17/32] qemublocktest: Re-add bitmap validation for 'basic' and 'snapshots' cases

Peter Krempa posted 32 patches 5 years, 6 months ago
[PATCH 17/32] qemublocktest: Re-add bitmap validation for 'basic' and 'snapshots' cases
Posted by Peter Krempa 5 years, 6 months ago
Now that we've updated both the test data and the validator to new
semantics we can start testing again.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 tests/qemublocktest.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/tests/qemublocktest.c b/tests/qemublocktest.c
index 0ed9b99bc4..6d1bf3f250 100644
--- a/tests/qemublocktest.c
+++ b/tests/qemublocktest.c
@@ -1346,6 +1346,18 @@ mymain(void)

     TEST_BITMAP_VALIDATE("empty", "a", false);

+    TEST_BITMAP_VALIDATE("basic", "a", true);
+    TEST_BITMAP_VALIDATE("basic", "b", true);
+    TEST_BITMAP_VALIDATE("basic", "c", true);
+    TEST_BITMAP_VALIDATE("basic", "d", true);
+    TEST_BITMAP_VALIDATE("basic", "current", true);
+
+    TEST_BITMAP_VALIDATE("snapshots", "a", true);
+    TEST_BITMAP_VALIDATE("snapshots", "b", true);
+    TEST_BITMAP_VALIDATE("snapshots", "c", true);
+    TEST_BITMAP_VALIDATE("snapshots", "d", true);
+    TEST_BITMAP_VALIDATE("snapshots", "current", true);
+
 #define TEST_BITMAP_BLOCKCOPY(testname, shllw, ndf) \
     do { \
         blockbitmapblockcopydata.name = testname; \
-- 
2.26.2

Re: [PATCH 17/32] qemublocktest: Re-add bitmap validation for 'basic' and 'snapshots' cases
Posted by Eric Blake 5 years, 6 months ago
On 6/15/20 12:10 PM, Peter Krempa wrote:
> Now that we've updated both the test data and the validator to new
> semantics we can start testing again.
> 
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> ---
>   tests/qemublocktest.c | 12 ++++++++++++
>   1 file changed, 12 insertions(+)

Reviewed-by: Eric Blake <eblake@redhat.com>


-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org