[PATCH 0/3] leaseshelper: Wait to acquire PID file

Michal Privoznik posted 3 patches 3 years, 10 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1592218886.git.mprivozn@redhat.com
src/network/leaseshelper.c | 20 ++++++++++++++++----
1 file changed, 16 insertions(+), 4 deletions(-)
[PATCH 0/3] leaseshelper: Wait to acquire PID file
Posted by Michal Privoznik 3 years, 10 months ago
Patch 1/3 is for demonstration purposes only. The rest patches actual
problem.I was also thinking of making the PID file per bridge, i.e.
include bridge name in the name (e.g. /var/run/virbr0_leaseshelper.pid)
to decrease pressure on the single PID file. However, DHCP transactions
are not that frequent IMO so it's not really a bottle neck nor
performance issue.

Michal Prívozník (3):
  *** DO NOT APPLY UPSTREAM ***
  leaseshelper: Wait to acquire PID file
  leaseshelper: Report more errors

 src/network/leaseshelper.c | 20 ++++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)

-- 
2.26.2

Re: [PATCH 0/3] leaseshelper: Wait to acquire PID file
Posted by Michal Privoznik 3 years, 10 months ago
On 6/15/20 1:32 PM, Michal Privoznik wrote:
> Patch 1/3 is for demonstration purposes only. The rest patches actual
> problem.I was also thinking of making the PID file per bridge, i.e.
> include bridge name in the name (e.g. /var/run/virbr0_leaseshelper.pid)
> to decrease pressure on the single PID file. However, DHCP transactions
> are not that frequent IMO so it's not really a bottle neck nor
> performance issue.
> 
> Michal Prívozník (3):
>    *** DO NOT APPLY UPSTREAM ***
>    leaseshelper: Wait to acquire PID file
>    leaseshelper: Report more errors
> 
>   src/network/leaseshelper.c | 20 ++++++++++++++++----
>   1 file changed, 16 insertions(+), 4 deletions(-)
> 

Ping? We are getting close to the freeze and while this is a bugfix and 
could go in, we are getting close to the release too.

Michal