[v2] virsysinfo: Parse OEM strings

[PATCH v2 0/7] virsysinfo: Parse OEM strings

Michal Privoznik posted 7 patches 3 years, 10 months ago

Diff against v1
Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1591628594.git.mprivozn@redhat.com

src/util/virsysinfo.c                         | 151 +++++++++++++-----
src/util/virsysinfopriv.h                     |   3 +-
.../sysinfodata/aarch64-gigabytedmidecode.sh  |   3 -
tests/sysinfodata/x86dmidecode.sh             |   3 -
tests/sysinfodata/x86sysinfo.data             |   6 +
tests/sysinfodata/x86sysinfo.expect           |   8 +
tests/sysinfotest.c                           | 144 +++++++++--------
7 files changed, 203 insertions(+), 115 deletions(-)
delete mode 100755 tests/sysinfodata/aarch64-gigabytedmidecode.sh
delete mode 100755 tests/sysinfodata/x86dmidecode.sh

Expand all Fold all

[PATCH v2 0/7] virsysinfo: Parse OEM strings

Posted by Michal Privoznik 3 years, 10 months ago

v2 of:

https://www.redhat.com/archives/libvir-list/2020-June/msg00038.html

diff to v1:
- cleaned up sysinfotest so that it can use virCommandSetDryRun()
- Handle multiline strings (per Dan's suggestion in review of v1)

Michal Prívozník (7):
  virSysinfoReadDMI: Use more g_auto*()
  virSysinfoReadDMI: Drop needless virFindFileInPath()
  testSysinfo: Use more g_auto*()
  sysinfotest: Dissolve sysinfotest_run() in testSysinfo()
  sysinfotest: Move from custom dmidecode scripts to
    virCommandSetDryRun()
  virsysinfo: Drop global @sysinfoDmidecode
  virsysinfo: Parse OEM strings

 src/util/virsysinfo.c                         | 151 +++++++++++++-----
 src/util/virsysinfopriv.h                     |   3 +-
 .../sysinfodata/aarch64-gigabytedmidecode.sh  |   3 -
 tests/sysinfodata/x86dmidecode.sh             |   3 -
 tests/sysinfodata/x86sysinfo.data             |   6 +
 tests/sysinfodata/x86sysinfo.expect           |   8 +
 tests/sysinfotest.c                           | 144 +++++++++--------
 7 files changed, 203 insertions(+), 115 deletions(-)
 delete mode 100755 tests/sysinfodata/aarch64-gigabytedmidecode.sh
 delete mode 100755 tests/sysinfodata/x86dmidecode.sh

-- 
2.26.2

Re: [PATCH v2 0/7] virsysinfo: Parse OEM strings

Posted by Daniel P. Berrangé 3 years, 10 months ago

On Mon, Jun 08, 2020 at 05:06:14PM +0200, Michal Privoznik wrote:
> v2 of:
> 
> https://www.redhat.com/archives/libvir-list/2020-June/msg00038.html
> 
> diff to v1:
> - cleaned up sysinfotest so that it can use virCommandSetDryRun()
> - Handle multiline strings (per Dan's suggestion in review of v1)
> 
> Michal Prívozník (7):
>   virSysinfoReadDMI: Use more g_auto*()
>   virSysinfoReadDMI: Drop needless virFindFileInPath()
>   testSysinfo: Use more g_auto*()
>   sysinfotest: Dissolve sysinfotest_run() in testSysinfo()
>   sysinfotest: Move from custom dmidecode scripts to
>     virCommandSetDryRun()
>   virsysinfo: Drop global @sysinfoDmidecode
>   virsysinfo: Parse OEM strings

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|