[libvirt PATCH 2/2] qemu: only return two values in virQEMUDriverConfigLoadMemoryEntry

Ján Tomko posted 2 patches 5 years, 8 months ago
[libvirt PATCH 2/2] qemu: only return two values in virQEMUDriverConfigLoadMemoryEntry
Posted by Ján Tomko 5 years, 8 months ago
The intention of these split Load*Entry functions is to prevent
virQEMUDriverConfigLoadFile from getting too large.

There's no need to signal to the caller whether an entry was found
or not, only whether there was an error.

Remove the non-standard return 1.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 src/qemu/qemu_conf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
index 2d4e2a46f3..b49299e1de 100644
--- a/src/qemu/qemu_conf.c
+++ b/src/qemu/qemu_conf.c
@@ -977,7 +977,7 @@ virQEMUDriverConfigLoadMemoryEntry(virQEMUDriverConfigPtr cfg,
     } else if (rc > 0) {
         VIR_FREE(cfg->memoryBackingDir);
         cfg->memoryBackingDir = g_strdup_printf("%s/libvirt/qemu", dir);
-        return 1;
+        return 0;
     }
 
     return 0;
-- 
2.25.4