qemu: Restrict valid configurations for disk type='lun'

[PATCH 0/2] qemu: Restrict valid configurations for disk type='lun'

Peter Krempa posted 2 patches 3 years, 11 months ago

Download series mbox

Failed in applying to current master (apply log)

src/qemu/qemu_domain.c                  | 19 +++++++++++++++++++
src/qemu/qemu_validate.c                |  9 ++++-----
tests/qemuxml2argvdata/virtio-lun.args  |  4 ++--
tests/qemuxml2argvdata/virtio-lun.xml   |  4 ++--
tests/qemuxml2xmloutdata/virtio-lun.xml |  4 ++--
5 files changed, 29 insertions(+), 11 deletions(-)

Expand all Fold all

[PATCH 0/2] qemu: Restrict valid configurations for disk type='lun'

Posted by Peter Krempa 3 years, 11 months ago

Please see justification in the commits.

This series applies on top of some of the refactors from

https://www.redhat.com/archives/libvir-list/2020-May/msg00188.html

Peter Krempa (2):
  qemu: Forbid non-raw images for disk type='lun' with vitio-blk
    frontend
  qemu: domain: Forbid slice/encryption/copy_on_read with disk
    type='lun'

 src/qemu/qemu_domain.c                  | 19 +++++++++++++++++++
 src/qemu/qemu_validate.c                |  9 ++++-----
 tests/qemuxml2argvdata/virtio-lun.args  |  4 ++--
 tests/qemuxml2argvdata/virtio-lun.xml   |  4 ++--
 tests/qemuxml2xmloutdata/virtio-lun.xml |  4 ++--
 5 files changed, 29 insertions(+), 11 deletions(-)

-- 
2.26.2

Re: [PATCH 0/2] qemu: Restrict valid configurations for disk type='lun'

Posted by Michal Privoznik 3 years, 11 months ago

On 5/7/20 12:09 PM, Peter Krempa wrote:
> Please see justification in the commits.
> 
> This series applies on top of some of the refactors from
> 
> https://www.redhat.com/archives/libvir-list/2020-May/msg00188.html
> 
> Peter Krempa (2):
>    qemu: Forbid non-raw images for disk type='lun' with vitio-blk
>      frontend
>    qemu: domain: Forbid slice/encryption/copy_on_read with disk
>      type='lun'
> 
>   src/qemu/qemu_domain.c                  | 19 +++++++++++++++++++
>   src/qemu/qemu_validate.c                |  9 ++++-----
>   tests/qemuxml2argvdata/virtio-lun.args  |  4 ++--
>   tests/qemuxml2argvdata/virtio-lun.xml   |  4 ++--
>   tests/qemuxml2xmloutdata/virtio-lun.xml |  4 ++--
>   5 files changed, 29 insertions(+), 11 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal