[PATCH 0/8] qemu: caps: Add detection of default device property values and remove deprecated 'scsi=off'

Peter Krempa posted 8 patches 5 years, 9 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1588830947.git.pkrempa@redhat.com
src/qemu/qemu_capabilities.c                  | 347 ++++++++++--------
src/qemu/qemu_capabilities.h                  |   1 +
src/qemu/qemu_command.c                       |   4 +-
src/qemu/qemu_monitor.c                       |  11 +-
src/qemu/qemu_monitor.h                       |   5 +-
src/qemu/qemu_monitor_json.c                  |  58 ++-
src/qemu/qemu_monitor_json.h                  |   7 +-
.../caps_5.0.0.aarch64.xml                    |   1 +
.../qemucapabilitiesdata/caps_5.0.0.ppc64.xml |   1 +
.../caps_5.0.0.riscv64.xml                    |   1 +
.../caps_5.0.0.x86_64.xml                     |   1 +
.../caps_5.1.0.x86_64.xml                     |   1 +
...fault-cpu-kvm-virt-4.2.aarch64-latest.args |   2 +-
...fault-cpu-tcg-virt-4.2.aarch64-latest.args |   2 +-
.../aarch64-virt-graphics.aarch64-latest.args |   2 +-
.../aarch64-virt-headless.aarch64-latest.args |   2 +-
.../disk-aio-io_uring.x86_64-latest.args      |   2 +-
...-backing-chains-noindex.x86_64-latest.args |  12 +-
.../disk-cache.x86_64-latest.args             |   2 +-
.../disk-cdrom-tray.x86_64-latest.args        |   2 +-
.../disk-copy_on_read.x86_64-latest.args      |   2 +-
.../disk-detect-zeroes.x86_64-latest.args     |   2 +-
.../disk-network-gluster.x86_64-latest.args   |   6 +-
.../disk-network-http.x86_64-latest.args      |   8 +-
.../disk-network-iscsi.x86_64-latest.args     |   8 +-
.../disk-network-nbd.x86_64-latest.args       |  10 +-
.../disk-network-rbd.x86_64-latest.args       |  12 +-
.../disk-network-sheepdog.x86_64-latest.args  |   2 +-
...isk-network-source-auth.x86_64-latest.args |   4 +-
.../disk-network-tlsx509.x86_64-latest.args   |   8 +-
.../disk-nvme.x86_64-latest.args              |   8 +-
.../disk-shared.x86_64-latest.args            |   4 +-
.../disk-slices.x86_64-latest.args            |   6 +-
...threads-virtio-scsi-pci.x86_64-latest.args |   2 +-
...luks-disks-source-qcow2.x86_64-latest.args |  12 +-
...ault-cpu-kvm-pseries-2.7.ppc64-latest.args |   2 +-
...ault-cpu-kvm-pseries-3.1.ppc64-latest.args |   2 +-
...ault-cpu-kvm-pseries-4.2.ppc64-latest.args |   2 +-
...ault-cpu-tcg-pseries-2.7.ppc64-latest.args |   2 +-
...ault-cpu-tcg-pseries-3.1.ppc64-latest.args |   2 +-
...ault-cpu-tcg-pseries-4.2.ppc64-latest.args |   2 +-
.../ppc64-pseries-graphics.ppc64-latest.args  |   2 +-
.../ppc64-pseries-headless.ppc64-latest.args  |   2 +-
.../riscv64-virt-graphics.riscv64-latest.args |   2 +-
.../riscv64-virt-headless.riscv64-latest.args |   2 +-
...vhost-user-fs-hugepages.x86_64-latest.args |   2 +-
...virtio-non-transitional.x86_64-latest.args |   2 +-
...virtio-options-disk-ats.x86_64-latest.args |   8 +-
...rtio-options-disk-iommu.x86_64-latest.args |   4 +-
...tio-options-disk-packed.x86_64-latest.args |   8 +-
.../virtio-options.x86_64-latest.args         |   4 +-
.../virtio-transitional.x86_64-latest.args    |   4 +-
...-default-cpu-kvm-pc-4.2.x86_64-latest.args |   2 +-
...default-cpu-kvm-q35-4.2.x86_64-latest.args |   2 +-
...-default-cpu-tcg-pc-4.2.x86_64-latest.args |   2 +-
...default-cpu-tcg-q35-4.2.x86_64-latest.args |   2 +-
.../x86_64-pc-graphics.x86_64-latest.args     |   2 +-
.../x86_64-pc-headless.x86_64-latest.args     |   2 +-
.../x86_64-q35-graphics.x86_64-latest.args    |   2 +-
.../x86_64-q35-headless.x86_64-latest.args    |   2 +-
60 files changed, 356 insertions(+), 270 deletions(-)
[PATCH 0/8] qemu: caps: Add detection of default device property values and remove deprecated 'scsi=off'
Posted by Peter Krempa 5 years, 9 months ago
First part focuses on allowing the device property code to detect the
default values for the properties and the second part then uses it to
remove formatting of the deprecated 'scsi=off' for virti-blk-pci.

Peter Krempa (8):
  virQEMUCapsProbeQMPDevices: Split up into logical chunks
  virQEMUCapsProbeQMPDeviceProperties: Switch to local implementation
  virQEMUCapsProbeQMPObjectTypes: Fold in
    virQEMUCapsProbeQMPGenericProps
  qemuMonitorJSONGetDeviceProps: Refactor to modern standards
  qemuMonitorGetDeviceProps: Return data in a hash table
  virQEMUCapsProbeQMPDeviceProperties: Add per-property callbacks
  qemu: capabilities: Introduce
    QEMU_CAPS_VIRTIO_BLK_SCSI_DEFAULT_DISABLED
  qemu: command: Stop formatting of 'scsi=off' for virtio-blk-pci

 src/qemu/qemu_capabilities.c                  | 347 ++++++++++--------
 src/qemu/qemu_capabilities.h                  |   1 +
 src/qemu/qemu_command.c                       |   4 +-
 src/qemu/qemu_monitor.c                       |  11 +-
 src/qemu/qemu_monitor.h                       |   5 +-
 src/qemu/qemu_monitor_json.c                  |  58 ++-
 src/qemu/qemu_monitor_json.h                  |   7 +-
 .../caps_5.0.0.aarch64.xml                    |   1 +
 .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml |   1 +
 .../caps_5.0.0.riscv64.xml                    |   1 +
 .../caps_5.0.0.x86_64.xml                     |   1 +
 .../caps_5.1.0.x86_64.xml                     |   1 +
 ...fault-cpu-kvm-virt-4.2.aarch64-latest.args |   2 +-
 ...fault-cpu-tcg-virt-4.2.aarch64-latest.args |   2 +-
 .../aarch64-virt-graphics.aarch64-latest.args |   2 +-
 .../aarch64-virt-headless.aarch64-latest.args |   2 +-
 .../disk-aio-io_uring.x86_64-latest.args      |   2 +-
 ...-backing-chains-noindex.x86_64-latest.args |  12 +-
 .../disk-cache.x86_64-latest.args             |   2 +-
 .../disk-cdrom-tray.x86_64-latest.args        |   2 +-
 .../disk-copy_on_read.x86_64-latest.args      |   2 +-
 .../disk-detect-zeroes.x86_64-latest.args     |   2 +-
 .../disk-network-gluster.x86_64-latest.args   |   6 +-
 .../disk-network-http.x86_64-latest.args      |   8 +-
 .../disk-network-iscsi.x86_64-latest.args     |   8 +-
 .../disk-network-nbd.x86_64-latest.args       |  10 +-
 .../disk-network-rbd.x86_64-latest.args       |  12 +-
 .../disk-network-sheepdog.x86_64-latest.args  |   2 +-
 ...isk-network-source-auth.x86_64-latest.args |   4 +-
 .../disk-network-tlsx509.x86_64-latest.args   |   8 +-
 .../disk-nvme.x86_64-latest.args              |   8 +-
 .../disk-shared.x86_64-latest.args            |   4 +-
 .../disk-slices.x86_64-latest.args            |   6 +-
 ...threads-virtio-scsi-pci.x86_64-latest.args |   2 +-
 ...luks-disks-source-qcow2.x86_64-latest.args |  12 +-
 ...ault-cpu-kvm-pseries-2.7.ppc64-latest.args |   2 +-
 ...ault-cpu-kvm-pseries-3.1.ppc64-latest.args |   2 +-
 ...ault-cpu-kvm-pseries-4.2.ppc64-latest.args |   2 +-
 ...ault-cpu-tcg-pseries-2.7.ppc64-latest.args |   2 +-
 ...ault-cpu-tcg-pseries-3.1.ppc64-latest.args |   2 +-
 ...ault-cpu-tcg-pseries-4.2.ppc64-latest.args |   2 +-
 .../ppc64-pseries-graphics.ppc64-latest.args  |   2 +-
 .../ppc64-pseries-headless.ppc64-latest.args  |   2 +-
 .../riscv64-virt-graphics.riscv64-latest.args |   2 +-
 .../riscv64-virt-headless.riscv64-latest.args |   2 +-
 ...vhost-user-fs-hugepages.x86_64-latest.args |   2 +-
 ...virtio-non-transitional.x86_64-latest.args |   2 +-
 ...virtio-options-disk-ats.x86_64-latest.args |   8 +-
 ...rtio-options-disk-iommu.x86_64-latest.args |   4 +-
 ...tio-options-disk-packed.x86_64-latest.args |   8 +-
 .../virtio-options.x86_64-latest.args         |   4 +-
 .../virtio-transitional.x86_64-latest.args    |   4 +-
 ...-default-cpu-kvm-pc-4.2.x86_64-latest.args |   2 +-
 ...default-cpu-kvm-q35-4.2.x86_64-latest.args |   2 +-
 ...-default-cpu-tcg-pc-4.2.x86_64-latest.args |   2 +-
 ...default-cpu-tcg-q35-4.2.x86_64-latest.args |   2 +-
 .../x86_64-pc-graphics.x86_64-latest.args     |   2 +-
 .../x86_64-pc-headless.x86_64-latest.args     |   2 +-
 .../x86_64-q35-graphics.x86_64-latest.args    |   2 +-
 .../x86_64-q35-headless.x86_64-latest.args    |   2 +-
 60 files changed, 356 insertions(+), 270 deletions(-)

-- 
2.26.2

Re: [PATCH 0/8] qemu: caps: Add detection of default device property values and remove deprecated 'scsi=off'
Posted by Michal Privoznik 5 years, 9 months ago
On 5/7/20 7:57 AM, Peter Krempa wrote:
> First part focuses on allowing the device property code to detect the
> default values for the properties and the second part then uses it to
> remove formatting of the deprecated 'scsi=off' for virti-blk-pci.
> 
> Peter Krempa (8):
>    virQEMUCapsProbeQMPDevices: Split up into logical chunks
>    virQEMUCapsProbeQMPDeviceProperties: Switch to local implementation
>    virQEMUCapsProbeQMPObjectTypes: Fold in
>      virQEMUCapsProbeQMPGenericProps
>    qemuMonitorJSONGetDeviceProps: Refactor to modern standards
>    qemuMonitorGetDeviceProps: Return data in a hash table
>    virQEMUCapsProbeQMPDeviceProperties: Add per-property callbacks
>    qemu: capabilities: Introduce
>      QEMU_CAPS_VIRTIO_BLK_SCSI_DEFAULT_DISABLED
>    qemu: command: Stop formatting of 'scsi=off' for virtio-blk-pci
> 
>   src/qemu/qemu_capabilities.c                  | 347 ++++++++++--------
>   src/qemu/qemu_capabilities.h                  |   1 +
>   src/qemu/qemu_command.c                       |   4 +-
>   src/qemu/qemu_monitor.c                       |  11 +-
>   src/qemu/qemu_monitor.h                       |   5 +-
>   src/qemu/qemu_monitor_json.c                  |  58 ++-
>   src/qemu/qemu_monitor_json.h                  |   7 +-
>   .../caps_5.0.0.aarch64.xml                    |   1 +
>   .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml |   1 +
>   .../caps_5.0.0.riscv64.xml                    |   1 +
>   .../caps_5.0.0.x86_64.xml                     |   1 +
>   .../caps_5.1.0.x86_64.xml                     |   1 +
>   ...fault-cpu-kvm-virt-4.2.aarch64-latest.args |   2 +-
>   ...fault-cpu-tcg-virt-4.2.aarch64-latest.args |   2 +-
>   .../aarch64-virt-graphics.aarch64-latest.args |   2 +-
>   .../aarch64-virt-headless.aarch64-latest.args |   2 +-
>   .../disk-aio-io_uring.x86_64-latest.args      |   2 +-
>   ...-backing-chains-noindex.x86_64-latest.args |  12 +-
>   .../disk-cache.x86_64-latest.args             |   2 +-
>   .../disk-cdrom-tray.x86_64-latest.args        |   2 +-
>   .../disk-copy_on_read.x86_64-latest.args      |   2 +-
>   .../disk-detect-zeroes.x86_64-latest.args     |   2 +-
>   .../disk-network-gluster.x86_64-latest.args   |   6 +-
>   .../disk-network-http.x86_64-latest.args      |   8 +-
>   .../disk-network-iscsi.x86_64-latest.args     |   8 +-
>   .../disk-network-nbd.x86_64-latest.args       |  10 +-
>   .../disk-network-rbd.x86_64-latest.args       |  12 +-
>   .../disk-network-sheepdog.x86_64-latest.args  |   2 +-
>   ...isk-network-source-auth.x86_64-latest.args |   4 +-
>   .../disk-network-tlsx509.x86_64-latest.args   |   8 +-
>   .../disk-nvme.x86_64-latest.args              |   8 +-
>   .../disk-shared.x86_64-latest.args            |   4 +-
>   .../disk-slices.x86_64-latest.args            |   6 +-
>   ...threads-virtio-scsi-pci.x86_64-latest.args |   2 +-
>   ...luks-disks-source-qcow2.x86_64-latest.args |  12 +-
>   ...ault-cpu-kvm-pseries-2.7.ppc64-latest.args |   2 +-
>   ...ault-cpu-kvm-pseries-3.1.ppc64-latest.args |   2 +-
>   ...ault-cpu-kvm-pseries-4.2.ppc64-latest.args |   2 +-
>   ...ault-cpu-tcg-pseries-2.7.ppc64-latest.args |   2 +-
>   ...ault-cpu-tcg-pseries-3.1.ppc64-latest.args |   2 +-
>   ...ault-cpu-tcg-pseries-4.2.ppc64-latest.args |   2 +-
>   .../ppc64-pseries-graphics.ppc64-latest.args  |   2 +-
>   .../ppc64-pseries-headless.ppc64-latest.args  |   2 +-
>   .../riscv64-virt-graphics.riscv64-latest.args |   2 +-
>   .../riscv64-virt-headless.riscv64-latest.args |   2 +-
>   ...vhost-user-fs-hugepages.x86_64-latest.args |   2 +-
>   ...virtio-non-transitional.x86_64-latest.args |   2 +-
>   ...virtio-options-disk-ats.x86_64-latest.args |   8 +-
>   ...rtio-options-disk-iommu.x86_64-latest.args |   4 +-
>   ...tio-options-disk-packed.x86_64-latest.args |   8 +-
>   .../virtio-options.x86_64-latest.args         |   4 +-
>   .../virtio-transitional.x86_64-latest.args    |   4 +-
>   ...-default-cpu-kvm-pc-4.2.x86_64-latest.args |   2 +-
>   ...default-cpu-kvm-q35-4.2.x86_64-latest.args |   2 +-
>   ...-default-cpu-tcg-pc-4.2.x86_64-latest.args |   2 +-
>   ...default-cpu-tcg-q35-4.2.x86_64-latest.args |   2 +-
>   .../x86_64-pc-graphics.x86_64-latest.args     |   2 +-
>   .../x86_64-pc-headless.x86_64-latest.args     |   2 +-
>   .../x86_64-q35-graphics.x86_64-latest.args    |   2 +-
>   .../x86_64-q35-headless.x86_64-latest.args    |   2 +-
>   60 files changed, 356 insertions(+), 270 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal