Random almost trivial improvements

[PATCH 0/4] Random almost trivial improvements

Michal Privoznik posted 4 patches 3 years, 11 months ago

Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1588672891.git.mprivozn@redhat.com

src/conf/nwfilter_conf.c            |  6 +++---
src/conf/virstorageobj.c            |  2 +-
src/locking/lock_daemon.c           |  3 +--
src/logging/log_daemon.c            |  3 +--
src/lxc/lxc_driver.c                |  2 +-
src/nwfilter/nwfilter_dhcpsnoop.c   |  2 +-
src/qemu/qemu_agent.c               | 10 +++++-----
src/qemu/qemu_monitor.c             |  4 ++--
src/remote/remote_daemon.c          |  2 +-
src/remote/remote_daemon_config.c   |  8 ++++----
src/remote/remote_driver.c          |  2 +-
src/rpc/virnetlibsshsession.c       |  4 +---
src/rpc/virnetlibsshsession.h       |  4 ++--
src/rpc/virnetserver.c              |  7 ++++---
src/rpc/virnetserverclient.c        |  2 +-
src/rpc/virnetsocket.c              |  6 ++----
src/rpc/virnetsshsession.c          |  4 +---
src/rpc/virnetsshsession.h          |  4 ++--
src/storage/storage_backend_mpath.c |  3 +--
src/util/virnetlink.c               |  2 +-
src/util/virtime.c                  |  4 ++--
src/util/viruri.c                   |  2 +-
src/vmx/vmx.c                       |  4 ++--
tools/virt-host-validate-bhyve.c    |  3 +--
24 files changed, 42 insertions(+), 51 deletions(-)

Expand all Fold all

[PATCH 0/4] Random almost trivial improvements

Posted by Michal Privoznik 3 years, 11 months ago

These all stem out from me playing with coccinelle.

Michal Prívozník (4):
  virnetserver: Check for virNetServerClientInitKeepAlive() retval
  rpc: Make some functions void
  lib: Drop needless ret variables
  src: Fix boolean assignment

 src/conf/nwfilter_conf.c            |  6 +++---
 src/conf/virstorageobj.c            |  2 +-
 src/locking/lock_daemon.c           |  3 +--
 src/logging/log_daemon.c            |  3 +--
 src/lxc/lxc_driver.c                |  2 +-
 src/nwfilter/nwfilter_dhcpsnoop.c   |  2 +-
 src/qemu/qemu_agent.c               | 10 +++++-----
 src/qemu/qemu_monitor.c             |  4 ++--
 src/remote/remote_daemon.c          |  2 +-
 src/remote/remote_daemon_config.c   |  8 ++++----
 src/remote/remote_driver.c          |  2 +-
 src/rpc/virnetlibsshsession.c       |  4 +---
 src/rpc/virnetlibsshsession.h       |  4 ++--
 src/rpc/virnetserver.c              |  7 ++++---
 src/rpc/virnetserverclient.c        |  2 +-
 src/rpc/virnetsocket.c              |  6 ++----
 src/rpc/virnetsshsession.c          |  4 +---
 src/rpc/virnetsshsession.h          |  4 ++--
 src/storage/storage_backend_mpath.c |  3 +--
 src/util/virnetlink.c               |  2 +-
 src/util/virtime.c                  |  4 ++--
 src/util/viruri.c                   |  2 +-
 src/vmx/vmx.c                       |  4 ++--
 tools/virt-host-validate-bhyve.c    |  3 +--
 24 files changed, 42 insertions(+), 51 deletions(-)

-- 
2.26.2

Re: [PATCH 0/4] Random almost trivial improvements

Posted by Daniel P. Berrangé 3 years, 11 months ago

On Tue, May 05, 2020 at 12:10:04PM +0200, Michal Privoznik wrote:
> These all stem out from me playing with coccinelle.
> 
> Michal Prívozník (4):
>   virnetserver: Check for virNetServerClientInitKeepAlive() retval
>   rpc: Make some functions void
>   lib: Drop needless ret variables
>   src: Fix boolean assignment

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|