[PATCH 14/15] qemumonitorjsontest: Mark recently deprecated migration command in our tests

Peter Krempa posted 15 patches 5 years, 9 months ago
[PATCH 14/15] qemumonitorjsontest: Mark recently deprecated migration command in our tests
Posted by Peter Krempa 5 years, 9 months ago
"migrate_set_downtime", "migrate_set_speed", and
"query-migrate-cache-size" were marked as deprecated in the QMP schema
in qemu 5.0. Since libvirt still actively uses them we must not mark
them as okay to be missing, but still mark them as deprecated, so that
we can add tests for deprecated commands.

The replacement of the command usage in libvirt is tracked by:
https://bugzilla.redhat.com/show_bug.cgi?id=1829543
https://bugzilla.redhat.com/show_bug.cgi?id=1829544
https://bugzilla.redhat.com/show_bug.cgi?id=1829545

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 tests/qemumonitorjsontest.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c
index 82a8122f29..f58b18a110 100644
--- a/tests/qemumonitorjsontest.c
+++ b/tests/qemumonitorjsontest.c
@@ -1889,6 +1889,8 @@ testQemuMonitorJSONqemuMonitorJSONGetMigrationCacheSize(const void *opaque)
     if (!(test = qemuMonitorTestNewSchema(xmlopt, data->schema)))
         return -1;

+    qemuMonitorTestSkipDeprecatedValidation(test, false);
+
     if (qemuMonitorTestAddItem(test, "query-migrate-cache-size",
                                "{"
                                "    \"return\": 67108864,"
@@ -3219,8 +3221,8 @@ mymain(void)
     DO_TEST_GEN_DEPRECATED(qemuMonitorJSONChangeMedia, true);
     DO_TEST_GEN(qemuMonitorJSONSaveVirtualMemory);
     DO_TEST_GEN(qemuMonitorJSONSavePhysicalMemory);
-    DO_TEST_GEN(qemuMonitorJSONSetMigrationSpeed);
-    DO_TEST_GEN(qemuMonitorJSONSetMigrationDowntime);
+    DO_TEST_GEN_DEPRECATED(qemuMonitorJSONSetMigrationSpeed, false);
+    DO_TEST_GEN_DEPRECATED(qemuMonitorJSONSetMigrationDowntime, false);
     DO_TEST_GEN(qemuMonitorJSONMigrate);
     DO_TEST_GEN(qemuMonitorJSONDump);
     DO_TEST_GEN(qemuMonitorJSONGraphicsRelocate);
-- 
2.26.2

Re: [PATCH 14/15] qemumonitorjsontest: Mark recently deprecated migration command in our tests
Posted by Ján Tomko 5 years, 8 months ago
On a Wednesday in 2020, Peter Krempa wrote:
>"migrate_set_downtime", "migrate_set_speed", and
>"query-migrate-cache-size" were marked as deprecated in the QMP schema
>in qemu 5.0. Since libvirt still actively uses them we must not mark
>them as okay to be missing, but still mark them as deprecated, so that
>we can add tests for deprecated commands.
>
>The replacement of the command usage in libvirt is tracked by:
>https://bugzilla.redhat.com/show_bug.cgi?id=1829543
>https://bugzilla.redhat.com/show_bug.cgi?id=1829544
>https://bugzilla.redhat.com/show_bug.cgi?id=1829545
>
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> tests/qemumonitorjsontest.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano