[PATCH 0/8] tests: qemumonitor: Make fake qemu monitor failures more obvious

Peter Krempa posted 8 patches 4 years ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1587655269.git.pkrempa@redhat.com
build-aux/syntax-check.mk                     |   1 +
tests/cputest.c                               |   2 +
tests/qemuagenttest.c                         |  31 +--
.../caps_3.0.0.riscv32.replies                |  42 -----
.../caps_3.0.0.riscv64.replies                |  42 -----
.../caps_4.0.0.riscv32.replies                |  42 -----
.../caps_4.0.0.riscv64.replies                |  42 -----
tests/qemuhotplugtest.c                       |  12 +-
tests/qemumonitorjsontest.c                   |   2 +
tests/qemumonitortestutils.c                  | 176 +++++++++++-------
tests/qemumonitortestutils.h                  |   5 +-
11 files changed, 141 insertions(+), 256 deletions(-)
[PATCH 0/8] tests: qemumonitor: Make fake qemu monitor failures more obvious
Posted by Peter Krempa 4 years ago
See patch 4 and 8 for details.

Peter Krempa (8):
  tests: monitor: Rename qemuMonitorReportError to
    qemuMonitorTestAddErrorResponse
  qemuhotplugtest: detach: Add expected 'object-del' to
    disk-scsi-multipath case
  qemuhotplugtest: cpu: x86-modern-individual: Remove invalid test case
  qemumonitortestutils: Make test monitor failures more prominent
  qemucapabilitiesdata: riscv: Remove call to 'query-machines'
  qemuhotplugtest: Remove 'drive_del' expectation from failed cases
  qemumonitortestutils: Store a string identifying test monitor entry
  qemumonitortestutils: Enforce consumption of all items in test monitor

 build-aux/syntax-check.mk                     |   1 +
 tests/cputest.c                               |   2 +
 tests/qemuagenttest.c                         |  31 +--
 .../caps_3.0.0.riscv32.replies                |  42 -----
 .../caps_3.0.0.riscv64.replies                |  42 -----
 .../caps_4.0.0.riscv32.replies                |  42 -----
 .../caps_4.0.0.riscv64.replies                |  42 -----
 tests/qemuhotplugtest.c                       |  12 +-
 tests/qemumonitorjsontest.c                   |   2 +
 tests/qemumonitortestutils.c                  | 176 +++++++++++-------
 tests/qemumonitortestutils.h                  |   5 +-
 11 files changed, 141 insertions(+), 256 deletions(-)

-- 
2.26.0

Re: [PATCH 0/8] tests: qemumonitor: Make fake qemu monitor failures more obvious
Posted by Michal Privoznik 4 years ago
On 4/23/20 5:21 PM, Peter Krempa wrote:
> See patch 4 and 8 for details.
> 
> Peter Krempa (8):
>    tests: monitor: Rename qemuMonitorReportError to
>      qemuMonitorTestAddErrorResponse
>    qemuhotplugtest: detach: Add expected 'object-del' to
>      disk-scsi-multipath case
>    qemuhotplugtest: cpu: x86-modern-individual: Remove invalid test case
>    qemumonitortestutils: Make test monitor failures more prominent
>    qemucapabilitiesdata: riscv: Remove call to 'query-machines'
>    qemuhotplugtest: Remove 'drive_del' expectation from failed cases
>    qemumonitortestutils: Store a string identifying test monitor entry
>    qemumonitortestutils: Enforce consumption of all items in test monitor
> 
>   build-aux/syntax-check.mk                     |   1 +
>   tests/cputest.c                               |   2 +
>   tests/qemuagenttest.c                         |  31 +--
>   .../caps_3.0.0.riscv32.replies                |  42 -----
>   .../caps_3.0.0.riscv64.replies                |  42 -----
>   .../caps_4.0.0.riscv32.replies                |  42 -----
>   .../caps_4.0.0.riscv64.replies                |  42 -----
>   tests/qemuhotplugtest.c                       |  12 +-
>   tests/qemumonitorjsontest.c                   |   2 +
>   tests/qemumonitortestutils.c                  | 176 +++++++++++-------
>   tests/qemumonitortestutils.h                  |   5 +-
>   11 files changed, 141 insertions(+), 256 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal