[libvirt-ci PATCH 01/13] requirements: Introduce a requirements.txt file

Erik Skultety posted 13 patches 5 years, 9 months ago
[libvirt-ci PATCH 01/13] requirements: Introduce a requirements.txt file
Posted by Erik Skultety 5 years, 9 months ago
Right now, lcitool's users have 2 options to satisfy the tool's
dependencies: install them through the system package manager
system-wide or install through pip manually.
Since pip gives us the option to automate this process a tiny bit, let's
ship a requirements file. This targets users who are used to work
with Python virtual environments and install whatever it is necessary
inside.

Signed-off-by: Erik Skultety <eskultet@redhat.com>
---
 requirements.txt | 3 +++
 1 file changed, 3 insertions(+)
 create mode 100644 requirements.txt

diff --git a/requirements.txt b/requirements.txt
new file mode 100644
index 0000000..dc416fa
--- /dev/null
+++ b/requirements.txt
@@ -0,0 +1,3 @@
+ansible
+jenkins-job-builder
+toml
-- 
2.25.3

Re: [libvirt-ci PATCH 01/13] requirements: Introduce a requirements.txt file
Posted by Andrea Bolognani 5 years, 9 months ago
On Wed, 2020-04-22 at 15:28 +0200, Erik Skultety wrote:
> Right now, lcitool's users have 2 options to satisfy the tool's
> dependencies: install them through the system package manager
> system-wide or install through pip manually.
> Since pip gives us the option to automate this process a tiny bit, let's
> ship a requirements file. This targets users who are used to work
> with Python virtual environments and install whatever it is necessary
> inside.

I remember Katerina suggesting that we add this, literally years
ago O:-)

> +++ b/requirements.txt

This is only relevat to lcitool, so it should go into the guests/
directory.

> +ansible
> +jenkins-job-builder
> +toml

You don't actually use the toml module until 6/13, so leave this
last line out until then.

I haven't actually tested whether this work, but I trust you did
and it certainly will not get in the way, so with the above fixed

  Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization