[PATCH 1/5] remote: remoteDispatchDomainGetJobStats: Encode typed parameter strings

Peter Krempa posted 5 patches 5 years, 9 months ago
[PATCH 1/5] remote: remoteDispatchDomainGetJobStats: Encode typed parameter strings
Posted by Peter Krempa 5 years, 9 months ago
String typed parameter values were introduced in v0.9.7-30-g40624d32fb.
virDomainGetJobStats was introduced in v1.0.2-239-g4dd00f4238 so all
clients already support typed parameter stings at that time thus we can
enable it unconditionally.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/remote/remote_daemon_dispatch.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/remote/remote_daemon_dispatch.c b/src/remote/remote_daemon_dispatch.c
index c5506c2e11..5d1c6971c0 100644
--- a/src/remote/remote_daemon_dispatch.c
+++ b/src/remote/remote_daemon_dispatch.c
@@ -5505,7 +5505,7 @@ remoteDispatchDomainGetJobStats(virNetServerPtr server G_GNUC_UNUSED,
                                 REMOTE_DOMAIN_JOB_STATS_MAX,
                                 (virTypedParameterRemotePtr *) &ret->params.params_val,
                                 &ret->params.params_len,
-                                0) < 0)
+                                VIR_TYPED_PARAM_STRING_OKAY) < 0)
         goto cleanup;

     rv = 0;
-- 
2.26.0

Re: [PATCH 1/5] remote: remoteDispatchDomainGetJobStats: Encode typed parameter strings
Posted by Eric Blake 5 years, 9 months ago
On 4/16/20 4:55 AM, Peter Krempa wrote:
> String typed parameter values were introduced in v0.9.7-30-g40624d32fb.
> virDomainGetJobStats was introduced in v1.0.2-239-g4dd00f4238 so all
> clients already support typed parameter stings at that time thus we can
> enable it unconditionally.
> 
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> ---
>   src/remote/remote_daemon_dispatch.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org