[PATCH v3 00/10] Another round of qemu:///embed fixes

Michal Privoznik posted 10 patches 4 years ago
Test syntax-check failed
Failed in applying to current master (apply log)
src/conf/domain_conf.c                        | 72 ---------------
src/conf/domain_conf.h                        |  7 --
src/hypervisor/domain_driver.c                | 88 +++++++++++++++++++
src/hypervisor/domain_driver.h                | 11 +++
src/libvirt_private.syms                      |  3 +-
src/lxc/lxc_domain.c                          |  3 +-
src/qemu/qemu_cgroup.c                        |  4 +-
src/qemu/qemu_command.c                       | 23 +++--
src/qemu/qemu_conf.c                          | 76 +++++++++-------
src/qemu/qemu_conf.h                          | 23 +++--
src/qemu/qemu_domain.c                        | 19 ++--
src/qemu/qemu_driver.c                        | 42 ++++-----
src/qemu/qemu_interface.c                     |  6 +-
src/qemu/qemu_process.c                       |  7 +-
tests/domaincapstest.c                        |  2 +-
.../qemuxml2argvdata/cpu-numa-memshared.args  |  8 +-
.../fd-memory-no-numa-topology.args           |  2 +-
.../fd-memory-numa-topology.args              |  4 +-
.../fd-memory-numa-topology2.args             |  8 +-
.../fd-memory-numa-topology3.args             | 12 +--
.../hugepages-memaccess2.args                 | 12 +--
.../qemuxml2argvdata/pages-dimm-discard.args  |  4 +-
...vhost-user-fs-fd-memory.x86_64-latest.args |  2 +-
tests/testutilsqemu.c                         |  2 +-
tests/virsystemdtest.c                        |  5 +-
25 files changed, 235 insertions(+), 210 deletions(-)
[PATCH v3 00/10] Another round of qemu:///embed fixes
Posted by Michal Privoznik 4 years ago
v3 of:

https://www.redhat.com/archives/libvir-list/2020-March/msg01112.html

diff to v2:
- Patch 2/10 is new; after discussion to v2 we can access
  driver->privileged and driver->embeddedRoot directly
- Patch 3/10 is slightly reworked; it still drops unnecessary layers of
  nesting in the default case (/var/lib/libvirt/qemu/ram) but it doesn't
  do that if user provides a path via qemu.conf

Michal Prívozník (10):
  tests: Fix virQEMUDriverConfigNew() calling with respect to @root
  qemu: Drop virQEMUDriverIsPrivileged()
  qemu: Drop two layers of nesting of memoryBackingDir
  conf: Move virDomainGenerateMachineName to hypervisor/
  virDomainDriverGenerateMachineName: Factor out embed path hashing
  qemuDomainGetMachineName: Access embeddedRoot from driver rather than
    cfg
  Revert "qemu_conf: Track embed root dir"
  qemu: Make hugepages path generation embed driver aware
  qemu: Make memory path generation embed driver aware
  qemu: Make auto dump path generation embed driver aware

 src/conf/domain_conf.c                        | 72 ---------------
 src/conf/domain_conf.h                        |  7 --
 src/hypervisor/domain_driver.c                | 88 +++++++++++++++++++
 src/hypervisor/domain_driver.h                | 11 +++
 src/libvirt_private.syms                      |  3 +-
 src/lxc/lxc_domain.c                          |  3 +-
 src/qemu/qemu_cgroup.c                        |  4 +-
 src/qemu/qemu_command.c                       | 23 +++--
 src/qemu/qemu_conf.c                          | 76 +++++++++-------
 src/qemu/qemu_conf.h                          | 23 +++--
 src/qemu/qemu_domain.c                        | 19 ++--
 src/qemu/qemu_driver.c                        | 42 ++++-----
 src/qemu/qemu_interface.c                     |  6 +-
 src/qemu/qemu_process.c                       |  7 +-
 tests/domaincapstest.c                        |  2 +-
 .../qemuxml2argvdata/cpu-numa-memshared.args  |  8 +-
 .../fd-memory-no-numa-topology.args           |  2 +-
 .../fd-memory-numa-topology.args              |  4 +-
 .../fd-memory-numa-topology2.args             |  8 +-
 .../fd-memory-numa-topology3.args             | 12 +--
 .../hugepages-memaccess2.args                 | 12 +--
 .../qemuxml2argvdata/pages-dimm-discard.args  |  4 +-
 ...vhost-user-fs-fd-memory.x86_64-latest.args |  2 +-
 tests/testutilsqemu.c                         |  2 +-
 tests/virsystemdtest.c                        |  5 +-
 25 files changed, 235 insertions(+), 210 deletions(-)

-- 
2.24.1

Re: [PATCH v3 00/10] Another round of qemu:///embed fixes
Posted by Andrea Bolognani 4 years ago
On Tue, 2020-03-31 at 18:24 +0200, Michal Privoznik wrote:
> v3 of:
> 
> https://www.redhat.com/archives/libvir-list/2020-March/msg01112.html
> 
> diff to v2:
> - Patch 2/10 is new; after discussion to v2 we can access
>   driver->privileged and driver->embeddedRoot directly
> - Patch 3/10 is slightly reworked; it still drops unnecessary layers of
>   nesting in the default case (/var/lib/libvirt/qemu/ram) but it doesn't
>   do that if user provides a path via qemu.conf
> 
> Michal Prívozník (10):
>   tests: Fix virQEMUDriverConfigNew() calling with respect to @root
>   qemu: Drop virQEMUDriverIsPrivileged()
>   qemu: Drop two layers of nesting of memoryBackingDir
>   conf: Move virDomainGenerateMachineName to hypervisor/
>   virDomainDriverGenerateMachineName: Factor out embed path hashing
>   qemuDomainGetMachineName: Access embeddedRoot from driver rather than
>     cfg
>   Revert "qemu_conf: Track embed root dir"
>   qemu: Make hugepages path generation embed driver aware
>   qemu: Make memory path generation embed driver aware
>   qemu: Make auto dump path generation embed driver aware

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization