[PATCH 1/2] syntax-check: Disallow plain fork() in src/libvirt.c

Michal Privoznik posted 2 patches 5 years, 10 months ago
[PATCH 1/2] syntax-check: Disallow plain fork() in src/libvirt.c
Posted by Michal Privoznik 5 years, 10 months ago
The last usage of plain fork() was removed in v0.9.7-rc1~50, but
we forgot to update the syntax-check exemption list accordingly.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 build-aux/syntax-check.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index 45bcf45e80..888e358848 100644
--- a/build-aux/syntax-check.mk
+++ b/build-aux/syntax-check.mk
@@ -2016,7 +2016,7 @@ exclude_file_name_regexp--sc_prohibit_close = \
 exclude_file_name_regexp--sc_prohibit_empty_lines_at_EOF = \
   (^tests/(virhostcpu|virpcitest)data/|docs/js/.*\.js|docs/fonts/.*\.woff|\.diff|tests/virconfdata/no-newline\.conf$$)
 
-_src2=src/(util/(vircommand|virdaemon)|libvirt|lxc/lxc_controller)
+_src2=src/(util/(vircommand|virdaemon)|lxc/lxc_controller)
 exclude_file_name_regexp--sc_prohibit_fork_wrappers = \
   (^($(_src2)|tests/testutils)\.c$$)
 
-- 
2.24.1

Re: [PATCH 1/2] syntax-check: Disallow plain fork() in src/libvirt.c
Posted by Daniel P. Berrangé 5 years, 10 months ago
On Fri, Mar 27, 2020 at 04:29:54PM +0100, Michal Privoznik wrote:
> The last usage of plain fork() was removed in v0.9.7-rc1~50, but
> we forgot to update the syntax-check exemption list accordingly.
> 
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>  build-aux/syntax-check.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|