[PATCH 2/2] syntax-check.mk: Drop needless _src2 variable

Michal Privoznik posted 2 patches 5 years, 10 months ago
[PATCH 2/2] syntax-check.mk: Drop needless _src2 variable
Posted by Michal Privoznik 5 years, 10 months ago
The aim was to break a long line, but it is not long anymore.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 build-aux/syntax-check.mk | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index 888e358848..db3c0cff0f 100644
--- a/build-aux/syntax-check.mk
+++ b/build-aux/syntax-check.mk
@@ -2016,9 +2016,8 @@ exclude_file_name_regexp--sc_prohibit_close = \
 exclude_file_name_regexp--sc_prohibit_empty_lines_at_EOF = \
   (^tests/(virhostcpu|virpcitest)data/|docs/js/.*\.js|docs/fonts/.*\.woff|\.diff|tests/virconfdata/no-newline\.conf$$)
 
-_src2=src/(util/(vircommand|virdaemon)|lxc/lxc_controller)
 exclude_file_name_regexp--sc_prohibit_fork_wrappers = \
-  (^($(_src2)|tests/testutils)\.c$$)
+  (^(src/(util/(vircommand|virdaemon)|lxc/lxc_controller)|tests/testutils)\.c$$)
 
 exclude_file_name_regexp--sc_prohibit_gethostname = ^src/util/vir(util|log)\.c$$
 
-- 
2.24.1

Re: [PATCH 2/2] syntax-check.mk: Drop needless _src2 variable
Posted by Daniel P. Berrangé 5 years, 10 months ago
On Fri, Mar 27, 2020 at 04:29:55PM +0100, Michal Privoznik wrote:
> The aim was to break a long line, but it is not long anymore.
> 
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>  build-aux/syntax-check.mk | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|