Accept http cookies with quoted value

[PATCH 0/2] Accept http cookies with quoted value

Peter Krempa posted 2 patches 4 years, 1 month ago

Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1585151909.git.pkrempa@redhat.com

docs/schemas/domaincommon.rng                 |  2 +-
src/util/virstoragefile.c                     | 19 ++++-
.../disk-network-http.x86_64-latest.args      |  4 +-
tests/qemuxml2argvdata/disk-network-http.xml  |  4 +-
.../disk-network-http.x86_64-latest.xml       | 71 +++++++++++++++++++
tests/qemuxml2xmltest.c                       |  2 +
6 files changed, 96 insertions(+), 6 deletions(-)
create mode 100644 tests/qemuxml2xmloutdata/disk-network-http.x86_64-latest.xml

Expand all Fold all

[PATCH 0/2] Accept http cookies with quoted value

Posted by Peter Krempa 4 years, 1 month ago

The validator didn't accept the quoted version of the cookie value. Add
a test and fix the issue.

Peter Krempa (2):
  qemuxml2xmltest: Wire up 'disk-network-http' case
  virStorageSourceNetCookieValidate: Accept quoted cookie value

 docs/schemas/domaincommon.rng                 |  2 +-
 src/util/virstoragefile.c                     | 19 ++++-
 .../disk-network-http.x86_64-latest.args      |  4 +-
 tests/qemuxml2argvdata/disk-network-http.xml  |  4 +-
 .../disk-network-http.x86_64-latest.xml       | 71 +++++++++++++++++++
 tests/qemuxml2xmltest.c                       |  2 +
 6 files changed, 96 insertions(+), 6 deletions(-)
 create mode 100644 tests/qemuxml2xmloutdata/disk-network-http.x86_64-latest.xml

-- 
2.24.1

Re: [PATCH 0/2] Accept http cookies with quoted value

Posted by Ján Tomko 4 years, 1 month ago

On a Wednesday in 2020, Peter Krempa wrote:
>The validator didn't accept the quoted version of the cookie value. Add
>a test and fix the issue.
>
>Peter Krempa (2):
>  qemuxml2xmltest: Wire up 'disk-network-http' case
>  virStorageSourceNetCookieValidate: Accept quoted cookie value
>
> docs/schemas/domaincommon.rng                 |  2 +-
> src/util/virstoragefile.c                     | 19 ++++-
> .../disk-network-http.x86_64-latest.args      |  4 +-
> tests/qemuxml2argvdata/disk-network-http.xml  |  4 +-
> .../disk-network-http.x86_64-latest.xml       | 71 +++++++++++++++++++
> tests/qemuxml2xmltest.c                       |  2 +
> 6 files changed, 96 insertions(+), 6 deletions(-)
> create mode 100644 tests/qemuxml2xmloutdata/disk-network-http.x86_64-latest.xml
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano